From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lj1-f176.google.com (mail-lj1-f176.google.com [209.85.208.176]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E37981534ED for ; Fri, 3 May 2024 12:03:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.176 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714737836; cv=none; b=P5Jr6kD/Ga2OOgVzB04e/T72TN1UUnrd1RxFuRVE5891/swZtk24lZm1IJViaRs/pyoEcYGArxibVWmAOEGf3L6yfSvdDQCaMVc+AgbUYt/oJkQQIVWrDuhoF60mDz781ZO67wmdFJI2s5gqnAFfMpS4zI800x2X2cN4XPB2w5o= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714737836; c=relaxed/simple; bh=YAfw+44GrwxVCpNrIpKjwL11goqT1d4qp4kk6VgGVZQ=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=HQZZTE6+811YY9HCScUVwwrkNvBCgzZKOL5rgN0rzOeFEFNSyzR6jvVl55Zp9UYsAit3r1+2OZfF1lBHcDd1IhOMPtW77v0bQvfV3GlzjWdwC/4iCnkrfe4UBl0bHVn2O2qbd/O+b24y1UNwCAGCdeSM39Ok1YQ65M2Y/iv4Mcw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=QZ+iyjq4; arc=none smtp.client-ip=209.85.208.176 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="QZ+iyjq4" Received: by mail-lj1-f176.google.com with SMTP id 38308e7fff4ca-2e0b2ddc5d1so61231301fa.3 for ; Fri, 03 May 2024 05:03:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1714737831; x=1715342631; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=FSYDfuxpfpjjgO0TIUjpx7luoxEoUEhhOeg90L/l18U=; b=QZ+iyjq4hEvf4EBR2WyaQjE4zOxSfufNdX98JEuAkfBwcZUUeMOTrDkAajUWQOPWLf tZpzMgp+B4FFMQ7k8k3uGBqADT12kgKISa3RyEQOOy5zl8gP5Tzyb3VBpuyp1UPoGSN7 CuuviI12I/LAaNwHo4+XC/iUIe6wlI0z6XUt15/Rh1OGc0Sm0AXdqe+FBSnUwj0M4eRI CCsDrNt7JTiBZcPQXsNJiiVnOjwNqctqBsA3b4Z1vnz+wg/DQXaZkP7C7cDLPC2TBtIR Bwfv0KjMCEPmuae0UOVxQ5uwgZJv2PCofS4h0kgeDIz3Conl+tr5s30+pPJht55KCb5T jzqg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1714737831; x=1715342631; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=FSYDfuxpfpjjgO0TIUjpx7luoxEoUEhhOeg90L/l18U=; b=d0o4vp+7Sq+in9aXTjcGkUaKCKPpBCgdr2FYWRrg3II3kMaxeCSuM9oggf3xv5dxDQ dwVC8m40s/kq4pyHs9D4zyCDyPV/Sd2HiRMLb8U+3XuFf/kMpk/HXCchAiirz0EBD4+O +A2ci/0gffkA1d63iPUBlyvgACX0rrFP7bMELF9NcQzE/fJKbQUWlZLvIyBNHW8lyBru AH2BdIlYhayR/2ALTwMnEecA8yyyTxkAanGlcgBjb0fxs9gETLvpUYJq9R8GWomQoxoJ JDu1GAl6KFO9yQgvx0RcLEDlwjowHAFIwfv96WjG/WEjPiQsx8uWQtOS5Ab4cg4Yo1DN KQEg== X-Forwarded-Encrypted: i=1; AJvYcCU198ktA/1/seNtD32dfKacL08LIcao8RSV5M8dYbOJ039o2qzvw9Cz+wjl3mAsFd8AhgHKFIcD9RYe0puEMO3pSkienE79xSiVrmQc X-Gm-Message-State: AOJu0YymXrYPr1oK7ggeaVoy02b390T39J4j+xlBDkCbSn+PwWbDoakr sKSn7XNNgMpbkhqoXN4+xkxEFZ0u8QLH4vFMUNsNEzY8fCzdiW0vcr+el4ajfOM= X-Google-Smtp-Source: AGHT+IFA1sx3j8flPwKwUT2GNTegKECdDziIj/x8NxqUEUwJkdRekIZxfJ+EtP+j4wc2SkthFoSueg== X-Received: by 2002:a2e:b17c:0:b0:2e1:bdfd:ce5f with SMTP id a28-20020a2eb17c000000b002e1bdfdce5fmr1718819ljm.44.1714737830869; Fri, 03 May 2024 05:03:50 -0700 (PDT) Received: from localhost ([102.222.70.76]) by smtp.gmail.com with ESMTPSA id p9-20020a05600c1d8900b0041563096e15sm9203067wms.5.2024.05.03.05.03.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 03 May 2024 05:03:50 -0700 (PDT) Date: Fri, 3 May 2024 15:03:43 +0300 From: Dan Carpenter To: Jameson Thies Cc: heikki.krogerus@linux.intel.com, linux-usb@vger.kernel.org, pmalani@chromium.org, bleung@google.com, abhishekpandit@chromium.org, andersson@kernel.org, dmitry.baryshkov@linaro.org, fabrice.gasnier@foss.st.com, gregkh@linuxfoundation.org, hdegoede@redhat.com, neil.armstrong@linaro.org, rajaram.regupathy@intel.com, saranya.gopal@intel.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 1/4] usb: typec: ucsi: Fix null deref in trace Message-ID: References: <20240424014821.4154159-1-jthies@google.com> <20240424014821.4154159-2-jthies@google.com> <32855f4c-f219-4396-81c3-42cbea9fe4da@moroto.mountain> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: It looks like in v3 you changed this to: - return NULL; + return typec_port_register_altmode(con->port, desc); Which is fine. Returning a special error pointer which means success is the part that I objected to. regards, dan carpenter