From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 64733C7EE43 for ; Mon, 12 Jun 2023 22:32:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238778AbjFLWcQ (ORCPT ); Mon, 12 Jun 2023 18:32:16 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46242 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238014AbjFLWcN (ORCPT ); Mon, 12 Jun 2023 18:32:13 -0400 Received: from mail-il1-x12e.google.com (mail-il1-x12e.google.com [IPv6:2607:f8b0:4864:20::12e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C646A1713 for ; Mon, 12 Jun 2023 15:32:11 -0700 (PDT) Received: by mail-il1-x12e.google.com with SMTP id e9e14a558f8ab-33dbad61311so3235495ab.0 for ; Mon, 12 Jun 2023 15:32:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=google; t=1686609131; x=1689201131; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=zO8aM9RsIffIjx4jAwj5YcVlYgxgznlqdMEphKaCDWk=; b=eGRWpJQyLSZ6IJ+0Ht1B84epSUoTv4pGbA2zVUUlO+1PNHFgxxNITeeSnByn3mXOTx Qi4G578qXQJw2cI1mU5N4iGZkTcyjm5XG1NKGzusRMBQWN3pJvILgFsUxYr+9e1OykwC RVIzfpZWwskQp9n7U40PWoJmEH7D5W+BV8qKo= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686609131; x=1689201131; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=zO8aM9RsIffIjx4jAwj5YcVlYgxgznlqdMEphKaCDWk=; b=jovKr68hSSup7TwCB55907kMpOp8NAJ/hhINi0EFQlHLNAWV6qCPc8i+khZkTtt2Am mpUI/W4SqJW3NJEIOkR8E4GCSKlG+Wg4V3xsdjCi3LLecGh2iOC04RqjppJ+JhAoVFyR UG4+fhBUzu42S8zmufBKsSS4uTm5k0d5RSkvrX35HRtqNQawRsp4HOiQwJPctiluZGUO 6eBqxV9f8PsrQ7ZlRIxP6QWNAytMIr4C46cw29dP9Ym/OBCbcLH7jW1t3/Ca4XFyRA9l k4OAESW1E1M+sIWq7KB7oMSL85AWw65GColBe/gHcEF0obyDqrDH0UesDDnzpn2Sn/oI n8bw== X-Gm-Message-State: AC+VfDx/vac/MKzA357gXKHbp/4tH9NEhPtYttixZOVbcrP9SZIIaI0U uExfRjp2fzzcfzT2xqUet3clvA== X-Google-Smtp-Source: ACHHUZ4faLgbaPTuPJztAFxODz/u7zHgz+n9zvWgBtWNe3m/0cIMYBx82V/NN7XO82lNQl6eKLSOag== X-Received: by 2002:a05:6e02:585:b0:33b:3a14:c14c with SMTP id c5-20020a056e02058500b0033b3a14c14cmr5983221ils.3.1686609131185; Mon, 12 Jun 2023 15:32:11 -0700 (PDT) Received: from [192.168.1.128] ([38.15.45.1]) by smtp.gmail.com with ESMTPSA id 6-20020a920d06000000b0033d136f248esm3474021iln.5.2023.06.12.15.32.10 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 12 Jun 2023 15:32:10 -0700 (PDT) Message-ID: Date: Mon, 12 Jun 2023 16:32:10 -0600 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 Subject: Re: [PATCHv2] selftests: damon: add config file Content-Language: en-US To: SeongJae Park Cc: akpm@linux-foundation.org, Anders Roxell , shuah@kernel.org, linux-kernel@vger.kernel.org, damon@lists.linux.dev, linux-mm@kvack.org, linux-kselftest@vger.kernel.org, Naresh Kamboju , Shuah Khan References: <20230609191622.80289-1-sj@kernel.org> From: Shuah Khan In-Reply-To: <20230609191622.80289-1-sj@kernel.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 6/9/23 13:16, SeongJae Park wrote: > On Wed, 12 Apr 2023 16:58:06 +0000 SeongJae Park wrote: > >> Hi Anders, >> >> On Wed, 12 Apr 2023 11:28:54 +0200 Anders Roxell wrote: >> >>> Building and running the subsuite 'damon' of kselftest, shows the >>> following issues: >>> selftests: damon: debugfs_attrs.sh >>> /sys/kernel/debug/damon not found >>> >>> By creating a config file enabling DAMON fragments in the >>> selftests/damon/ directory the tests pass. >>> >>> Fixes: b348eb7abd09 ("mm/damon: add user space selftests") >>> Reported-by: Naresh Kamboju >> >> checkpatch.pl is warning as below: >> >> WARNING: Reported-by: should be immediately followed by Link: with a URL to the report >> #20: >> Reported-by: Naresh Kamboju >> Signed-off-by: Anders Roxell >> >> The reason for the warning can be found from commit d7f1d71e5ef6 ("checkpatch: >> warn when Reported-by: is not followed by Link:")'s commit message. Do you >> have a link to put here? I guess the report was made inside Linaro, so might >> have no publicly available link. Maybe better to add some notes or some funny >> tag like "Link: N/A # no publicly-available link of the report" for convincing >> the tool, but I don't think this should be a blocker for this patch. >> >>> Signed-off-by: Anders Roxell >> >> Reviewed-by: SeongJae Park > > Shuah, may I ask your opinion on this patch? > > I'm also cc-ing Andrew, as he may also interested in picking this patch. > If Andrew wants to pick this up: Acked-by: Shuah Khan thanks, -- Shuah