From: Babis Chalios <bchalios@amazon.es>
To: "Jason A. Donenfeld" <Jason@zx2c4.com>, <tytso@mit.edu>,
<robh@kernel.org>, <krzk@kernel.org>, <conor+dt@kernel.org>,
<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<sudanl@amazon.com>, <graf@amazon.com>, <dwmw@amazon.co.uk>,
<krzysztof.kozlowski@linaro.org>
Subject: Re: [PATCH v8 0/3] virt: vmgenid: add devicetree bindings support
Date: Mon, 22 Apr 2024 15:29:59 +0200 [thread overview]
Message-ID: <ba8e850c-756f-4839-b3d7-db8873f83392@amazon.es> (raw)
In-Reply-To: <20240419224020.780377-1-Jason@zx2c4.com>
On 4/20/24 00:39, Jason A. Donenfeld wrote:
> Changes v7->v8:
> - Remove Kconfig depends statement entirely, instead of ACPI||OF.
> - Check platform_get_irq() return value against < 0 rather than !0.
>
> This is a cleanup of Sudan's OF vmgenid patches, simplified a bit, but
> still with the same intent and mostly unchanged. I'll take this via my
> random tree, but Krzysztof, I would appreciate having your ack/review on
> it.
>
> Sudan - if I've mangled something here, please let me know. I verified
> this still works with ACPI in QEMU, but I don't know about your private
> firecracker OF branch, so please pipe up if something is amiss. It's
> basically the same thing, though, so I suspect it'll be fine.
Hi Jason,
I also verified that this still works with ACPI on Firecracker.
I also verified that the OF part of the patch works with this:
https://github.com/sudanl0/firecracker/commit/f382e09a9b1e4453d2b231232d89bcb85296ac87
patch on top of Firecracker.
Tested-by: Babis Chalios <bchalios@amazon.es>
Cheers,
Babis
next prev parent reply other threads:[~2024-04-22 13:30 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-19 22:39 [PATCH v8 0/3] virt: vmgenid: add devicetree bindings support Jason A. Donenfeld
2024-04-19 22:39 ` [PATCH v8 1/3] virt: vmgenid: change implementation to use a platform driver Jason A. Donenfeld
2024-04-19 22:39 ` [PATCH v8 2/3] dt-bindings: rng: Add vmgenid support Jason A. Donenfeld
2024-04-19 22:40 ` [PATCH v8 3/3] virt: vmgenid: add support for devicetree bindings Jason A. Donenfeld
2024-04-22 13:29 ` Babis Chalios [this message]
2024-04-27 0:41 ` [PATCH v8 0/3] virt: vmgenid: add devicetree bindings support Jason A. Donenfeld
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ba8e850c-756f-4839-b3d7-db8873f83392@amazon.es \
--to=bchalios@amazon.es \
--cc=Jason@zx2c4.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dwmw@amazon.co.uk \
--cc=graf@amazon.com \
--cc=krzk@kernel.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
--cc=sudanl@amazon.com \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).