LKML Archive mirror
 help / color / mirror / Atom feed
From: Martin KaFai Lau <martin.lau@linux.dev>
To: Abhishek Chauhan <quic_abchauha@quicinc.com>
Cc: "David S. Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@google.com>,
	Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
	netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
	Andrew Halaney <ahalaney@redhat.com>,
	Willem de Bruijn <willemdebruijn.kernel@gmail.com>,
	Martin KaFai Lau <martin.lau@kernel.org>,
	Daniel Borkmann <daniel@iogearbox.net>, bpf <bpf@vger.kernel.org>,
	kernel@quicinc.com
Subject: Re: [RFC PATCH bpf-next v5 2/2] net: Add additional bit to support clockid_t timestamp type
Date: Fri, 26 Apr 2024 16:55:57 -0700	[thread overview]
Message-ID: <c20eb574-22f4-49f8-a213-5ff57eb6222e@linux.dev> (raw)
In-Reply-To: <20240424222028.1080134-3-quic_abchauha@quicinc.com>

On 4/24/24 3:20 PM, Abhishek Chauhan wrote:
> diff --git a/net/ipv6/ip6_output.c b/net/ipv6/ip6_output.c
> index a9e819115622..63e4cc30d18d 100644
> --- a/net/ipv6/ip6_output.c
> +++ b/net/ipv6/ip6_output.c
> @@ -955,7 +955,7 @@ int ip6_fragment(struct net *net, struct sock *sk, struct sk_buff *skb,
>   			if (iter.frag)
>   				ip6_fraglist_prepare(skb, &iter);
>   
> -			skb_set_delivery_time(skb, tstamp, tstamp_type);
> +			skb_set_tstamp_type_frm_clkid(skb, tstamp, tstamp_type);
>   			err = output(net, sk, skb);
>   			if (!err)
>   				IP6_INC_STATS(net, ip6_dst_idev(&rt->dst),
> @@ -1016,7 +1016,7 @@ int ip6_fragment(struct net *net, struct sock *sk, struct sk_buff *skb,
>   		/*
>   		 *	Put this fragment into the sending queue.
>   		 */
> -		skb_set_delivery_time(frag, tstamp, tstamp_type);
> +		skb_set_tstamp_type_frm_clkid(frag, tstamp, tstamp_type);
>   		err = output(net, sk, frag);
>   		if (err)
>   			goto fail;

When replying another thread and looking closer at the ip6 changes, these two 
line changes should not be needed.

  parent reply	other threads:[~2024-04-26 23:56 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-04-24 22:20 [RFC PATCH bpf-next v5 0/2] Replace mono_delivery_time with tstamp_type Abhishek Chauhan
2024-04-24 22:20 ` [RFC PATCH bpf-next v5 1/2] net: Rename mono_delivery_time to tstamp_type for scalabilty Abhishek Chauhan
2024-04-25 14:31   ` Willem de Bruijn
2024-04-25 19:02     ` Abhishek Chauhan (ABC)
2024-04-25 23:50       ` Martin KaFai Lau
2024-04-25 23:55         ` Abhishek Chauhan (ABC)
2024-04-24 22:20 ` [RFC PATCH bpf-next v5 2/2] net: Add additional bit to support clockid_t timestamp type Abhishek Chauhan
2024-04-25 14:42   ` Willem de Bruijn
2024-04-25 19:12     ` Abhishek Chauhan (ABC)
2024-04-26  4:37   ` Martin KaFai Lau
2024-04-26 18:46     ` Abhishek Chauhan (ABC)
2024-04-26 23:50       ` Martin KaFai Lau
2024-04-30 19:16         ` Abhishek Chauhan (ABC)
2024-04-30 20:26           ` Willem de Bruijn
2024-04-30 20:40             ` Abhishek Chauhan (ABC)
2024-05-03 21:33     ` Abhishek Chauhan (ABC)
2024-05-03 21:41       ` Martin KaFai Lau
2024-05-03 22:14         ` Abhishek Chauhan (ABC)
2024-04-26 23:55   ` Martin KaFai Lau [this message]
2024-04-30 19:59     ` Abhishek Chauhan (ABC)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c20eb574-22f4-49f8-a213-5ff57eb6222e@linux.dev \
    --to=martin.lau@linux.dev \
    --cc=ahalaney@redhat.com \
    --cc=bpf@vger.kernel.org \
    --cc=daniel@iogearbox.net \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=kernel@quicinc.com \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=martin.lau@kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=quic_abchauha@quicinc.com \
    --cc=willemdebruijn.kernel@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).