From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 23C31EB64D9 for ; Mon, 10 Jul 2023 17:33:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229825AbjGJRd0 (ORCPT ); Mon, 10 Jul 2023 13:33:26 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51536 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229970AbjGJRdW (ORCPT ); Mon, 10 Jul 2023 13:33:22 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9FB5CC7 for ; Mon, 10 Jul 2023 10:33:21 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 3533661169 for ; Mon, 10 Jul 2023 17:33:21 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 86A5BC433C7; Mon, 10 Jul 2023 17:33:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1689010400; bh=LyvZDFM9bSEkcm2a6CqTWE+L7T8svqEvSBQJe6ZM6Ks=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=hPEiIvqYIATEpR1M29zxIhGvfH6efU5aAeHY+ZraMSeSYxX87xqYGYfWTKAoYbUEG +ZcCEPEH/RVya5s6Zj+NROYJ6MsyvSiK18wcdmOYZCyBoqSRSQjKJYPaFvPMsIXHqa tt113ERKhGEtK9g5tDG/g/fUWniHOsVFiFDi7V3wEI9EfcaLHpv4Rt84hizvURCmbw cOsu6JLjcRzKX4nwBu1e4FpN996cjaMUmaggKqf+ss5Fety8jz1R9tHK2PPqJjPFNU xp0GlmOYBxkzlDQS+7MnjdaB7fsVyg3ABjbvjJBUSbVyWFSRS49eIWEqtS0HliOuBy c6hKbt0YYvpQg== Date: Mon, 10 Jul 2023 18:33:07 +0100 From: Mark Brown To: Lorenzo Stoakes Cc: Hugh Dickins , Andrew Morton , Mike Kravetz , Mike Rapoport , "Kirill A. Shutemov" , Matthew Wilcox , David Hildenbrand , Suren Baghdasaryan , Qi Zheng , Yang Shi , Mel Gorman , Peter Xu , Peter Zijlstra , Will Deacon , Yu Zhao , Alistair Popple , Ralph Campbell , Ira Weiny , Steven Price , SeongJae Park , Huang Ying , Naoya Horiguchi , Christophe Leroy , Zack Rusin , Jason Gunthorpe , Axel Rasmussen , Anshuman Khandual , Pasha Tatashin , Miaohe Lin , Minchan Kim , Christoph Hellwig , Song Liu , Thomas Hellstrom , Ryan Roberts , linux-kernel@vger.kernel.org, linux-mm@kvack.org, regressions@leemhuis.info, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v2 12/32] mm/vmalloc: vmalloc_to_page() use pte_offset_kernel() Message-ID: References: <696386a-84f8-b33c-82e5-f865ed6eb39@google.com> <42279f1f-7b82-40dc-8546-86171018729c@sirena.org.uk> <901ae88d-ad0c-4e9d-b199-f1566cc62a00@lucifer.local> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="3eWc9hbXR7DFVsU2" Content-Disposition: inline In-Reply-To: <901ae88d-ad0c-4e9d-b199-f1566cc62a00@lucifer.local> X-Cookie: Do you have lysdexia? Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --3eWc9hbXR7DFVsU2 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Mon, Jul 10, 2023 at 06:18:27PM +0100, Lorenzo Stoakes wrote: > On Mon, Jul 10, 2023 at 03:42:31PM +0100, Mark Brown wrote: > > We end up seeing NULL or otherwise bad pointer dereferences, the > > specific error does vary a bit though it mostly appears to be in the > > pinctrl code. A bisect (full log below) identified this patch as > > introducing the failure, nothing is jumping out at me about the patch > > and it's not affecting everything so I'd not be surprised if it's just > > unconvering some bug in the platform support but I'm not super familiar > > with the code. > Yeah seems likely. Do you have a .config you can share for this board? For > a 64-bit device you'd expect that this change would probably be a nop. It's definitely happening with arm64 defconfig, possibly with other configs but that's the main one. --3eWc9hbXR7DFVsU2 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmSsQNMACgkQJNaLcl1U h9BMswgAgP0XoTGKw3tRPTaAh+qqP2+nQzbiHXKXlruthM53LO0Mp+6YBsb8Br5m s7fAoP+VvNcNiS1CJjVrHryg16txMlFCyfckUtlca8+vdIFQin4cP0WFejtrZMhg WFOupvGC9kU8HoCgXvsdK97QcnkLgZNp6jf4QBgLzuQg+9EnmfbiqvHfkJxgHaPn VOfL9aLVyh0Vw9ttzKfIJ0Fjd1Vlh/uEVBFBh4JBZx9oeZYO0iUhSExyQAKlUJJf gNwdOr7YK19xyEhaYUXJq4XUP0SBj48iHskc7R/eWBuhRwwyoNBnWz/4JwVkU8Ik /Q1yGbPZtVB9NAyMFAo/6kNK4CRRyA== =8zqU -----END PGP SIGNATURE----- --3eWc9hbXR7DFVsU2--