From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 67AD9C7EE2F for ; Fri, 9 Jun 2023 16:00:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S242005AbjFIQAJ (ORCPT ); Fri, 9 Jun 2023 12:00:09 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51002 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S242092AbjFIQAF (ORCPT ); Fri, 9 Jun 2023 12:00:05 -0400 Received: from mail-ej1-x632.google.com (mail-ej1-x632.google.com [IPv6:2a00:1450:4864:20::632]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E02AD95 for ; Fri, 9 Jun 2023 09:00:03 -0700 (PDT) Received: by mail-ej1-x632.google.com with SMTP id a640c23a62f3a-97881a996a0so349358366b.0 for ; Fri, 09 Jun 2023 09:00:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1686326402; x=1688918402; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=JmrAWEdTpAeUeR5jc+sXk5q7UDP7Hqefj8kJ8Wfci+g=; b=EF1aDuVS0spbASUoWKBw3ObmFq+ketWV5bhRQZTs1rDLKXm9bmoPjD4VzhM/i78O3x d9sHnlZamwbhbeZOf6xv7rfURhkIL+cvIh7UyCbQcjydGeYXQcKtF4uYQpy3wvDikKQ8 Clp1zQyBY9IVZhFuZxE57JlY8/I019ajLCsKNQT4Q18pmqxAC3BfmK1WlIAiWbJbIoa7 Qmib7m6g1y2yiz6fkRrQOuALm3KZnoyKgHMS/NPrClXH/xgh/wRAOrfnZ4Utt4KHBPbV E+aOLn0N9SNlP9kTkma2D41KqD12caxw1PoaAPcO9Lu2cFtXKZaxV11Pwox6p7yE8EYA iMtQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686326402; x=1688918402; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=JmrAWEdTpAeUeR5jc+sXk5q7UDP7Hqefj8kJ8Wfci+g=; b=DrzBUPstHsPxW/feOtPr9qMxMSD1lo2VPvdL4DB9cPoQ+COCqOJ4oPd/3GEfMrmNVA ByESCB4HNY8TRFJ/6vVIVAJiF1ASFz2agrGP5dPf8ZBNH92vfzpW0PryokvYLZVto06N Z09iKd0AOBaVzUiFPzS8MZdutD+suJtqCttSfh1aR4yaDPMlLSTxme4+Pr0B608FAme5 jmvZenmxXYsMvyXpsQEdgptWc7kP7KPmx50MqNHfwWp76hd6oOdSozHjeFa8VZsf4Ram ISijpXViJl9sYkFhc5oqIJcs11+f8ANyRgRPhXPzuB9SeckD8hJ1xg8vurwqhMhD1AVF iCWg== X-Gm-Message-State: AC+VfDyDlrOT2rD6VOmGA0PRVQQ8e2zxd9UCCML6ZBPm0TrT4SDxcNSQ ost90fVg9ZOqDo//72AyU28x+w== X-Google-Smtp-Source: ACHHUZ6GwVdCIRU7CfRXzPk7HYiBLG2sXksC6LHRwueZZm3/HF/GmbGsFA2i7pItACSHSVlJmuP9Tw== X-Received: by 2002:a17:907:748:b0:974:5ce6:f9f6 with SMTP id xc8-20020a170907074800b009745ce6f9f6mr2365505ejb.10.1686326402437; Fri, 09 Jun 2023 09:00:02 -0700 (PDT) Received: from [192.168.1.20] ([178.197.219.26]) by smtp.gmail.com with ESMTPSA id i16-20020aa7c9d0000000b0050d83a39e6fsm1940293edt.4.2023.06.09.09.00.00 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 09 Jun 2023 09:00:01 -0700 (PDT) Message-ID: Date: Fri, 9 Jun 2023 17:59:59 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.2 Subject: Re: [PATCH v4 1/2] dt-bindings: HID: i2c-hid: ilitek: Introduce bindings for Ilitek ili9882t Content-Language: en-US To: Doug Anderson Cc: Cong Yang , robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org, dmitry.torokhov@gmail.com, jikos@kernel.org, benjamin.tissoires@redhat.com, hsinyi@google.com, linux-input@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20230608130147.2835818-1-yangcong5@huaqin.corp-partner.google.com> <20230608130147.2835818-2-yangcong5@huaqin.corp-partner.google.com> <77dce4ec-89aa-8802-b169-744f6c11b177@linaro.org> From: Krzysztof Kozlowski In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 09/06/2023 17:56, Doug Anderson wrote: > Hi, > > On Fri, Jun 9, 2023 at 8:50 AM Krzysztof Kozlowski > wrote: >> >>> + vccio-supply: >>> + description: The 1.8V supply to the touchscreen. >>> + >>> +required: >>> + - compatible >>> + - reg >>> + - interrupts >>> + - vccio-supply >>> + >>> +additionalProperties: false >> >> Why do you disallow all properties from toouchscreen.yaml? Aren't they >> applicable? > > This matches what hid-over-i2c.yaml does. It only picks > `touchscreen-inverted-x` and `touchscreen-inverted-y` from the common > file, which aren't needed here. I assume that the rest of the things > from the common file can be probed using the i2c-hid protocol? OK Best regards, Krzysztof