* [PATCH v2 0/2] Staging: panel: Fix checkpatch warnings
@ 2016-01-03 19:27 Ksenija Stanojevic
2016-01-03 19:30 ` [PATCH v2 1/2] Staging: panel: Fix line over 80 characters Ksenija Stanojevic
2016-01-03 19:32 ` [PATCH v2 2/2] Staging: panel: Remove space Ksenija Stanojevic
0 siblings, 2 replies; 3+ messages in thread
From: Ksenija Stanojevic @ 2016-01-03 19:27 UTC (permalink / raw
To: gregkh; +Cc: willy, devel, linux-kernel, Ksenija Stanojevic
Fix checkpatch.pl warnings in panel.c
Signed-off-by: Ksenija Stanojevic <ksenija.stanojevic@gmail.com>
Ksenija Stanojevic (2):
Staging: panel: Fix line over 80 characters
Staging: panel: Remove space
drivers/staging/panel/panel.c | 7 ++++---
1 file changed, 4 insertions(+), 3 deletions(-)
--
1.9.1
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH v2 1/2] Staging: panel: Fix line over 80 characters
2016-01-03 19:27 [PATCH v2 0/2] Staging: panel: Fix checkpatch warnings Ksenija Stanojevic
@ 2016-01-03 19:30 ` Ksenija Stanojevic
2016-01-03 19:32 ` [PATCH v2 2/2] Staging: panel: Remove space Ksenija Stanojevic
1 sibling, 0 replies; 3+ messages in thread
From: Ksenija Stanojevic @ 2016-01-03 19:30 UTC (permalink / raw
To: gregkh; +Cc: willy, devel, linux-kernel, Ksenija Stanojevic
Move statement into line below the comment to follow 80 characters per
line rule.
Found by checkpatch.pl
Signed-off-by: Ksenija Stanojevic <ksenija.stanojevic@gmail.com>
---
Changes in v2:
- don't split comment in multiline
drivers/staging/panel/panel.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/panel/panel.c b/drivers/staging/panel/panel.c
index 79ac192..3525919 100644
--- a/drivers/staging/panel/panel.c
+++ b/drivers/staging/panel/panel.c
@@ -947,7 +947,8 @@ static void lcd_clear_fast_s(void)
lcd_send_serial(0x5F); /* R/W=W, RS=1 */
lcd_send_serial(' ' & 0x0F);
lcd_send_serial((' ' >> 4) & 0x0F);
- usleep_range(40, 100); /* the shortest data takes at least 40 us */
+ /* the shortest data takes at least 40 us */
+ usleep_range(40, 100);
}
spin_unlock_irq(&pprt_lock);
--
1.9.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [PATCH v2 2/2] Staging: panel: Remove space
2016-01-03 19:27 [PATCH v2 0/2] Staging: panel: Fix checkpatch warnings Ksenija Stanojevic
2016-01-03 19:30 ` [PATCH v2 1/2] Staging: panel: Fix line over 80 characters Ksenija Stanojevic
@ 2016-01-03 19:32 ` Ksenija Stanojevic
1 sibling, 0 replies; 3+ messages in thread
From: Ksenija Stanojevic @ 2016-01-03 19:32 UTC (permalink / raw
To: gregkh; +Cc: willy, devel, linux-kernel, Ksenija Stanojevic
No space is necessary after a cast, therefore remove it.
Found by checkpatch.pl
Signed-off-by: Ksenija Stanojevic <ksenija.stanojevic@gmail.com>
---
Changes in v2:
- nothing
drivers/staging/panel/panel.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/panel/panel.c b/drivers/staging/panel/panel.c
index 3525919..04d86f3 100644
--- a/drivers/staging/panel/panel.c
+++ b/drivers/staging/panel/panel.c
@@ -1789,7 +1789,7 @@ static void phys_scan_contacts(void)
gndmask = PNL_PINPUT(r_str(pprt)) & scan_mask_i;
/* grounded inputs are signals 40-44 */
- phys_read |= (pmask_t) gndmask << 40;
+ phys_read |= (pmask_t)gndmask << 40;
if (bitmask != gndmask) {
/*
@@ -1805,7 +1805,7 @@ static void phys_scan_contacts(void)
w_dtr(pprt, oldval & ~bitval); /* enable this output */
bitmask = PNL_PINPUT(r_str(pprt)) & ~gndmask;
- phys_read |= (pmask_t) bitmask << (5 * bit);
+ phys_read |= (pmask_t)bitmask << (5 * bit);
}
w_dtr(pprt, oldval); /* disable all outputs */
}
--
1.9.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-01-03 19:32 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-01-03 19:27 [PATCH v2 0/2] Staging: panel: Fix checkpatch warnings Ksenija Stanojevic
2016-01-03 19:30 ` [PATCH v2 1/2] Staging: panel: Fix line over 80 characters Ksenija Stanojevic
2016-01-03 19:32 ` [PATCH v2 2/2] Staging: panel: Remove space Ksenija Stanojevic
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).