From: Siddharth Vadapalli <s-vadapalli@ti.com>
To: Onkarnath <onkarnath.1@samsung.com>
Cc: Siddharth Vadapalli <s-vadapalli@ti.com>,
"bhelgaas@google.com" <bhelgaas@google.com>,
"vigneshr@ti.com" <vigneshr@ti.com>,
"lpieralisi@kernel.org" <lpieralisi@kernel.org>,
"kw@linux.com" <kw@linux.com>,
"robh@kernel.org" <robh@kernel.org>,
"yue.wang@Amlogic.com" <yue.wang@Amlogic.com>,
"neil.armstrong@linaro.org" <neil.armstrong@linaro.org>,
"khilman@baylibre.com" <khilman@baylibre.com>,
"jbrunet@baylibre.com" <jbrunet@baylibre.com>,
"martin.blumenstingl@googlemail.com"
<martin.blumenstingl@googlemail.com>,
"thomas.petazzoni@bootlin.com" <thomas.petazzoni@bootlin.com>,
"shawn.guo@linaro.org" <shawn.guo@linaro.org>,
"lchuanhua@maxlinear.com" <lchuanhua@maxlinear.com>,
"srikanth.thokala@intel.com" <srikanth.thokala@intel.com>,
"songxiaowei@hisilicon.com" <songxiaowei@hisilicon.com>,
"wangbinghui@hisilicon.com" <wangbinghui@hisilicon.com>,
"manivannan.sadhasivam@linaro.org"
<manivannan.sadhasivam@linaro.org>,
"thierry.reding@gmail.com" <thierry.reding@gmail.com>,
"jonathanh@nvidia.com" <jonathanh@nvidia.com>,
"hayashi.kunihiko@socionext.com" <hayashi.kunihiko@socionext.com>,
"mhiramat@kernel.org" <mhiramat@kernel.org>,
"pali@kernel.org" <pali@kernel.org>,
"toan@os.amperecomputing.com" <toan@os.amperecomputing.com>,
"daire.mcnamara@microchip.com" <daire.mcnamara@microchip.com>,
"conor.dooley@microchip.com" <conor.dooley@microchip.com>,
"marek.vasut+renesas@gmail.com" <marek.vasut+renesas@gmail.com>,
"shawn.lin@rock-chips.com" <shawn.lin@rock-chips.com>,
"heiko@sntech.de" <heiko@sntech.de>,
"nirmal.patel@linux.intel.com" <nirmal.patel@linux.intel.com>,
"jonathan.derrick@linux.dev" <jonathan.derrick@linux.dev>,
"kishon@kernel.org" <kishon@kernel.org>,
"jdmason@kudzu.us" <jdmason@kudzu.us>,
"dave.jiang@intel.com" <dave.jiang@intel.com>,
"rafael@kernel.org" <rafael@kernel.org>,
"lenb@kernel.org" <lenb@kernel.org>,
"mahesh@linux.ibm.com" <mahesh@linux.ibm.com>,
"oohall@gmail.com" <oohall@gmail.com>,
"linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-amlogic@lists.infradead.org"
<linux-amlogic@lists.infradead.org>,
"linux-arm-msm@vger.kernel.org" <linux-arm-msm@vger.kernel.org>,
"linux-tegra@vger.kernel.org" <linux-tegra@vger.kernel.org>,
Rohit Thapliyal <r.thapliyal@samsung.com>,
Maninder Singh <maninder1.s@samsung.com>
Subject: Re: [PATCH 1/1] PCI : Refactoring error log prints for better readability
Date: Mon, 20 May 2024 16:46:34 +0530 [thread overview]
Message-ID: <e0e28988-9699-4e6c-abb0-30fa2727c2c3@ti.com> (raw)
In-Reply-To: <20240520104358epcms5p50e00970ef70f66e87ceaaa893fc0ba67@epcms5p5>
On Mon, May 20, 2024 at 04:13:58PM +0530, Onkarnath wrote:
> Hi,
>
>
[...]
>
> >>Similar question as above regarding converting "failed, ret" to
>
> >>"failed:". Is this a new convention that is expected to be followed,
>
> >where all errors are supposed to have "failed: %pe", rather than custom
>
> >statements? Please let me know if this has already been discussed
>
> >elsewhere.
>
>
> Bjorn suggested to make all errors consistent.
>
> and I thought printing error like below:
>
>
> "gpio request failed: -ENOMEM".
>
>
> Seems more suitable than
>
>
> "gpio request failed, ret (-ENOMEM)".
>
>
> If it needs to be changed in other format, please let me know, i will make all
> errors in that format.
>
> and will share v2.
Thank you for clarifying. It appeared to me that the suggestion was
limited to the %d to %pe conversion. The existing implementation looks
good in that case.
Regards,
Siddharth.
prev parent reply other threads:[~2024-05-20 11:17 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20240517105941epcas5p3e8dbb97f19c9553bf9942ad146124806@epcas5p3.samsung.com>
2024-05-17 10:59 ` [PATCH 1/1] PCI : Refactoring error log prints for better readability Onkarnarth
2024-05-17 11:20 ` Siddharth Vadapalli
[not found] ` <CGME20240517105941epcas5p3e8dbb97f19c9553bf9942ad146124806@epcms5p5>
[not found] ` <20240520104358epcms5p50e00970ef70f66e87ceaaa893fc0ba67@epcms5p5>
2024-05-20 11:16 ` Siddharth Vadapalli [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e0e28988-9699-4e6c-abb0-30fa2727c2c3@ti.com \
--to=s-vadapalli@ti.com \
--cc=bhelgaas@google.com \
--cc=conor.dooley@microchip.com \
--cc=daire.mcnamara@microchip.com \
--cc=dave.jiang@intel.com \
--cc=hayashi.kunihiko@socionext.com \
--cc=heiko@sntech.de \
--cc=jbrunet@baylibre.com \
--cc=jdmason@kudzu.us \
--cc=jonathan.derrick@linux.dev \
--cc=jonathanh@nvidia.com \
--cc=khilman@baylibre.com \
--cc=kishon@kernel.org \
--cc=kw@linux.com \
--cc=lchuanhua@maxlinear.com \
--cc=lenb@kernel.org \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=lpieralisi@kernel.org \
--cc=mahesh@linux.ibm.com \
--cc=maninder1.s@samsung.com \
--cc=manivannan.sadhasivam@linaro.org \
--cc=marek.vasut+renesas@gmail.com \
--cc=martin.blumenstingl@googlemail.com \
--cc=mhiramat@kernel.org \
--cc=neil.armstrong@linaro.org \
--cc=nirmal.patel@linux.intel.com \
--cc=onkarnath.1@samsung.com \
--cc=oohall@gmail.com \
--cc=pali@kernel.org \
--cc=r.thapliyal@samsung.com \
--cc=rafael@kernel.org \
--cc=robh@kernel.org \
--cc=shawn.guo@linaro.org \
--cc=shawn.lin@rock-chips.com \
--cc=songxiaowei@hisilicon.com \
--cc=srikanth.thokala@intel.com \
--cc=thierry.reding@gmail.com \
--cc=thomas.petazzoni@bootlin.com \
--cc=toan@os.amperecomputing.com \
--cc=vigneshr@ti.com \
--cc=wangbinghui@hisilicon.com \
--cc=yue.wang@Amlogic.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).