From: Can Guo <cang@codeaurora.org>
To: Avri Altman <avri.altman@wdc.com>
Cc: "James E . J . Bottomley" <jejb@linux.vnet.ibm.com>,
"Martin K . Petersen" <martin.petersen@oracle.com>,
linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org,
gregkh@linuxfoundation.org, Bart Van Assche <bvanassche@acm.org>,
yongmyung lee <ymhungry.lee@samsung.com>,
Daejun Park <daejun7.park@samsung.com>,
alim.akhtar@samsung.com, asutoshd@codeaurora.org,
Zang Leigang <zangleigang@hisilicon.com>,
Avi Shchislowski <avi.shchislowski@wdc.com>,
Bean Huo <beanhuo@micron.com>,
stanley.chu@mediatek.com
Subject: Re: [PATCH v7 06/11] scsi: ufshpb: Region inactivation in host mode
Date: Tue, 06 Apr 2021 12:53:29 +0800 [thread overview]
Message-ID: <e29e33769f23036f936a6b60c7430387@codeaurora.org> (raw)
In-Reply-To: <20210331073952.102162-7-avri.altman@wdc.com>
On 2021-03-31 15:39, Avri Altman wrote:
> In host mode, the host is expected to send HPB-WRITE-BUFFER with
> buffer-id = 0x1 when it inactivates a region.
>
> Use the map-requests pool as there is no point in assigning a
> designated cache for umap-requests.
>
> Signed-off-by: Avri Altman <avri.altman@wdc.com>
> ---
> drivers/scsi/ufs/ufshpb.c | 35 +++++++++++++++++++++++++++++++----
> drivers/scsi/ufs/ufshpb.h | 1 +
> 2 files changed, 32 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/scsi/ufs/ufshpb.c b/drivers/scsi/ufs/ufshpb.c
> index aefb6dc160ee..fcc954f51bcf 100644
> --- a/drivers/scsi/ufs/ufshpb.c
> +++ b/drivers/scsi/ufs/ufshpb.c
> @@ -914,6 +914,7 @@ static int ufshpb_execute_umap_req(struct ufshpb_lu
> *hpb,
>
> blk_execute_rq_nowait(NULL, req, 1, ufshpb_umap_req_compl_fn);
>
> + hpb->stats.umap_req_cnt++;
> return 0;
> }
>
> @@ -1110,18 +1111,37 @@ static int ufshpb_issue_umap_req(struct
> ufshpb_lu *hpb,
> return -EAGAIN;
> }
>
> +static int ufshpb_issue_umap_single_req(struct ufshpb_lu *hpb,
> + struct ufshpb_region *rgn)
> +{
> + return ufshpb_issue_umap_req(hpb, rgn);
> +}
> +
> static int ufshpb_issue_umap_all_req(struct ufshpb_lu *hpb)
> {
> return ufshpb_issue_umap_req(hpb, NULL);
> }
>
> -static void __ufshpb_evict_region(struct ufshpb_lu *hpb,
> - struct ufshpb_region *rgn)
> +static int __ufshpb_evict_region(struct ufshpb_lu *hpb,
> + struct ufshpb_region *rgn)
> {
> struct victim_select_info *lru_info;
> struct ufshpb_subregion *srgn;
> int srgn_idx;
>
> + lockdep_assert_held(&hpb->rgn_state_lock);
> +
> + if (hpb->is_hcm) {
> + unsigned long flags;
> + int ret;
> +
> + spin_unlock_irqrestore(&hpb->rgn_state_lock, flags);
Never seen a usage like this... Here flags is used without being
intialized.
The flag is needed when spin_unlock_irqrestore ->
local_irq_restore(flags) to
restore the DAIF register (in terms of ARM).
Thanks,
Can Guo.
> + ret = ufshpb_issue_umap_single_req(hpb, rgn);
> + spin_lock_irqsave(&hpb->rgn_state_lock, flags);
> + if (ret)
> + return ret;
> + }
> +
> lru_info = &hpb->lru_info;
>
> dev_dbg(&hpb->sdev_ufs_lu->sdev_dev, "evict region %d\n",
> rgn->rgn_idx);
> @@ -1130,6 +1150,8 @@ static void __ufshpb_evict_region(struct
> ufshpb_lu *hpb,
>
> for_each_sub_region(rgn, srgn_idx, srgn)
> ufshpb_purge_active_subregion(hpb, srgn);
> +
> + return 0;
> }
>
> static int ufshpb_evict_region(struct ufshpb_lu *hpb, struct
> ufshpb_region *rgn)
> @@ -1151,7 +1173,7 @@ static int ufshpb_evict_region(struct ufshpb_lu
> *hpb, struct ufshpb_region *rgn)
> goto out;
> }
>
> - __ufshpb_evict_region(hpb, rgn);
> + ret = __ufshpb_evict_region(hpb, rgn);
> }
> out:
> spin_unlock_irqrestore(&hpb->rgn_state_lock, flags);
> @@ -1285,7 +1307,9 @@ static int ufshpb_add_region(struct ufshpb_lu
> *hpb, struct ufshpb_region *rgn)
> "LRU full (%d), choose victim %d\n",
> atomic_read(&lru_info->active_cnt),
> victim_rgn->rgn_idx);
> - __ufshpb_evict_region(hpb, victim_rgn);
> + ret = __ufshpb_evict_region(hpb, victim_rgn);
> + if (ret)
> + goto out;
> }
>
> /*
> @@ -1856,6 +1880,7 @@ ufshpb_sysfs_attr_show_func(rb_noti_cnt);
> ufshpb_sysfs_attr_show_func(rb_active_cnt);
> ufshpb_sysfs_attr_show_func(rb_inactive_cnt);
> ufshpb_sysfs_attr_show_func(map_req_cnt);
> +ufshpb_sysfs_attr_show_func(umap_req_cnt);
>
> static struct attribute *hpb_dev_stat_attrs[] = {
> &dev_attr_hit_cnt.attr,
> @@ -1864,6 +1889,7 @@ static struct attribute *hpb_dev_stat_attrs[] = {
> &dev_attr_rb_active_cnt.attr,
> &dev_attr_rb_inactive_cnt.attr,
> &dev_attr_map_req_cnt.attr,
> + &dev_attr_umap_req_cnt.attr,
> NULL,
> };
>
> @@ -1988,6 +2014,7 @@ static void ufshpb_stat_init(struct ufshpb_lu
> *hpb)
> hpb->stats.rb_active_cnt = 0;
> hpb->stats.rb_inactive_cnt = 0;
> hpb->stats.map_req_cnt = 0;
> + hpb->stats.umap_req_cnt = 0;
> }
>
> static void ufshpb_param_init(struct ufshpb_lu *hpb)
> diff --git a/drivers/scsi/ufs/ufshpb.h b/drivers/scsi/ufs/ufshpb.h
> index 87495e59fcf1..1ea58c17a4de 100644
> --- a/drivers/scsi/ufs/ufshpb.h
> +++ b/drivers/scsi/ufs/ufshpb.h
> @@ -191,6 +191,7 @@ struct ufshpb_stats {
> u64 rb_inactive_cnt;
> u64 map_req_cnt;
> u64 pre_req_cnt;
> + u64 umap_req_cnt;
> };
>
> struct ufshpb_lu {
next prev parent reply other threads:[~2021-04-06 4:53 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-31 7:39 [PATCH v7 00/11] Add Host control mode to HPB Avri Altman
2021-03-31 7:39 ` [PATCH v7 01/11] scsi: ufshpb: Cache HPB Control mode on init Avri Altman
2021-03-31 7:39 ` [PATCH v7 02/11] scsi: ufshpb: Add host control mode support to rsp_upiu Avri Altman
2021-03-31 7:39 ` [PATCH v7 03/11] scsi: ufshpb: Transform set_dirty to iterate_rgn Avri Altman
2021-03-31 7:39 ` [PATCH v7 04/11] scsi: ufshpb: Add reads counter Avri Altman
2021-03-31 7:39 ` [PATCH v7 05/11] scsi: ufshpb: Make eviction depends on region's reads Avri Altman
2021-03-31 7:39 ` [PATCH v7 06/11] scsi: ufshpb: Region inactivation in host mode Avri Altman
2021-04-06 4:53 ` Can Guo [this message]
2021-04-06 5:20 ` Avri Altman
2021-04-06 6:00 ` Can Guo
2021-04-06 6:16 ` Avri Altman
2021-04-06 6:26 ` Can Guo
2021-04-06 7:16 ` Avri Altman
2021-04-10 1:09 ` Avri Altman
2021-03-31 7:39 ` [PATCH v7 07/11] scsi: ufshpb: Add hpb dev reset response Avri Altman
2021-03-31 7:39 ` [PATCH v7 08/11] scsi: ufshpb: Add "Cold" regions timer Avri Altman
2021-03-31 7:39 ` [PATCH v7 09/11] scsi: ufshpb: Limit the number of inflight map requests Avri Altman
2021-03-31 7:39 ` [PATCH v7 10/11] scsi: ufshpb: Add support for host control mode Avri Altman
2021-03-31 7:39 ` [PATCH v7 11/11] scsi: ufshpb: Make host mode parameters configurable Avri Altman
[not found] ` <CGME20210331074004epcas2p3e6d0b2d1bf0f43708902b2d5583069c4@epcms2p6>
2021-04-05 9:29 ` [PATCH v7 00/11] Add Host control mode to HPB Daejun Park
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e29e33769f23036f936a6b60c7430387@codeaurora.org \
--to=cang@codeaurora.org \
--cc=alim.akhtar@samsung.com \
--cc=asutoshd@codeaurora.org \
--cc=avi.shchislowski@wdc.com \
--cc=avri.altman@wdc.com \
--cc=beanhuo@micron.com \
--cc=bvanassche@acm.org \
--cc=daejun7.park@samsung.com \
--cc=gregkh@linuxfoundation.org \
--cc=jejb@linux.vnet.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=stanley.chu@mediatek.com \
--cc=ymhungry.lee@samsung.com \
--cc=zangleigang@hisilicon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).