From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 08C28C7EE37 for ; Tue, 6 Jun 2023 13:38:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236809AbjFFNik (ORCPT ); Tue, 6 Jun 2023 09:38:40 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58538 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236403AbjFFNid (ORCPT ); Tue, 6 Jun 2023 09:38:33 -0400 Received: from mail-wr1-x436.google.com (mail-wr1-x436.google.com [IPv6:2a00:1450:4864:20::436]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7681710C0 for ; Tue, 6 Jun 2023 06:38:31 -0700 (PDT) Received: by mail-wr1-x436.google.com with SMTP id ffacd0b85a97d-30e53cacc10so171850f8f.0 for ; Tue, 06 Jun 2023 06:38:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1686058710; x=1688650710; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=85EFiLI503ORP5JesjlHbOh64K/GjvzvL/eTRP3rkhQ=; b=fOsE1JpsNSV4Xsjr/6+EEdOeMhcOq7zLmJabYRzqIsqIc+SL6Gk9bQ+6bKvymplh5Q FhjITFvmNcueBHvslgiBV5ibyGLwLOzgBOULPc+4CXI9BmDagMTcKfSyWhGpJO/iMbiE NJ2ob/WCmiHiA/pYEdmuG/xKKU7EmSBRyaOuVNr0vl+lGjEFDL1d/9UT/E2g5iUhRhk9 9yepA3t76U0HuQJ/xUmtFMw3L+lkHk8DCesnJoofYTE3aOagXypmWF6wedDPapMu4Pkg tGR/yp8uXHJmQBV/a27yYFXRP1V9YtH2wlhfBanDvQvWl7Qf5vqR6+xK7dC/89qo7S0H qRaw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686058710; x=1688650710; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=85EFiLI503ORP5JesjlHbOh64K/GjvzvL/eTRP3rkhQ=; b=D4GZ4eRRLC2Ol0YZRXylwSV6eAiOiGE8wshXpt36FFHfp6xIkZZQ6xiWoJ90U7dos/ Dcb0w2aMIhs0j5n5Kzova0ZFNI+xvdYzGhoBquOmOLwD3GK3roXKNty0cTUYajMKl7no 2dTMZpsbXAsOS3RmhTf4e9M0gL4QwXfgdeux6bniBA7t5S7nwVOVqYbG04dhoPL6RlDV kqPViZzg4oJ8XgxoDnuw36W6i3pABqAYGMtjU6bTwg2pP7AdHEvWftb5OFOWxJRT/1Vd e7Bv9e8T4D7hc2kuc+EA7wGBwyrhS77vrTfvv+vYdi/iE/VWrJtfW2cV9LqJEcmuBkcB auEw== X-Gm-Message-State: AC+VfDxAUQPTQNfZMAHPJtZl/DAfWK8aU32hYobwye85CZ5wgRST3L3o QddklTtApptxU+cTGKQH//nByA== X-Google-Smtp-Source: ACHHUZ4AMsKpUttX2fYo2DbgD1pFk1gewZgB0HIuULY5Ayuj9wHoMlOSB/ECcbPpKgJ8R9mQgHbpTQ== X-Received: by 2002:adf:ea0a:0:b0:30e:52de:9ccf with SMTP id q10-20020adfea0a000000b0030e52de9ccfmr788222wrm.68.1686058709896; Tue, 06 Jun 2023 06:38:29 -0700 (PDT) Received: from localhost ([102.36.222.112]) by smtp.gmail.com with ESMTPSA id v10-20020a1cf70a000000b003f41bb52834sm17664547wmh.38.2023.06.06.06.38.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 06 Jun 2023 06:38:28 -0700 (PDT) Date: Tue, 6 Jun 2023 16:38:25 +0300 From: Dan Carpenter To: Bagas Sanjaya Cc: Franziska Naepelt , keyrings@vger.kernel.org, dhowells@redhat.com, dwmw2@infradead.org, linux-kernel@vger.kernel.org, Franziska Naepelt , kernel test robot , Linux SPDX Licenses , Linux Kernel Janitors Subject: Re: [PATCH v2] certs/extract-cert: Fix checkpatch issues Message-ID: References: <20230601190508.56610-1-franziska.naepelt@gmail.com> <20230602085902.59006-1-franziska.naepelt@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jun 06, 2023 at 07:28:52PM +0700, Bagas Sanjaya wrote: > On Fri, Jun 02, 2023 at 10:59:02AM +0200, Franziska Naepelt wrote: > > The following issues are fixed: > > - WARNING: Missing or malformed SPDX-License-Identifier tag > > - ERROR: trailing statements should be on next line > > - WARNING: braces {} are not necessary for single statement blocks > > - ERROR: space required before the open parenthesis '(' > > - ERROR: code indent should use tabs where possible > > - WARNING: please, no spaces at the start of a line > > - WARNING: Missing a blank line after declarations > > Again, write the patch description in imperative mood (e.g. "Do foo"). > Why do you care about imperative tense? Imperative tense doesn't matter. What matters is that you can understand the issue and how it looks like to the user. I was working with a group of foreign students and it was painful to see the contortions that they went through to make a commit message imperative. It's like saying "Bake a cake", "Ok, now bake it while juggling." The cake ends up worse. And the commit message end up worse when we force nonsense rules like this. That said the rest of your comments are correct. Franziska, I kind of feel like you should start in drivers/staging/ because you're sending beginner patches to kind of core parts of the kernel where people are busy. Most likely your going to have to send a bunch of iterations of the patch. In drivers/staging/ we don't mind reviewing newbie patches. regards, dan carpenter