From: Michael Riesch <michael.riesch@wolfvision.net>
To: "Heiko Stübner" <heiko@sntech.de>,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org
Cc: Rob Herring <robh+dt@kernel.org>, Liang Chen <cl@rock-chips.com>,
Peter Geis <pgwipeout@gmail.com>,
Sascha Hauer <s.hauer@pengutronix.de>,
Simon Xue <xxm@rock-chips.com>
Subject: Re: [PATCH 5/5] arm64: dts: rockchip: rk3568-evb1-v10: add node for sd card
Date: Wed, 4 Aug 2021 12:03:25 +0200 [thread overview]
Message-ID: <ebddd74f-114f-1da4-8702-387338002551@wolfvision.net> (raw)
In-Reply-To: <2936848.7s5MMGUR32@diego>
Hi Heiko,
On 8/3/21 10:48 PM, Heiko Stübner wrote:
> Am Dienstag, 3. August 2021, 20:53:09 CEST schrieb Michael Riesch:
>> Signed-off-by: Michael Riesch <michael.riesch@wolfvision.net>
>> ---
>> arch/arm64/boot/dts/rockchip/rk3568-evb1-v10.dts | 15 +++++++++++++++
>> 1 file changed, 15 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/rockchip/rk3568-evb1-v10.dts b/arch/arm64/boot/dts/rockchip/rk3568-evb1-v10.dts
>> index 3ac70a8183c4..b0f5aa8c979c 100644
>> --- a/arch/arm64/boot/dts/rockchip/rk3568-evb1-v10.dts
>> +++ b/arch/arm64/boot/dts/rockchip/rk3568-evb1-v10.dts
>> @@ -17,6 +17,7 @@
>> ethernet0 = &gmac0;
>> ethernet1 = &gmac1;
>> emmc = &sdhci;
>> + sd = &sdmmc0;
>
> same thing as in the previous patch.
>
> I guess you may want something like
>
> mmc0 = &sdhci;
> mmc1 = &sdmmc0;
>
> maybe?
Thanks for the suggestion, I'll include it in the v2.
Regards, Michael
>
>
> Heiko
>
>> };
>>
>> chosen: chosen {
>> @@ -353,6 +354,20 @@
>> status = "okay";
>> };
>>
>> +&sdmmc0 {
>> + bus-width = <4>;
>> + cap-sd-highspeed;
>> + cd-gpios = <&gpio0 RK_PA4 GPIO_ACTIVE_LOW>;
>> + disable-wp;
>> + pinctrl-names = "default";
>> + pinctrl-0 = <&sdmmc0_bus4 &sdmmc0_clk &sdmmc0_cmd &sdmmc0_det>;
>> + sd-uhs-sdr104;
>> + supports-sd;
>> + vmmc-supply = <&vcc3v3_sd>;
>> + vqmmc-supply = <&vccio_sd>;
>> + status = "okay";
>> +};
>> +
>> &uart2 {
>> status = "okay";
>> };
>>
>
>
>
>
prev parent reply other threads:[~2021-08-04 10:03 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-03 18:53 [PATCH 0/5] arm64: dts: rockchip: rk3568-evb1-v10: add sd card support Michael Riesch
2021-08-03 18:53 ` [PATCH 1/5] arm64: dts: rockchip: rk3568-evb1-v10: add regulators of rk809 pmic Michael Riesch
2021-08-03 18:53 ` [PATCH 2/5] arm64: dts: rockchip: enable io domains for rk356x Michael Riesch
2021-08-03 18:53 ` [PATCH 3/5] arm64: dts: rockchip: rk3568-evb1-v10: enable io domains Michael Riesch
2021-08-03 18:53 ` [PATCH 4/5] arm64: dts: rockchip: rk3568-evb1-v10: add pinctrl and alias to emmc node Michael Riesch
2021-08-03 20:47 ` Heiko Stübner
2021-08-03 18:53 ` [PATCH 5/5] arm64: dts: rockchip: rk3568-evb1-v10: add node for sd card Michael Riesch
2021-08-03 20:48 ` Heiko Stübner
2021-08-04 10:03 ` Michael Riesch [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ebddd74f-114f-1da4-8702-387338002551@wolfvision.net \
--to=michael.riesch@wolfvision.net \
--cc=cl@rock-chips.com \
--cc=devicetree@vger.kernel.org \
--cc=heiko@sntech.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=pgwipeout@gmail.com \
--cc=robh+dt@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=xxm@rock-chips.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).