From: Andy Yan <andy.yan@rock-chips.com>
To: Maxime Ripard <mripard@kernel.org>
Cc: "Maarten Lankhorst" <maarten.lankhorst@linux.intel.com>,
"Thomas Zimmermann" <tzimmermann@suse.de>,
"David Airlie" <airlied@gmail.com>,
"Daniel Vetter" <daniel@ffwll.ch>,
"Jonathan Corbet" <corbet@lwn.net>,
"Sandy Huang" <hjc@rock-chips.com>,
"Heiko Stübner" <heiko@sntech.de>, "Chen-Yu Tsai" <wens@csie.org>,
"Jernej Skrabec" <jernej.skrabec@gmail.com>,
"Samuel Holland" <samuel@sholland.org>,
"Hans Verkuil" <hverkuil@xs4all.nl>,
"Sebastian Wick" <sebastian.wick@redhat.com>,
"Ville Syrjälä" <ville.syrjala@linux.intel.com>,
dri-devel@lists.freedesktop.org,
linux-arm-kernel@lists.infradead.org, linux-doc@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-media@vger.kernel.org,
linux-rockchip@lists.infradead.org, linux-sunxi@lists.linux.dev
Subject: Re: [PATCH v12 27/28] drm/rockchip: inno_hdmi: Switch to HDMI connector
Date: Mon, 6 May 2024 16:22:46 +0800 [thread overview]
Message-ID: <ed035e25-dd9e-4041-b413-7511544d0aba@rock-chips.com> (raw)
In-Reply-To: <20240506-eccentric-wren-of-peace-819aad@houat>
Hi Maxime,
On 5/6/24 15:59, Maxime Ripard wrote:
> Hi Andy,
>
> Thanks a lot for giving it a try
>
> All the issues you raised in your review are fixed.
>
> On Sat, Apr 27, 2024 at 06:44:54PM GMT, Andy Yan wrote:
>> And after this whole series applied on linux 6.9-rc4, the display on rk3036 kylin is lost, I get
>> the following error:
>> [ 178.999421] rockchip-drm display-subsystem: [drm:drm_atomic_check_only] checking 87b7fbde
>> [ 178.999471] rockchip-drm display-subsystem: [drm:drm_atomic_helper_check_modeset] [CRTC:35:crtc-0] mode changed
>> [ 178.999498] rockchip-drm display-subsystem: [drm:drm_atomic_helper_check_modeset] [CRTC:35:crtc-0] enable changed
>> [ 178.999521] rockchip-drm display-subsystem: [drm:drm_atomic_helper_check_modeset] [CRTC:35:crtc-0] active changed
>> [ 178.999547] rockchip-drm display-subsystem: [drm:drm_atomic_helper_check_modeset] Updating routing for [CONNECTOR:37:HDMI-A-1]
>> [ 178.999575] rockchip-drm display-subsystem: [drm:drm_atomic_helper_check_modeset] [CONNECTOR:37:HDMI-A-1] using [ENCODER:36:TMDS-36] on [CRTC:35:crtc-0]
>> [ 178.999604] rockchip-drm display-subsystem: [drm:drm_atomic_helper_connector_hdmi_check] Trying with a 8 bpc output
>> [ 178.999636] rockchip-drm display-subsystem: [drm:drm_atomic_helper_connector_hdmi_check] Trying RGB output format
>> [ 178.999730] rockchip-drm display-subsystem: [drm:drm_atomic_helper_connector_hdmi_check] RGB Format, checking the constraints.
>> [ 178.999757] rockchip-drm display-subsystem: [drm:drm_atomic_helper_connector_hdmi_check] RGB output format not supported with 8 bpc
>> [ 178.999783] rockchip-drm display-subsystem: [drm:drm_atomic_helper_connector_hdmi_check] Failed. No Format Supported for that bpc count.
>> [ 178.999810] rockchip-drm display-subsystem: [drm:drm_atomic_helper_check_modeset] [CONNECTOR:37:HDMI-A-1] driver check failed
>> [ 178.999836] rockchip-drm display-subsystem: [drm:drm_atomic_check_only] atomic driver check for 87b7fbde failed: -22
>> [ 178.999868] rockchip-drm display-subsystem: [drm:drm_atomic_state_default_clear] Clearing atomic state 87b7fbde
>> [ 178.999898] [drm:drm_mode_object_put] OBJ ID: 37 (4)
>> [ 178.999922] [drm:drm_mode_object_put] OBJ ID: 37 (3)
>> [ 178.999944] [drm:drm_mode_object_put] OBJ ID: 40 (1)
>> [ 178.999971] [drm:drm_mode_object_put] OBJ ID: 39 (2)
>
> Which kind of display are you testing with? The only reason it could do
> so is if the display claim it doesn't support RGB in its EDID which is
> contradicting the HDMI spec. Are you using an Analog display by any
> chance? or the built-in EDIDs through the drm.edid_firmware mechanism?
It is because there is something wrong(I still don't know why) with the DDC on my board.
It always failed to read edid when it first bootup, that means inno_hdmi_connector_get_modes
will return 0.
and in function
drm_helper_probe_single_connector_modes:
count = drm_helper_probe_get_modes(connector);
if (count == 0 && (connector->status == connector_status_connected ||
connector->status == connector_status_unknown)) {
count = drm_add_modes_noedid(connector, 1024, 768);
/*
* Section 4.2.2.6 (EDID Corruption Detection) of the DP 1.4a
* Link CTS specifies that 640x480 (the official "failsafe"
* mode) needs to be the default if there's no EDID.
*/
if (connector->connector_type == DRM_MODE_CONNECTOR_DisplayPort)
drm_set_preferred_mode(connector, 640, 480);
}
drm_add_modes_noedid will not initialize display_info.
>
> Maxime
next prev parent reply other threads:[~2024-05-06 14:20 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-23 10:45 [PATCH v12 00/28] drm/connector: Create HDMI Connector infrastructure Maxime Ripard
2024-04-23 10:45 ` [PATCH v12 01/28] drm/connector: Introduce an HDMI connector initialization function Maxime Ripard
2024-04-23 10:45 ` [PATCH v12 02/28] drm/mode_object: Export drm_mode_obj_find_prop_id for tests Maxime Ripard
2024-04-23 10:45 ` [PATCH v12 03/28] drm/tests: connector: Add tests for drmm_connector_hdmi_init Maxime Ripard
2024-04-23 10:45 ` [PATCH v12 04/28] drm/connector: hdmi: Create an HDMI sub-state Maxime Ripard
2024-04-23 10:45 ` [PATCH v12 05/28] drm/connector: hdmi: Add output BPC to the connector state Maxime Ripard
2024-04-23 10:45 ` [PATCH v12 06/28] drm/tests: Add output bpc tests Maxime Ripard
2024-04-23 10:45 ` [PATCH v12 07/28] drm/connector: hdmi: Add support for output format Maxime Ripard
2024-04-23 10:45 ` [PATCH v12 08/28] drm/tests: Add output formats tests Maxime Ripard
2024-04-23 10:45 ` [PATCH v12 09/28] drm/display: hdmi: Add HDMI compute clock helper Maxime Ripard
2024-04-23 10:45 ` [PATCH v12 10/28] drm/tests: Add HDMI TDMS character rate tests Maxime Ripard
2024-04-23 10:45 ` [PATCH v12 11/28] drm/connector: hdmi: Calculate TMDS character rate Maxime Ripard
2024-04-23 10:45 ` [PATCH v12 12/28] drm/tests: Add TDMS character rate connector state tests Maxime Ripard
2024-04-23 10:45 ` [PATCH v12 13/28] drm/connector: hdmi: Add custom hook to filter TMDS character rate Maxime Ripard
2024-04-23 10:45 ` [PATCH v12 14/28] drm/tests: Add HDMI connector rate filter hook tests Maxime Ripard
2024-04-23 10:45 ` [PATCH v12 15/28] drm/connector: hdmi: Compute bpc and format automatically Maxime Ripard
2024-04-23 10:45 ` [PATCH v12 16/28] drm/tests: Add HDMI connector bpc and format tests Maxime Ripard
2024-04-23 10:45 ` [PATCH v12 17/28] drm/connector: hdmi: Add Broadcast RGB property Maxime Ripard
2024-04-23 10:45 ` [PATCH v12 18/28] drm/tests: Add tests for " Maxime Ripard
2024-04-23 10:45 ` [PATCH v12 19/28] drm/connector: hdmi: Add RGB Quantization Range to the connector state Maxime Ripard
2024-04-23 10:45 ` [PATCH v12 20/28] drm/tests: Add RGB Quantization tests Maxime Ripard
2024-04-23 10:45 ` [PATCH v12 21/28] drm/connector: hdmi: Add Infoframes generation Maxime Ripard
2024-04-23 10:45 ` [PATCH v12 22/28] drm/tests: Add infoframes test Maxime Ripard
2024-04-23 10:45 ` [PATCH v12 23/28] drm/connector: hdmi: Create Infoframe DebugFS entries Maxime Ripard
2024-04-23 10:45 ` [PATCH v12 24/28] drm/vc4: hdmi: Switch to HDMI connector Maxime Ripard
2024-04-23 10:45 ` [PATCH v12 25/28] drm/vc4: tests: Remove vc4_dummy_plane structure Maxime Ripard
2024-04-23 10:45 ` [PATCH v12 26/28] drm/vc4: tests: Convert to plane creation helper Maxime Ripard
2024-04-23 10:45 ` [PATCH v12 27/28] drm/rockchip: inno_hdmi: Switch to HDMI connector Maxime Ripard
2024-04-27 10:12 ` Andy Yan
2024-05-06 7:49 ` Maxime Ripard
2024-04-27 10:44 ` Andy Yan
2024-05-06 7:59 ` Maxime Ripard
2024-05-06 8:22 ` Andy Yan [this message]
2024-05-07 1:32 ` Andy Yan
2024-04-23 10:45 ` [PATCH v12 28/28] drm/sun4i: hdmi: " Maxime Ripard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ed035e25-dd9e-4041-b413-7511544d0aba@rock-chips.com \
--to=andy.yan@rock-chips.com \
--cc=airlied@gmail.com \
--cc=corbet@lwn.net \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=heiko@sntech.de \
--cc=hjc@rock-chips.com \
--cc=hverkuil@xs4all.nl \
--cc=jernej.skrabec@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=linux-sunxi@lists.linux.dev \
--cc=maarten.lankhorst@linux.intel.com \
--cc=mripard@kernel.org \
--cc=samuel@sholland.org \
--cc=sebastian.wick@redhat.com \
--cc=tzimmermann@suse.de \
--cc=ville.syrjala@linux.intel.com \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).