* [PATCH v2] tracing/tools: Remove unneeded semicolon
@ 2021-03-08 2:24 Xu Wang
2021-03-08 11:40 ` Viktor.Rosendahl
0 siblings, 1 reply; 2+ messages in thread
From: Xu Wang @ 2021-03-08 2:24 UTC (permalink / raw
To: rostedt, Viktor.Rosendahl, colin.king; +Cc: linux-kernel
fix semicolon.cocci warning:
tools/tracing/latency/latency-collector.c:1021:2-3: Unneeded semicolon
Signed-off-by: Xu Wang <vulab@iscas.ac.cn>
---
Changes since v2:
- Fix another instance of superfluous semicolon.
---
tools/tracing/latency/latency-collector.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/tools/tracing/latency/latency-collector.c b/tools/tracing/latency/latency-collector.c
index b69de9263ee6..3a2e6bb781a8 100644
--- a/tools/tracing/latency/latency-collector.c
+++ b/tools/tracing/latency/latency-collector.c
@@ -1018,7 +1018,7 @@ static long go_to_sleep(const struct entry *req)
cond_timedwait(&printstate.cond, &printstate.mutex, &future);
if (time_has_passed(&future))
break;
- };
+ }
if (printstate_has_new_req_arrived(req))
delay = -1;
@@ -1941,7 +1941,7 @@ static void scan_arguments(int argc, char *argv[])
if (value < 0) {
warnx("TIME must be >= 0\n");
show_usage();
- ;
+ exit(0);
}
trace_enable = true;
use_random_sleep = true;
--
2.17.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v2] tracing/tools: Remove unneeded semicolon
2021-03-08 2:24 [PATCH v2] tracing/tools: Remove unneeded semicolon Xu Wang
@ 2021-03-08 11:40 ` Viktor.Rosendahl
0 siblings, 0 replies; 2+ messages in thread
From: Viktor.Rosendahl @ 2021-03-08 11:40 UTC (permalink / raw
To: vulab, rostedt, colin.king; +Cc: linux-kernel
On Mon, 2021-03-08 at 02:24 +0000, Xu Wang wrote:
> fix semicolon.cocci warning:
> tools/tracing/latency/latency-collector.c:1021:2-3: Unneeded semicolon
>
> Signed-off-by: Xu Wang <vulab@iscas.ac.cn>
Reviewed-by: Viktor Rosendahl <Viktor.Rosendahl@bmw.de>
> ---
> Changes since v2:
> - Fix another instance of superfluous semicolon.
> ---
> tools/tracing/latency/latency-collector.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/tools/tracing/latency/latency-collector.c
> b/tools/tracing/latency/latency-collector.c
> index b69de9263ee6..3a2e6bb781a8 100644
> --- a/tools/tracing/latency/latency-collector.c
> +++ b/tools/tracing/latency/latency-collector.c
> @@ -1018,7 +1018,7 @@ static long go_to_sleep(const struct entry *req)
> cond_timedwait(&printstate.cond, &printstate.mutex, &future);
> if (time_has_passed(&future))
> break;
> - };
> + }
>
> if (printstate_has_new_req_arrived(req))
> delay = -1;
> @@ -1941,7 +1941,7 @@ static void scan_arguments(int argc, char *argv[])
> if (value < 0) {
> warnx("TIME must be >= 0\n");
> show_usage();
> - ;
> + exit(0);
> }
> trace_enable = true;
> use_random_sleep = true;
best regards,
Viktor
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-03-08 11:48 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-03-08 2:24 [PATCH v2] tracing/tools: Remove unneeded semicolon Xu Wang
2021-03-08 11:40 ` Viktor.Rosendahl
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).