From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Walter Harms <wharms@bfs.de>,
Christophe JAILLET <christophe.jaillet@wanadoo.fr>,
Alim Akhtar <alim.akhtar@samsung.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Jiri Slaby <jirislaby@kernel.org>,
Thomas Abraham <thomas.abraham@linaro.org>,
Kukjin Kim <kgene.kim@samsung.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"kernel-janitors@vger.kernel.org"
<kernel-janitors@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-samsung-soc@vger.kernel.org"
<linux-samsung-soc@vger.kernel.org>,
"linux-serial@vger.kernel.org" <linux-serial@vger.kernel.org>
Subject: Re: AW: [PATCH 2/2] tty: serial: samsung_tty: Fix a memory leak in s3c24xx_serial_getclk() when iterating clk
Date: Fri, 9 Jun 2023 13:56:19 +0200 [thread overview]
Message-ID: <f3607725-b08c-8d96-02f8-f8f89af8e8b1@linaro.org> (raw)
In-Reply-To: <f31523d7270d4a1f82d96b7891ed13e6@bfs.de>
On 09/06/2023 10:57, Walter Harms wrote:
>
> while we are here ....
>
> perhaps INT_MAX from kernel.h ?
>
> int deviation = (1 << 30) - 1;
>
> the part before looks a bit strange
>
> if (ourport->info->has_divslot) {
> unsigned long div = rate / req_baud;
>
> /* The UDIVSLOT register on the newer UARTs allows us to
> * get a divisor adjustment of 1/16th on the baud clock.
> *
> * We don't keep the UDIVSLOT value (the 16ths we
> * calculated by not multiplying the baud by 16) as it
> * is easy enough to recalculate.
> */
>
> quot = div / 16;
> baud = rate / div;
> because
> baud=rate/rate/req_baud = req_baud
> can this be simplyfied ? (or is the numeric required ?)
>
>
> Homebrew abs() kernel.h has a abs() can we use it here ?
>
> if (calc_deviation < 0)
> calc_deviation = -calc_deviation;
>
> to the patch:
>
> + /*
> + * If we find a better clk, release the previous one, if
> + * any.
> + */
> + if (!IS_ERR(*best_clk))
> + clk_put(*best_clk);
>
> the intentions are good. *best_clk is user supplied (and should be NULL)
> filled & released in the next round but IMHO must be valid (is clk).
> so no need to check. (ntl clk_put seems to handle NULL and ERR )
> if (!clk || WARN_ON_ONCE(IS_ERR(clk)))
> return;
Don't top-post.
Anyway, I don't understand what you want to say here.
Best regards,
Krzysztof
next prev parent reply other threads:[~2023-06-09 11:57 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-09 4:45 [PATCH 1/2] tty: serial: samsung_tty: Fix a memory leak in s3c24xx_serial_getclk() in case of error Christophe JAILLET
2023-06-09 4:45 ` [PATCH 2/2] tty: serial: samsung_tty: Fix a memory leak in s3c24xx_serial_getclk() when iterating clk Christophe JAILLET
2023-06-09 8:57 ` AW: " Walter Harms
2023-06-09 11:56 ` Krzysztof Kozlowski [this message]
2023-06-09 16:17 ` Christophe JAILLET
2023-06-09 11:53 ` Krzysztof Kozlowski
2023-06-10 10:39 ` Andi Shyti
2023-06-10 10:45 ` Krzysztof Kozlowski
2023-06-10 10:57 ` Andi Shyti
2023-06-09 11:51 ` [PATCH 1/2] tty: serial: samsung_tty: Fix a memory leak in s3c24xx_serial_getclk() in case of error Krzysztof Kozlowski
2023-06-10 10:26 ` Andi Shyti
2023-06-10 14:07 ` Christophe JAILLET
2023-06-10 14:54 ` Andi Shyti
2023-06-10 16:23 ` Krzysztof Kozlowski
2023-06-10 17:10 ` Andi Shyti
2023-06-10 17:32 ` Krzysztof Kozlowski
2023-06-10 17:40 ` Christophe JAILLET
2023-06-12 4:53 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f3607725-b08c-8d96-02f8-f8f89af8e8b1@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=alim.akhtar@samsung.com \
--cc=christophe.jaillet@wanadoo.fr \
--cc=gregkh@linuxfoundation.org \
--cc=jirislaby@kernel.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=kgene.kim@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=thomas.abraham@linaro.org \
--cc=wharms@bfs.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).