From: Michael Riesch <michael.riesch@collabora.com>
To: Mehdi Djait <mehdi.djait@linux.intel.com>,
laurent.pinchart@ideasonboard.com, sakari.ailus@linux.intel.com
Cc: akinobu.mita@gmail.com, stanislaw.gruszka@linux.intel.com,
hdegoede@redhat.com, arnd@arndb.de, alain.volmat@foss.st.com,
andrzej.hajda@intel.com, benjamin.mugnier@foss.st.com,
dave.stevenson@raspberrypi.com, hansg@kernel.org,
hverkuil@xs4all.nl, jacopo.mondi@ideasonboard.com,
jonas@kwiboo.se, kieran.bingham@ideasonboard.com,
khalasa@piap.pl, prabhakar.csengg@gmail.com, mani@kernel.org,
m.felsch@pengutronix.de, martink@posteo.de,
mattwmajewski@gmail.com, matthias.fend@emfend.at,
mchehab@kernel.org, naush@raspberrypi.com,
nicholas@rothemail.net, nicolas.dufresne@collabora.com,
paul.elder@ideasonboard.com, dan.scally@ideasonboard.com,
pavel@kernel.org, petrcvekcz@gmail.com, rashanmu@gmail.com,
ribalda@chromium.org, rmfrfs@gmail.com, zhengsq@rock-chips.com,
slongerbeam@gmail.com, sylvain.petinot@foss.st.com,
s.nawrocki@samsung.com, tomi.valkeinen@ideasonboard.com,
umang.jain@ideasonboard.com, zhi.mao@mediatek.com,
linux-kernel@vger.kernel.org, linux-media@vger.kernel.org
Subject: Re: [PATCH v1 00/55] media: Add a helper for obtaining the clock producer
Date: Sat, 21 Jun 2025 16:28:42 +0200 [thread overview]
Message-ID: <f629be75-4019-4e5c-abcc-45dc8b7e1a8f@collabora.com> (raw)
In-Reply-To: <cover.1750352394.git.mehdi.djait@linux.intel.com>
Hi Mehdi,
Thanks for your work!
On 6/19/25 19:58, Mehdi Djait wrote:
> Hello everyone,
>
> Here is my v1 for the new helper v4l2_devm_sensor_clk_get()
>
> Any testing of the patches is GREATLY APPRECIATED! Especially the two
> drivers with the special ACPI case:
> 1) OV8865
> 2) OV2680
>
>
> Background
> ----------
>
> A reference to the clock producer is not available to the kernel
> in ACPI-based platforms but the sensor drivers still need them.
>
> devm_clk_get() will return an error and the probe function will fail.
>
>
> Solution
> --------
>
> Introduce a generic helper for v4l2 sensor drivers on both DT- and ACPI-based
> platforms.
Out of curiosity: How is this problem specific to V4L2? Does one need a
similar helper in other subsystems?
Best regards,
Michael
>
> This helper behaves the same as clk_get_optional() except where there is
> no clock producer like in ACPI-based platforms.
>
> For ACPI-based platforms the function will read the "clock-frequency"
> ACPI _DSD property and register a fixed frequency clock with the frequency
> indicated in the property.
>
>
> Solution for special ACPI case
> ------------------------------
>
> This function also handles the special ACPI-based system case where:
>
> 1) The clock-frequency _DSD property is present.
> 2) A reference to the clock producer is present, where the clock is provided
> by a camera sensor PMIC driver (e.g. int3472/tps68470.c)
>
> In this case try to set the clock-frequency value to the provided clock.
>
>
> RFC History
> -----------
>
> RFC v4 -> RFC v5:
> Suggested by Arnd Bergmann:
> - removed IS_REACHABLE(CONFIG_COMMON_CLK). IS_REACHABLE() is actually
> discouraged [1]. COFIG_COMMON_CLK is a bool, so IS_ENABLED() will be the
> right solution here
> Suggested by Hans de Goede:
> - added handling for the special ACPI-based system case, where
> both a reference to the clock-provider and the _DSD
> clock-frequency are present.
> - updated the function's kernel-doc and the commit msg
> to mention this special case.
> Link RFC v4: https://lore.kernel.org/linux-media/20250321130329.342236-1-mehdi.djait@linux.intel.com/
> [1] https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/Documentation/kbuild/kconfig-language.rst?h=next-20250513&id=700bd25bd4f47a0f4e02e0a25dde05f1a6b16eea
>
> RFC v3 -> RFC v4:
> Suggested by Laurent:
> - removed the #ifdef to use IS_REACHABLE(CONFIG_COMMON_CLK)
> - changed to kasprintf() to allocate the clk name when id is NULL and
> used the __free(kfree) scope-based cleanup helper when
> defining the variable to hold the allocated name
> Link v3: https://lore.kernel.org/linux-media/20250321093814.18159-1-mehdi.djait@linux.intel.com/
>
> RFC v2 -> RFC v3:
> - Added #ifdef CONFIG_COMMON_CLK for the ACPI case
> Link v2: https://lore.kernel.org/linux-media/20250310122305.209534-1-mehdi.djait@linux.intel.com/
>
> RFC v1 -> RFC v2:
> Suggested by Sakari:
> - removed clk_name
> - removed the IS_ERR() check
> - improved the kernel-doc comment and commit msg
> Link v1: https://lore.kernel.org/linux-media/20250227092643.113939-1-mehdi.djait@linux.intel.com
>
> Mehdi Djait (55):
> media: v4l2-common: Add a helper for obtaining the clock producer
> Documentation: media: camera-sensor: Mention
> v4l2_devm_sensor_clk_get() for obtaining the clock
> media: i2c: ar0521: Use the v4l2 helper for obtaining the clock
> media: i2c: ds90ub913: Use the v4l2 helper for obtaining the clock
> media: i2c: ds90ub960: Use the v4l2 helper for obtaining the clock
> media: i2c: et8ek8: Use the v4l2 helper for obtaining the clock
> media: i2c: gc05a2: Use the v4l2 helper for obtaining the clock
> media: i2c: gc08a3: Use the v4l2 helper for obtaining the clock
> media: i2c: gc2145: Use the v4l2 helper for obtaining the clock
> media: i2c: hi846: Use the v4l2 helper for obtaining the clock
> media: i2c: imx214: Use the v4l2 helper for obtaining the clock
> media: i2c: imx219: Use the v4l2 helper for obtaining the clock
> media: i2c: imx283: Use the v4l2 helper for obtaining the clock
> media: i2c: imx290: Use the v4l2 helper for obtaining the clock
> media: i2c: imx296: Use the v4l2 helper for obtaining the clock
> media: i2c: imx334: Use the v4l2 helper for obtaining the clock
> media: i2c: imx335: Use the v4l2 helper for obtaining the clock
> media: i2c: imx412: Use the v4l2 helper for obtaining the clock
> media: i2c: imx415: Use the v4l2 helper for obtaining the clock
> media: i2c: max2175: Use the v4l2 helper for obtaining the clock
> media: i2c: mt9m001: Use the v4l2 helper for obtaining the clock
> media: i2c: mt9m111: Use the v4l2 helper for obtaining the clock
> media: i2c: mt9m114: Use the v4l2 helper for obtaining the clock
> media: i2c: mt9p031: Use the v4l2 helper for obtaining the clock
> media: i2c: mt9t112: Use the v4l2 helper for obtaining the clock
> media: i2c: mt9v032: Use the v4l2 helper for obtaining the clock
> media: i2c: mt9v111: Use the v4l2 helper for obtaining the clock
> media: i2c: ov02a10: Use the v4l2 helper for obtaining the clock
> media: i2c: ov2659: Use the v4l2 helper for obtaining the clock
> media: i2c: ov2685: Use the v4l2 helper for obtaining the clock
> media: i2c: ov5640: Use the v4l2 helper for obtaining the clock
> media: i2c: ov5645: Use the v4l2 helper for obtaining the clock
> media: i2c: ov5647: Use the v4l2 helper for obtaining the clock
> media: i2c: ov5648: Use the v4l2 helper for obtaining the clock
> media: i2c: ov5695: Use the v4l2 helper for obtaining the clock
> media: i2c: ov64a40: Use the v4l2 helper for obtaining the clock
> media: i2c: ov6650: Use the v4l2 helper for obtaining the clock
> media: i2c: ov7740: Use the v4l2 helper for obtaining the clock
> media: i2c: ov8856: Use the v4l2 helper for obtaining the clock
> media: i2c: ov8858: Use the v4l2 helper for obtaining the clock
> media: i2c: ov8865: Use the v4l2 helper for obtaining the clock
> media: i2c: ov9282: Use the v4l2 helper for obtaining the clock
> media: i2c: ov9640: Use the v4l2 helper for obtaining the clock
> media: i2c: ov9650: Use the v4l2 helper for obtaining the clock
> media: i2c: s5c73m3: Use the v4l2 helper for obtaining the clock
> media: i2c: s5k5baf: Use the v4l2 helper for obtaining the clock
> media: i2c: s5k6a3: Use the v4l2 helper for obtaining the clock
> media: i2c: st-mipid02: Use the v4l2 helper for obtaining the clock
> media: i2c: tc358743: Use the v4l2 helper for obtaining the clock
> media: i2c: tc358746: Use the v4l2 helper for obtaining the clock
> media: i2c: thp7312: Use the v4l2 helper for obtaining the clock
> media: i2c: vd55g1: Use the v4l2 helper for obtaining the clock
> media: i2c: vd56g3: Use the v4l2 helper for obtaining the clock
> media: i2c: vgxy61: Use the v4l2 helper for obtaining the clock
> media: i2c: ov2680: Use the v4l2 helper for obtaining the clock
>
> .../driver-api/media/camera-sensor.rst | 3 +-
> drivers/media/i2c/ar0521.c | 2 +-
> drivers/media/i2c/ds90ub913.c | 2 +-
> drivers/media/i2c/ds90ub960.c | 2 +-
> drivers/media/i2c/et8ek8/et8ek8_driver.c | 2 +-
> drivers/media/i2c/gc05a2.c | 2 +-
> drivers/media/i2c/gc08a3.c | 2 +-
> drivers/media/i2c/gc2145.c | 2 +-
> drivers/media/i2c/hi846.c | 2 +-
> drivers/media/i2c/imx214.c | 2 +-
> drivers/media/i2c/imx219.c | 2 +-
> drivers/media/i2c/imx283.c | 2 +-
> drivers/media/i2c/imx290.c | 2 +-
> drivers/media/i2c/imx296.c | 2 +-
> drivers/media/i2c/imx334.c | 2 +-
> drivers/media/i2c/imx335.c | 2 +-
> drivers/media/i2c/imx412.c | 2 +-
> drivers/media/i2c/imx415.c | 2 +-
> drivers/media/i2c/max2175.c | 2 +-
> drivers/media/i2c/mt9m001.c | 2 +-
> drivers/media/i2c/mt9m111.c | 2 +-
> drivers/media/i2c/mt9m114.c | 2 +-
> drivers/media/i2c/mt9p031.c | 2 +-
> drivers/media/i2c/mt9t112.c | 2 +-
> drivers/media/i2c/mt9v032.c | 2 +-
> drivers/media/i2c/mt9v111.c | 2 +-
> drivers/media/i2c/ov02a10.c | 2 +-
> drivers/media/i2c/ov2659.c | 2 +-
> drivers/media/i2c/ov2680.c | 27 +++-------
> drivers/media/i2c/ov2685.c | 2 +-
> drivers/media/i2c/ov5640.c | 2 +-
> drivers/media/i2c/ov5645.c | 2 +-
> drivers/media/i2c/ov5647.c | 2 +-
> drivers/media/i2c/ov5648.c | 2 +-
> drivers/media/i2c/ov5695.c | 2 +-
> drivers/media/i2c/ov64a40.c | 2 +-
> drivers/media/i2c/ov6650.c | 2 +-
> drivers/media/i2c/ov7740.c | 2 +-
> drivers/media/i2c/ov8856.c | 2 +-
> drivers/media/i2c/ov8858.c | 2 +-
> drivers/media/i2c/ov8865.c | 32 ++----------
> drivers/media/i2c/ov9282.c | 2 +-
> drivers/media/i2c/ov9640.c | 2 +-
> drivers/media/i2c/ov9650.c | 2 +-
> drivers/media/i2c/s5c73m3/s5c73m3-core.c | 2 +-
> drivers/media/i2c/s5k5baf.c | 2 +-
> drivers/media/i2c/s5k6a3.c | 2 +-
> drivers/media/i2c/st-mipid02.c | 2 +-
> drivers/media/i2c/tc358743.c | 2 +-
> drivers/media/i2c/tc358746.c | 2 +-
> drivers/media/i2c/thp7312.c | 2 +-
> drivers/media/i2c/vd55g1.c | 2 +-
> drivers/media/i2c/vd56g3.c | 2 +-
> drivers/media/i2c/vgxy61.c | 2 +-
> drivers/media/v4l2-core/v4l2-common.c | 49 +++++++++++++++++++
> include/media/v4l2-common.h | 25 ++++++++++
> 56 files changed, 136 insertions(+), 102 deletions(-)
>
next prev parent reply other threads:[~2025-06-21 14:28 UTC|newest]
Thread overview: 70+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-19 17:58 [PATCH v1 00/55] media: Add a helper for obtaining the clock producer Mehdi Djait
2025-06-19 17:58 ` [PATCH v1 01/55] media: v4l2-common: " Mehdi Djait
2025-06-19 22:07 ` Laurent Pinchart
2025-06-19 17:58 ` [PATCH v1 02/55] Documentation: media: camera-sensor: Mention v4l2_devm_sensor_clk_get() for obtaining the clock Mehdi Djait
2025-06-19 21:47 ` Laurent Pinchart
2025-06-23 10:49 ` Sakari Ailus
2025-06-19 17:58 ` [PATCH v1 03/55] media: i2c: ar0521: Use the v4l2 helper " Mehdi Djait
2025-06-21 10:21 ` Krzysztof Hałasa | Łukasiewicz – PIAP
2025-06-19 17:58 ` [PATCH v1 04/55] media: i2c: ds90ub913: " Mehdi Djait
2025-06-19 17:58 ` [PATCH v1 05/55] media: i2c: ds90ub960: " Mehdi Djait
2025-06-19 17:58 ` [PATCH v1 06/55] media: i2c: et8ek8: " Mehdi Djait
2025-06-19 17:59 ` [PATCH v1 07/55] media: i2c: gc05a2: " Mehdi Djait
2025-06-19 17:59 ` [PATCH v1 08/55] media: i2c: gc08a3: " Mehdi Djait
2025-06-19 17:59 ` [PATCH v1 09/55] media: i2c: gc2145: " Mehdi Djait
2025-06-19 17:59 ` [PATCH v1 10/55] media: i2c: hi846: " Mehdi Djait
2025-06-19 17:59 ` [PATCH v1 11/55] media: i2c: imx214: " Mehdi Djait
2025-06-19 17:59 ` [PATCH v1 12/55] media: i2c: imx219: " Mehdi Djait
2025-06-19 17:59 ` [PATCH v1 13/55] media: i2c: imx283: " Mehdi Djait
2025-06-19 17:59 ` [PATCH v1 14/55] media: i2c: imx290: " Mehdi Djait
2025-06-19 17:59 ` [PATCH v1 15/55] media: i2c: imx296: " Mehdi Djait
2025-06-19 17:59 ` [PATCH v1 16/55] media: i2c: imx334: " Mehdi Djait
2025-06-19 17:59 ` [PATCH v1 17/55] media: i2c: imx335: " Mehdi Djait
2025-06-19 17:59 ` [PATCH v1 18/55] media: i2c: imx412: " Mehdi Djait
2025-06-19 17:59 ` [PATCH v1 19/55] media: i2c: imx415: " Mehdi Djait
2025-06-21 14:23 ` Michael Riesch
2025-06-19 17:59 ` [PATCH v1 20/55] media: i2c: max2175: " Mehdi Djait
2025-06-19 17:59 ` [PATCH v1 21/55] media: i2c: mt9m001: " Mehdi Djait
2025-06-19 17:59 ` [PATCH v1 22/55] media: i2c: mt9m111: " Mehdi Djait
2025-06-19 17:59 ` [PATCH v1 23/55] media: i2c: mt9m114: " Mehdi Djait
2025-06-19 17:59 ` [PATCH v1 24/55] media: i2c: mt9p031: " Mehdi Djait
2025-06-19 17:59 ` [PATCH v1 25/55] media: i2c: mt9t112: " Mehdi Djait
2025-06-19 17:59 ` [PATCH v1 26/55] media: i2c: mt9v032: " Mehdi Djait
2025-06-19 17:59 ` [PATCH v1 27/55] media: i2c: mt9v111: " Mehdi Djait
2025-06-19 17:59 ` [PATCH v1 28/55] media: i2c: ov02a10: " Mehdi Djait
2025-06-19 17:59 ` [PATCH v1 29/55] media: i2c: ov2659: " Mehdi Djait
2025-06-19 17:59 ` [PATCH v1 30/55] media: i2c: ov2685: " Mehdi Djait
2025-06-19 17:59 ` [PATCH v1 31/55] media: i2c: ov5640: " Mehdi Djait
2025-06-19 17:59 ` [PATCH v1 32/55] media: i2c: ov5645: " Mehdi Djait
2025-06-19 17:59 ` [PATCH v1 33/55] media: i2c: ov5647: " Mehdi Djait
2025-06-19 17:59 ` [PATCH v1 34/55] media: i2c: ov5648: " Mehdi Djait
2025-06-19 17:59 ` [PATCH v1 35/55] media: i2c: ov5695: " Mehdi Djait
2025-06-19 17:59 ` [PATCH v1 36/55] media: i2c: ov64a40: " Mehdi Djait
2025-06-19 17:59 ` [PATCH v1 37/55] media: i2c: ov6650: " Mehdi Djait
2025-06-19 17:59 ` [PATCH v1 38/55] media: i2c: ov7740: " Mehdi Djait
2025-06-19 17:59 ` [PATCH v1 39/55] media: i2c: ov8856: " Mehdi Djait
2025-06-19 17:59 ` [PATCH v1 40/55] media: i2c: ov8858: " Mehdi Djait
2025-06-19 17:59 ` [PATCH v1 41/55] media: i2c: ov8865: " Mehdi Djait
2025-06-19 21:57 ` Laurent Pinchart
2025-06-19 21:59 ` Laurent Pinchart
2025-06-21 7:58 ` Sakari Ailus
2025-06-21 8:27 ` Hans de Goede
2025-06-19 17:59 ` [PATCH v1 42/55] media: i2c: ov9282: " Mehdi Djait
2025-06-19 17:59 ` [PATCH v1 43/55] media: i2c: ov9640: " Mehdi Djait
2025-06-19 17:59 ` [PATCH v1 44/55] media: i2c: ov9650: " Mehdi Djait
2025-06-19 18:09 ` [PATCH v1 45/55] media: i2c: s5c73m3: " Mehdi Djait
2025-06-19 18:11 ` [PATCH v1 46/55] media: i2c: s5k5baf: " Mehdi Djait
2025-06-19 18:11 ` [PATCH v1 47/55] media: i2c: s5k6a3: " Mehdi Djait
2025-06-19 18:11 ` [PATCH v1 48/55] media: i2c: st-mipid02: " Mehdi Djait
2025-06-19 18:11 ` [PATCH v1 50/55] media: i2c: tc358746: " Mehdi Djait
2025-06-19 18:11 ` [PATCH v1 51/55] media: i2c: thp7312: " Mehdi Djait
2025-06-19 18:11 ` [PATCH v1 52/55] media: i2c: vd55g1: " Mehdi Djait
2025-06-19 18:11 ` [PATCH v1 53/55] media: i2c: vd56g3: " Mehdi Djait
2025-06-19 18:11 ` [PATCH v1 54/55] media: i2c: vgxy61: " Mehdi Djait
2025-06-19 18:11 ` [PATCH v1 55/55] media: i2c: ov2680: " Mehdi Djait
2025-06-19 22:00 ` Laurent Pinchart
2025-06-19 18:15 ` [PATCH v1 49/55] media: i2c: tc358743: " Mehdi Djait
2025-06-19 21:26 ` [PATCH v1 00/55] media: Add a helper for obtaining the clock producer Laurent Pinchart
2025-06-21 14:28 ` Michael Riesch [this message]
2025-06-22 11:45 ` Hans de Goede
2025-06-24 20:34 ` Lad, Prabhakar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f629be75-4019-4e5c-abcc-45dc8b7e1a8f@collabora.com \
--to=michael.riesch@collabora.com \
--cc=akinobu.mita@gmail.com \
--cc=alain.volmat@foss.st.com \
--cc=andrzej.hajda@intel.com \
--cc=arnd@arndb.de \
--cc=benjamin.mugnier@foss.st.com \
--cc=dan.scally@ideasonboard.com \
--cc=dave.stevenson@raspberrypi.com \
--cc=hansg@kernel.org \
--cc=hdegoede@redhat.com \
--cc=hverkuil@xs4all.nl \
--cc=jacopo.mondi@ideasonboard.com \
--cc=jonas@kwiboo.se \
--cc=khalasa@piap.pl \
--cc=kieran.bingham@ideasonboard.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=m.felsch@pengutronix.de \
--cc=mani@kernel.org \
--cc=martink@posteo.de \
--cc=matthias.fend@emfend.at \
--cc=mattwmajewski@gmail.com \
--cc=mchehab@kernel.org \
--cc=mehdi.djait@linux.intel.com \
--cc=naush@raspberrypi.com \
--cc=nicholas@rothemail.net \
--cc=nicolas.dufresne@collabora.com \
--cc=paul.elder@ideasonboard.com \
--cc=pavel@kernel.org \
--cc=petrcvekcz@gmail.com \
--cc=prabhakar.csengg@gmail.com \
--cc=rashanmu@gmail.com \
--cc=ribalda@chromium.org \
--cc=rmfrfs@gmail.com \
--cc=s.nawrocki@samsung.com \
--cc=sakari.ailus@linux.intel.com \
--cc=slongerbeam@gmail.com \
--cc=stanislaw.gruszka@linux.intel.com \
--cc=sylvain.petinot@foss.st.com \
--cc=tomi.valkeinen@ideasonboard.com \
--cc=umang.jain@ideasonboard.com \
--cc=zhengsq@rock-chips.com \
--cc=zhi.mao@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).