From: MD Danish Anwar <danishanwar@ti.com>
To: Andrew Lunn <andrew@lunn.ch>
Cc: Dan Carpenter <dan.carpenter@linaro.org>,
Heiner Kallweit <hkallweit1@gmail.com>,
Jan Kiszka <jan.kiszka@siemens.com>,
Diogo Ivo <diogo.ivo@siemens.com>,
Paolo Abeni <pabeni@redhat.com>, Jakub Kicinski <kuba@kernel.org>,
Eric Dumazet <edumazet@google.com>,
"David S. Miller" <davem@davemloft.net>,
<linux-kernel@vger.kernel.org>, <netdev@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>, <srk@ti.com>,
Vignesh Raghavendra <vigneshr@ti.com>, <r-gunasekaran@ti.com>,
Roger Quadros <rogerq@kernel.org>
Subject: Re: [PATCH net-next] net: ti: icssg_prueth: Add SW TX / RX Coalescing based on hrtimers
Date: Mon, 29 Apr 2024 11:24:50 +0530 [thread overview]
Message-ID: <f6ef8692-246e-49a5-952f-d371a87a70f4@ti.com> (raw)
In-Reply-To: <2a4bea87-04bf-4373-8220-69650b435710@lunn.ch>
On 25/04/24 6:19 pm, Andrew Lunn wrote:
>> I did some benchmarking today with,
>> 1. Default driver (without any IRQ coalescing enabled)
>> 2. IRQ Coalescing (With this patch)
>> 3. Default IRQ Coalescing (Suggested by you in the above patch)
>>
>> I have pasted the full logs at [1].
>>
>> Below are the final numbers,
>>
>> ==============================================================
>> Method | Tput_TX | CPU_TX | Tput_RX | CPU_RX |
>> ==============================================================
>> Default Driver 943 Mbps 31% 517 Mbps 38% |
>> IRQ Coalescing (Patch) 943 Mbps 28% 518 Mbps 25% |
>> Default IRQ Coalescing 942 Mbps 32% 521 Mbps 25% |
>> ==============================================================
>>
>> I see that the performance number is more or less same for all three
>> methods only the CPU load seems to be varying. The IRQ coalescing patch
>> (using hrtimer) seems to improve the cpu load by 3-4% in TX and 13% in
>> RX. Whereas the default method that you have suggested doesn't give any
>> improvemnet in tx however cpu load improves in RX with the same amount
>> as method 2.
>>
>> Please let me know if this patch is OK to you based on the benchmarking?
>
> It is good to include benchmark results in patches which claim to
> improve performance. Please add the default and the patch version
> results to the commit message.
Sure, I will add the benchmarking numbers in commit message and send v2.
>
> The numbers show your more complex version does bring benefits, so it
> is O.K. to use it. I just wounder how many other drivers would benefit
> from a one line change.
>
> Andrew
--
Thanks and Regards,
Danish
next prev parent reply other threads:[~2024-04-29 5:55 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-24 9:18 [PATCH net-next] net: ti: icssg_prueth: Add SW TX / RX Coalescing based on hrtimers MD Danish Anwar
2024-04-24 12:31 ` Andrew Lunn
2024-04-25 6:43 ` MD Danish Anwar
2024-04-25 12:49 ` Andrew Lunn
2024-04-29 5:54 ` MD Danish Anwar [this message]
2024-04-27 13:41 ` Simon Horman
2024-04-29 5:54 ` MD Danish Anwar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f6ef8692-246e-49a5-952f-d371a87a70f4@ti.com \
--to=danishanwar@ti.com \
--cc=andrew@lunn.ch \
--cc=dan.carpenter@linaro.org \
--cc=davem@davemloft.net \
--cc=diogo.ivo@siemens.com \
--cc=edumazet@google.com \
--cc=hkallweit1@gmail.com \
--cc=jan.kiszka@siemens.com \
--cc=kuba@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=r-gunasekaran@ti.com \
--cc=rogerq@kernel.org \
--cc=srk@ti.com \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).