From: Sui Jingfeng <sui.jingfeng@linux.dev>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Neil Armstrong <neil.armstrong@linaro.org>,
Randy Dunlap <rdunlap@infradead.org>,
dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org
Cc: Jessica Zhang <quic_jesszhan@quicinc.com>,
Sam Ravnborg <sam@ravnborg.org>,
Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
Maxime Ripard <mripard@kernel.org>,
Thomas Zimmermann <tzimmermann@suse.de>,
David Airlie <airlied@gmail.com>, Daniel Vetter <daniel@ffwll.ch>
Subject: Re: [v1,3/3] drm/panel: ili9341: Use predefined error codes
Date: Wed, 1 May 2024 00:54:08 +0800 [thread overview]
Message-ID: <f811953a-ce63-40cd-9de3-ecd5e1c1727a@linux.dev> (raw)
In-Reply-To: <20240425142706.2440113-4-andriy.shevchenko@linux.intel.com>
On 2024/4/25 22:26, Andy Shevchenko wrote:
> In one case the -1 is returned which is quite confusing code for
> the wrong device ID, in another the ret is returning instead of
> plain 0 that also confusing as readed may ask the possible meaning
> of positive codes, which are never the case there. Convert both
> to use explicit predefined error codes to make it clear what's going
> on there.
>
> Fixes: 5a04227326b0 ("drm/panel: Add ilitek ili9341 panel driver")
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org>
Reviewed-by: Sui Jingfeng <sui.jingfeng@linux.dev>
--
Best regards,
Sui
next prev parent reply other threads:[~2024-04-30 16:54 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-25 14:26 [PATCH v1 0/3] drm/panel: ili9341: Obvious fixes Andy Shevchenko
2024-04-25 14:26 ` [PATCH v1 1/3] drm/panel: ili9341: Correct use of device property APIs Andy Shevchenko
2024-04-25 16:00 ` Neil Armstrong
2024-04-25 18:08 ` [v1,1/3] " Sui Jingfeng
2024-04-25 18:53 ` Sui Jingfeng
2024-04-25 19:12 ` Andy Shevchenko
2024-04-25 21:13 ` Sui Jingfeng
2024-04-30 14:13 ` Andy Shevchenko
2024-04-30 16:27 ` Sui Jingfeng
2024-05-02 8:32 ` Andy Shevchenko
2024-05-02 16:25 ` Sui Jingfeng
2024-05-02 17:28 ` Andy Shevchenko
2024-05-03 4:57 ` Sui Jingfeng
2024-05-03 15:46 ` Andy Shevchenko
2024-04-25 19:10 ` Andy Shevchenko
2024-04-25 20:43 ` Sui Jingfeng
2024-04-25 21:27 ` Sui Jingfeng
2024-04-26 6:23 ` Maxime Ripard
2024-04-27 5:57 ` Sui Jingfeng
2024-04-29 11:55 ` Maxime Ripard
2024-04-29 16:54 ` Sui Jingfeng
2024-04-30 9:34 ` Maxime Ripard
2024-05-02 7:34 ` Neil Armstrong
2024-05-02 8:33 ` Andy Shevchenko
2024-05-02 17:28 ` Sui Jingfeng
2024-05-02 17:38 ` Andy Shevchenko
2024-04-30 14:32 ` Andy Shevchenko
2024-04-30 17:24 ` Sui Jingfeng
2024-04-30 10:19 ` [PATCH v1 1/3] " Dmitry Baryshkov
2024-04-25 14:26 ` [PATCH v1 2/3] drm/panel: ili9341: Respect deferred probe Andy Shevchenko
2024-04-25 16:00 ` Neil Armstrong
2024-04-30 10:21 ` Dmitry Baryshkov
2024-04-30 16:50 ` [v1,2/3] " Sui Jingfeng
2024-04-25 14:26 ` [PATCH v1 3/3] drm/panel: ili9341: Use predefined error codes Andy Shevchenko
2024-04-25 16:00 ` Neil Armstrong
2024-04-30 16:54 ` Sui Jingfeng [this message]
2024-04-25 15:08 ` [PATCH v1 0/3] drm/panel: ili9341: Obvious fixes Andy Shevchenko
2024-05-02 7:43 ` Neil Armstrong
2024-05-02 8:33 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f811953a-ce63-40cd-9de3-ecd5e1c1727a@linux.dev \
--to=sui.jingfeng@linux.dev \
--cc=airlied@gmail.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=mripard@kernel.org \
--cc=neil.armstrong@linaro.org \
--cc=quic_jesszhan@quicinc.com \
--cc=rdunlap@infradead.org \
--cc=sam@ravnborg.org \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).