* [PATCH v2] staging: rtl8192e: remove the r8192E_dev.c's unnecessary brace
@ 2024-05-08 15:13 Chen shuo
2024-05-09 7:51 ` Philipp Hortmann
0 siblings, 1 reply; 2+ messages in thread
From: Chen shuo @ 2024-05-08 15:13 UTC (permalink / raw
To: 1289151713, linux-staging, linux-kernel
There is a unnecessary brace in r8192E_dev.c.Remove it to shorten
code and improve readability.
Signed-off-by: Chen shuo <1289151713@qq.com>
---
v2:Make "Subject" line more unique.
Add space after : and driver name in the subject.
drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c b/drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c
index e3ed709a7674..1862a9899966 100644
--- a/drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c
+++ b/drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c
@@ -1640,9 +1640,8 @@ bool rtl92e_get_rx_stats(struct net_device *dev, struct rtllib_rx_stats *stats,
if (stats->Length < 24)
stats->bHwError |= 1;
- if (stats->bHwError) {
+ if (stats->bHwError)
return false;
- }
stats->RxDrvInfoSize = pdesc->RxDrvInfoSize;
stats->RxBufShift = (pdesc->Shift) & 0x03;
--
2.34.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v2] staging: rtl8192e: remove the r8192E_dev.c's unnecessary brace
2024-05-08 15:13 [PATCH v2] staging: rtl8192e: remove the r8192E_dev.c's unnecessary brace Chen shuo
@ 2024-05-09 7:51 ` Philipp Hortmann
0 siblings, 0 replies; 2+ messages in thread
From: Philipp Hortmann @ 2024-05-09 7:51 UTC (permalink / raw
To: Chen shuo, linux-staging, linux-kernel
On 5/8/24 17:13, Chen shuo wrote:
> There is a unnecessary brace in r8192E_dev.c.Remove it to shorten
> code and improve readability.
>
> Signed-off-by: Chen shuo <1289151713@qq.com>
> ---
> v2:Make "Subject" line more unique.
> Add space after : and driver name in the subject.
>
> drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c b/drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c
> index e3ed709a7674..1862a9899966 100644
> --- a/drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c
> +++ b/drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c
> @@ -1640,9 +1640,8 @@ bool rtl92e_get_rx_stats(struct net_device *dev, struct rtllib_rx_stats *stats,
> if (stats->Length < 24)
> stats->bHwError |= 1;
>
> - if (stats->bHwError) {
> + if (stats->bHwError)
> return false;
> - }
>
> stats->RxDrvInfoSize = pdesc->RxDrvInfoSize;
> stats->RxBufShift = (pdesc->Shift) & 0x03;
Tested-by: Philipp Hortmann <philipp.g.hortmann@gmail.com>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-05-09 7:51 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-05-08 15:13 [PATCH v2] staging: rtl8192e: remove the r8192E_dev.c's unnecessary brace Chen shuo
2024-05-09 7:51 ` Philipp Hortmann
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).