From: linke li <lilinke99@qq.com>
To: ardb@kernel.org
Cc: bp@alien8.de, dave.hansen@linux.intel.com, hpa@zytor.com,
lilinke99@qq.com, linux-efi@vger.kernel.org,
linux-kernel@vger.kernel.org, mingo@redhat.com,
tglx@linutronix.de, x86@kernel.org, xujianhao01@gmail.com
Subject: Re: [PATCH] x86/efi: mark racy access on efi_rts_work.efi_rts_id
Date: Wed, 1 May 2024 10:59:28 +0800 [thread overview]
Message-ID: <tencent_B777D0238556D2AEB121ED8D2151D8BD8E06@qq.com> (raw)
In-Reply-To: <CAMj1kXEfdJ9SzPO7NpYwXW3uPGYNOzVFndRswLZb=6TPAgN5TA@mail.gmail.com>
> Why is this the only reference that needs an annotation?
In the function efi_runtime_services_init(), the if check on
efi_rts_work.efi_rts_id in line 728 uses READ_ONCE(), and the comment
explains that this is to reduce reports from KTSAN.
I propose that the check in line 754 undergoes a similar treatment for
consistency and to potentially reduce sanitizer reports.
Thank you.
prev parent reply other threads:[~2024-05-01 2:59 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-27 5:25 [PATCH] x86/efi: mark racy access on efi_rts_work.efi_rts_id linke li
2024-04-29 15:40 ` Ard Biesheuvel
2024-05-01 2:59 ` linke li [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=tencent_B777D0238556D2AEB121ED8D2151D8BD8E06@qq.com \
--to=lilinke99@qq.com \
--cc=ardb@kernel.org \
--cc=bp@alien8.de \
--cc=dave.hansen@linux.intel.com \
--cc=hpa@zytor.com \
--cc=linux-efi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
--cc=xujianhao01@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).