From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1755231AbcD0AqV (ORCPT <rfc822;w@1wt.eu>);
	Tue, 26 Apr 2016 20:46:21 -0400
Received: from userp1040.oracle.com ([156.151.31.81]:27754 "EHLO
	userp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S932074AbcD0AqS (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Tue, 26 Apr 2016 20:46:18 -0400
To: James Bottomley <James.Bottomley@HansenPartnership.com>
Cc: Arnd Bergmann <arnd@arndb.de>,
        "Martin K. Petersen" <martin.petersen@oracle.com>,
        Josh Poimboeuf <jpoimboe@redhat.com>, linux-scsi@vger.kernel.org,
        linux-kernel@vger.kernel.org, Denys Vlasenko <dvlasenk@redhat.com>,
        Thomas Graf <tgraf@suug.ch>, Peter Zijlstra <peterz@infradead.org>,
        David Rientjes <rientjes@google.com>,
        Andrew Morton <akpm@linux-foundation.org>, jamborm@gcc.gnu.org,
        Ingo Molnar <mingo@kernel.org>,
        Himanshu Madhani <himanshu.madhani@qlogic.com>,
        qla2xxx-upstream@qlogic.com
Subject: Re: [PATCH] scsi: fc: force inlining of wwn conversion functions
From: "Martin K. Petersen" <martin.petersen@oracle.com>
Organization: Oracle Corporation
References: <20160419085221.GA29087@gmail.com> <5249561.9VpAPLD61M@wuerfel>
	<yq14maoh635.fsf@sermon.lab.mkp.net> <5298237.1Guzp0G04x@wuerfel>
	<1461710218.2348.27.camel@HansenPartnership.com>
Date: Tue, 26 Apr 2016 20:44:59 -0400
In-Reply-To: <1461710218.2348.27.camel@HansenPartnership.com> (James
	Bottomley's message of "Tue, 26 Apr 2016 15:36:58 -0700")
Message-ID: <yq1bn4vg9ro.fsf@sermon.lab.mkp.net>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
X-Source-IP: userv0022.oracle.com [156.151.31.74]
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

>>>>> "James" == James Bottomley <James.Bottomley@HansenPartnership.com> writes:

>> The last point is what Denys introduced in the kernel with
>> bc27fb68aaad ("include/uapi/linux/byteorder, swab: force inlining of
>> some byteswap operations"). So maybe it's better after all to revert
>> that patch, to have a higher confidence in the same bug not appearing
>> elsewhere. It's also really a workaround for another quirk of the
>> compiler, but that one only results in duplicated functions in object
>> code rather than functions that end in the middle.

James> Yes, I think this is my preferred option.

Same here.

-- 
Martin K. Petersen	Oracle Linux Engineering