From: Jonas Oberhauser <jonas.oberhauser@huaweicloud.com>
To: Hernan Ponce de Leon <hernan.poncedeleon@huaweicloud.com>,
Alan Stern <stern@rowland.harvard.edu>
Cc: paulmck@kernel.org, parri.andrea@gmail.com, will@kernel.org,
peterz@infradead.org, boqun.feng@gmail.com, npiggin@gmail.com,
dhowells@redhat.com, j.alglave@ucl.ac.uk, luc.maranget@inria.fr,
akiyks@gmail.com, dlustig@nvidia.com, joel@joelfernandes.org,
urezki@gmail.com, quic_neeraju@quicinc.com, frederic@kernel.org,
linux-kernel@vger.kernel.org, lkmm@lists.linux.dev
Subject: Re: [PATCHv2 0/4] tools/memory-model: Define more of LKMM in tools/memory-model
Date: Mon, 29 Jul 2024 18:05:36 +0200 [thread overview]
Message-ID: <76bc2c08-655c-4ca4-a573-16a98b7dd919@huaweicloud.com> (raw)
In-Reply-To: <cd5a269a-9c6a-a311-d796-ce65c935887b@huaweicloud.com>
Am 7/29/2024 um 5:53 PM schrieb Hernan Ponce de Leon:
> On 7/29/2024 5:44 PM, Jonas Oberhauser wrote:
>>
>>
>> I don't think this is a problem. If the old version is the default,
>> and we define it in the .cfg file for the tree version of LKMM, then
>> it will work correctly for both the old and new versions. People
>> playing around with Memory Models should be careful enough not to
>> intentionally break the model by passing bogus options.
>
> The same was true for my implementation using the lkmm-legacy option
Yeah, I'm fine with that one. (Although it may be better to have a
version number as value instead of just a boolean flag, like
-model-version=x_y_z - just in case this is not the last time).
> rather than the model variant, but this was still considered to break
> backward compatibility.
>
> https://github.com/herd/herdtools7/pull/865#issuecomment-2229930493
I think Akira is a bit overzealous here. What if a user accidentally
puts -lkmm-legacy false and accidentally also adds the version number
into the litmus test and/or model?
The request can be fulfilled, by defining some relation in the bell file
that has a magic name like version_x_y_z and checks that the x_y_z
matches the -model-version=x_y_z provided as an argument.
But I don't think we need to go that far.
jonas
prev parent reply other threads:[~2024-07-29 16:06 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20240604152922.495908-1-jonas.oberhauser@huaweicloud.com>
[not found] ` <88c1ebc8-4805-4d1d-868a-889043899979@rowland.harvard.edu>
[not found] ` <bbc3bd10-3bf5-4b1a-a275-dd328c42e307@huaweicloud.com>
[not found] ` <f93f140b-13bc-4d00-adee-46cc1c016480@rowland.harvard.edu>
[not found] ` <4792c9e7-2594-3600-5d82-4cb1443fe670@huaweicloud.com>
2024-07-12 8:06 ` [PATCHv2 0/4] tools/memory-model: Define more of LKMM in tools/memory-model Hernan Ponce de Leon
2024-07-29 13:30 ` Hernan Ponce de Leon
2024-07-29 14:45 ` Jonas Oberhauser
2024-07-29 15:19 ` Hernan Ponce de Leon
2024-07-29 15:44 ` Jonas Oberhauser
2024-07-29 15:53 ` Hernan Ponce de Leon
2024-07-29 16:05 ` Jonas Oberhauser [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=76bc2c08-655c-4ca4-a573-16a98b7dd919@huaweicloud.com \
--to=jonas.oberhauser@huaweicloud.com \
--cc=akiyks@gmail.com \
--cc=boqun.feng@gmail.com \
--cc=dhowells@redhat.com \
--cc=dlustig@nvidia.com \
--cc=frederic@kernel.org \
--cc=hernan.poncedeleon@huaweicloud.com \
--cc=j.alglave@ucl.ac.uk \
--cc=joel@joelfernandes.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lkmm@lists.linux.dev \
--cc=luc.maranget@inria.fr \
--cc=npiggin@gmail.com \
--cc=parri.andrea@gmail.com \
--cc=paulmck@kernel.org \
--cc=peterz@infradead.org \
--cc=quic_neeraju@quicinc.com \
--cc=stern@rowland.harvard.edu \
--cc=urezki@gmail.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).