From: DaeRo Lee <skseofh@gmail.com>
To: Rob Herring <robh@kernel.org>
Cc: lkp@intel.com, daero_le.lee@samsung.com,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
llvm@lists.linux.dev, oe-kbuild-all@lists.linux.dev,
rppt@kernel.org, saravanak@google.com
Subject: Re: [PATCH v2] of: of_reserved_mem: clean-up reserved memory with no-map
Date: Fri, 24 May 2024 18:32:46 +0900 [thread overview]
Message-ID: <CAATEi5=pe+A8bUp=JqoMUcqQWp9uZ+4b0A92QxVRmsNj0H0ayw@mail.gmail.com> (raw)
In-Reply-To: <20240522143129.GA3244910-robh@kernel.org>
2024년 5월 22일 (수) 오후 11:31, Rob Herring <robh@kernel.org>님이 작성:
>
> On Wed, May 01, 2024 at 10:23:59PM +0900, skseofh@gmail.com wrote:
> > From: Daero Lee <daero_le.lee@samsung.com>
> >
> > In early_init_dt_reserve_memory we only add memory w/o no-map flag to
> > memblock.reserved. But we need to add memory w/ no-map flag to
> > memblock.reserved, because NOMAP and memblock.reserved are semantically
> > different.
> >
> > Signed-off-by: Daero Lee <daero_le.lee@samsung.com>
> > ---
> > drivers/of/of_reserved_mem.c | 6 +++++-
> > 1 file changed, 5 insertions(+), 1 deletion(-)
> >
> > diff --git a/drivers/of/of_reserved_mem.c b/drivers/of/of_reserved_mem.c
> > index 8236ecae2953..d00a17a9cebc 100644
> > --- a/drivers/of/of_reserved_mem.c
> > +++ b/drivers/of/of_reserved_mem.c
> > @@ -81,6 +81,7 @@ static void __init fdt_reserved_mem_save_node(unsigned long node, const char *un
> > static int __init early_init_dt_reserve_memory(phys_addr_t base,
> > phys_addr_t size, bool nomap)
> > {
> > + int err = 0;
> > if (nomap) {
> > /*
> > * If the memory is already reserved (by another region), we
> > @@ -91,7 +92,10 @@ static int __init early_init_dt_reserve_memory(phys_addr_t base,
> > memblock_is_region_reserved(base, size))
> > return -EBUSY;
> >
> > - return memblock_mark_nomap(base, size);
> > +
> > + err = memblock_mark_nomap(base, size);
>
> The last time this was touched, it was to make the handling aligned with
> EFI memory map handling. Is that still going to be the case with this
> change? Or does EFI memory map handling have the same issue?
Can I get more information about EFI memory map handling that you're saying?
1) Are you talking about uefi_mem in the reserved-memory node like below?
ex) arm64/boot/dts/qcom/qcs404.dtsi
uefi_mem: memory@9f800000 {
reg = <0 0x9f800000 0 0x800000>;
no-map;
};
2) Or, about handling EFI memory map function efi_init() -> reserve_regions()?
>
> > + if (err)
> > + return err;
> > }
> > return memblock_reserve(base, size);
> > }
> > --
> > 2.25.1
> >
prev parent reply other threads:[~2024-05-24 9:32 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20240428125505.434962-1-skseofh@gmail.com>
2024-05-01 4:59 ` [PATCH] of: of_reserved_mem: clean-up reserved memory with no-map kernel test robot
2024-05-01 13:23 ` [PATCH v2] " skseofh
2024-05-22 14:31 ` Rob Herring
2024-05-24 9:32 ` DaeRo Lee [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAATEi5=pe+A8bUp=JqoMUcqQWp9uZ+4b0A92QxVRmsNj0H0ayw@mail.gmail.com' \
--to=skseofh@gmail.com \
--cc=daero_le.lee@samsung.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lkp@intel.com \
--cc=llvm@lists.linux.dev \
--cc=oe-kbuild-all@lists.linux.dev \
--cc=robh@kernel.org \
--cc=rppt@kernel.org \
--cc=saravanak@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).