From: Luiz Augusto von Dentz <luiz.dentz@gmail.com>
To: Jiri Slaby <jirislaby@kernel.org>
Cc: Erick Archer <erick.archer@outlook.com>,
Marcel Holtmann <marcel@holtmann.org>,
Johan Hedberg <johan.hedberg@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Kees Cook <keescook@chromium.org>,
"Gustavo A. R. Silva" <gustavoars@kernel.org>,
Nathan Chancellor <nathan@kernel.org>,
Nick Desaulniers <ndesaulniers@google.com>,
Bill Wendling <morbo@google.com>,
Justin Stitt <justinstitt@google.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Geert Uytterhoeven <geert@linux-m68k.org>,
linux-bluetooth@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-hardening@vger.kernel.org,
llvm@lists.linux.dev
Subject: Re: [PATCH v2] tty: rfcomm: prefer struct_size over open coded arithmetic
Date: Mon, 13 May 2024 12:29:04 -0400 [thread overview]
Message-ID: <CABBYNZ+4CcoBvkj8ze7mZ4vVfWfm_tyBxdFspvreVASi0VR=6A@mail.gmail.com> (raw)
In-Reply-To: <d11dacfa-5925-4040-b60b-02ab731d5f1a@kernel.org>
Hi Jiri, Eric,
On Mon, May 13, 2024 at 1:07 AM Jiri Slaby <jirislaby@kernel.org> wrote:
>
> On 12. 05. 24, 13:17, Erick Archer wrote:
> > This is an effort to get rid of all multiplications from allocation
> > functions in order to prevent integer overflows [1][2].
> >
> > As the "dl" variable is a pointer to "struct rfcomm_dev_list_req" and
> > this structure ends in a flexible array:
> ...
> > --- a/include/net/bluetooth/rfcomm.h
> > +++ b/include/net/bluetooth/rfcomm.h
> ...
> > @@ -528,12 +527,12 @@ static int rfcomm_get_dev_list(void __user *arg)
> > list_for_each_entry(dev, &rfcomm_dev_list, list) {
> > if (!tty_port_get(&dev->port))
> > continue;
> > - (di + n)->id = dev->id;
> > - (di + n)->flags = dev->flags;
> > - (di + n)->state = dev->dlc->state;
> > - (di + n)->channel = dev->channel;
> > - bacpy(&(di + n)->src, &dev->src);
> > - bacpy(&(di + n)->dst, &dev->dst);
> > + di[n].id = dev->id;
> > + di[n].flags = dev->flags;
> > + di[n].state = dev->dlc->state;
> > + di[n].channel = dev->channel;
> > + bacpy(&di[n].src, &dev->src);
> > + bacpy(&di[n].dst, &dev->dst);
>
> This does not relate much to "prefer struct_size over open coded
> arithmetic". It should have been in a separate patch.
+1, please split these changes into its own patch so we can apply it separately.
> Other than that, LGTM.
>
> thanks,
> --
> js
> suse labs
>
--
Luiz Augusto von Dentz
next prev parent reply other threads:[~2024-05-13 16:29 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-12 11:17 [PATCH v2] tty: rfcomm: prefer struct_size over open coded arithmetic Erick Archer
2024-05-13 3:03 ` Kees Cook
2024-05-13 5:07 ` Jiri Slaby
2024-05-13 16:29 ` Luiz Augusto von Dentz [this message]
2024-05-13 17:12 ` Erick Archer
2024-05-13 18:51 ` Kees Cook
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CABBYNZ+4CcoBvkj8ze7mZ4vVfWfm_tyBxdFspvreVASi0VR=6A@mail.gmail.com' \
--to=luiz.dentz@gmail.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=erick.archer@outlook.com \
--cc=geert@linux-m68k.org \
--cc=gregkh@linuxfoundation.org \
--cc=gustavoars@kernel.org \
--cc=jirislaby@kernel.org \
--cc=johan.hedberg@gmail.com \
--cc=justinstitt@google.com \
--cc=keescook@chromium.org \
--cc=kuba@kernel.org \
--cc=linux-bluetooth@vger.kernel.org \
--cc=linux-hardening@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=llvm@lists.linux.dev \
--cc=marcel@holtmann.org \
--cc=morbo@google.com \
--cc=nathan@kernel.org \
--cc=ndesaulniers@google.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).