From: Andreas Werner <andreas.werner@men.de>
To: Guenter Roeck <linux@roeck-us.net>
Cc: Jean Delvare <jdelvare@suse.de>,
Andreas Werner <andreas.werner@men.de>,
wni@nvidia.com, lm-sensors@lm-sensors.org,
linux-kernel@vger.kernel.org
Subject: Re: [lm-sensors] LM90 driver and ti tmp461 detection
Date: Fri, 18 Dec 2015 08:18:05 +0000 [thread overview]
Message-ID: <20151218081805.GC2349@awelinux> (raw)
In-Reply-To: <20151217145751.GA21030@roeck-us.net>
On Thu, Dec 17, 2015 at 06:57:51AM -0800, Guenter Roeck wrote:
> On Thu, Dec 17, 2015 at 12:48:08PM +0100, Jean Delvare wrote:
> > Hi Andreas,
> >
> > On Tue, 15 Dec 2015 16:11:24 +0100, Andreas Werner wrote:
> > > here is the register dump of the tmp461.
> >
> > Thanks.
> >
> > > It seemse that we really cannot detect if it is a tmp461 or a tmp451.
> > > Also the magic "ID Register" offset 0xff is 0x00 for both devices.
> >
> > I would use register 0x16, which doesn't exist but reads 0x00 on the
> > TMP451. It could in theory also read 0x00 on the TMP461 but only if
> > both channels are disabled, which makes little sense. More likely at
> > least one channel will be enabled so you'll have value 0x01-0x03 if
> > this is a TMP461.
> >
> Excellent idea!
>
> Guenter
Ok, i will implement the detection for the tm461 and also the temp calculation
for setting the temperature value.
Will send a patch as soon as i am done.
Regards
Andy
_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
next prev parent reply other threads:[~2015-12-18 8:18 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-10 12:08 [lm-sensors] LM90 driver and ti tmp461 detection Andreas Werner
[not found] ` <5669AB55.5030309@roeck-us.net>
2015-12-10 17:12 ` Andreas Werner
[not found] ` <5669B9D9.9050908@roeck-us.net>
2015-12-10 18:03 ` Andreas Werner
[not found] ` <5669BB37.3050207@roeck-us.net>
2015-12-10 18:09 ` Andreas Werner
2015-12-12 10:08 ` Jean Delvare
2015-12-15 15:11 ` Andreas Werner
2015-12-17 11:48 ` Jean Delvare
2015-12-17 11:54 ` Andreas Werner
2015-12-17 14:57 ` Guenter Roeck
2015-12-18 8:18 ` Andreas Werner [this message]
2015-12-12 11:42 ` Andreas Werner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151218081805.GC2349@awelinux \
--to=andreas.werner@men.de \
--cc=jdelvare@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=lm-sensors@lm-sensors.org \
--cc=wni@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).