From: Gi-Oh Kim <gi-oh.kim@profitbricks.com>
To: Huang Rui <ray.huang@amd.com>
Cc: Guenter Roeck <linux@roeck-us.net>,
"lm-sensors@lm-sensors.org" <lm-sensors@lm-sensors.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Borislav Petkov <bp@alien8.de>
Subject: Re: [lm-sensors] [RFC] hwmon: (fam15h_power) Add bit masking for tdp_limit
Date: Wed, 27 Jan 2016 10:36:33 +0000 [thread overview]
Message-ID: <56A89DB1.2000200@profitbricks.com> (raw)
In-Reply-To: <20160127064537.GA25036@hr-amur2>
On 27.01.2016 07:45, Huang Rui wrote:
> On Tue, Jan 26, 2016 at 11:57:35AM +0100, Gi-Oh Kim wrote:
>>
>> On 26.01.2016 03:25, Huang Rui wrote:
>>> On Mon, Jan 25, 2016 at 07:41:07PM +0800, Gioh Kim wrote:
>> Thanks for your reply.
>> I'm not completely sure that the reserved bits are always zero.
>> Are they always zero?
>> Or do we need bit-masking like following?
>>
> Reserved bits aren't always zero. But here they are reserved for
> ApmTdpLimit expansion.
>
> Yes, we would better add bit-masking here. :-)
>
>> -------------- 8< -----------------
>> Subject: [PATCH] hwmon: (fam15h_power) Add bit masking for tdp_limit
>>
>> Add bit masking to read ApmTdpLimit precisely
>>
>> Signed-off-by: Gioh Kim <gi-oh.kim@profitbricks.com>
>> ---
>> drivers/hwmon/fam15h_power.c | 6 +++++-
>> 1 file changed, 5 insertions(+), 1 deletion(-)
>>
>> diff --git a/drivers/hwmon/fam15h_power.c b/drivers/hwmon/fam15h_power.c
>> index f77eb97..edbcf6c 100644
>> --- a/drivers/hwmon/fam15h_power.c
>> +++ b/drivers/hwmon/fam15h_power.c
>> @@ -90,7 +90,11 @@ static ssize_t show_power(struct device *dev,
>> pci_bus_read_config_dword(f4->bus, PCI_DEVFN(PCI_SLOT(f4->devfn), 5),
>> REG_TDP_LIMIT3, &val);
>>
>> - tdp_limit = val >> 16;
>> + if (boot_cpu_data.x86_model >= 0x60)
>> + tdp_limit = val >> 16;
> You need add CPU family check and a comment to mention bit field
> change. This updates since family 15h and model 60h.
>
> if (boot_cpu_data.x86 = 0x15 && boot_cpu_data.x86_model >= 0x60)
I'm going to send a formal patch.
Thank you.
>
> Thanks,
> Rui
--
Best regards,
Gi-Oh Kim
_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
prev parent reply other threads:[~2016-01-27 10:36 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-25 11:41 [lm-sensors] [RFC] hwmon: (fam15h_power) Add bit masking for tdp_limit Gioh Kim
2016-01-26 2:25 ` Huang Rui
2016-01-26 2:43 ` Guenter Roeck
2016-01-26 10:57 ` Gi-Oh Kim
2016-01-27 6:45 ` Huang Rui
2016-01-27 10:36 ` Gi-Oh Kim [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56A89DB1.2000200@profitbricks.com \
--to=gi-oh.kim@profitbricks.com \
--cc=bp@alien8.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=lm-sensors@lm-sensors.org \
--cc=ray.huang@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).