* Re: [lm-sensors] Missing Code v4.5-rc1 [Patch v3 25/25] IT8628E
2016-02-27 14:21 [lm-sensors] Missing Code v4.5-rc1 [Patch v3 25/25] IT8628E Sardaukai
@ 2016-02-27 18:55 ` Guenter Roeck
2016-02-28 16:59 ` Sardaukai
2016-02-28 17:37 ` Guenter Roeck
2 siblings, 0 replies; 4+ messages in thread
From: Guenter Roeck @ 2016-02-27 18:55 UTC (permalink / raw
To: lm-sensors
Hi,
On 02/27/2016 06:21 AM, Sardaukai wrote:
> Hello everyone
>
> i have some questions about chip support cause my main-board uses the IT8628E.
> I saw a patch that these chip should work. So i decided to give it a try.
>
Seeing a patch on a mailing list doesn't mean it is upstream. In this case it isn't.
> Normally sensors-detect works with my cpu, with the kernel-rc it did not.
> If i skip that, the ITE is also not found.
>
> -------------------------------------------
> # sensors-detect revision 6284 (2015-05-31 14:00:33 +0200)
> # System: Gigabyte Technology Co., Ltd. Z170X-UD3
> # Board: Gigabyte Technology Co., Ltd. Z170X-UD3-CF
> # Kernel: 4.5.0-rc5 x86_64
> # Processor: Intel(R) Core(TM) i7-6700K CPU @ 4.00GHz (6/94/3)
>
> This program will help you determine which kernel modules you need
> to load to use lm_sensors most effectively. It is generally safe
> and recommended to accept the default answers to all questions,
> unless you know what you're doing.
>
> Some south bridges, CPUs or memory controllers contain embedded sensors.
> Do you want to scan for them? This is totally safe. (YES/no): Yes
> Module cpuid loaded successfully.
> Silicon Integrated Systems SIS5595... No
> VIA VT82C686 Integrated Sensors... No
> VIA VT8231 Integrated Sensors... No
> AMD K8 thermal sensors... No
> AMD Family 10h thermal sensors... No
> AMD Family 11h thermal sensors... No
> AMD Family 12h and 14h thermal sensors... No
> AMD Family 15h thermal sensors... No
> AMD Family 16h thermal sensors... No
> AMD Family 15h power sensors... No
> AMD Family 16h power sensors... No
> Intel digital thermal sensor... Cannot seek /dev/cpu/0/cpuid at /usr/sbin/sensors-detect line 6820.
>
Maybe something changed in the ABI, though that would be unusual.
We'll have to check.
> Some Super I/O chips contain embedded sensors. We have to write to
> standard I/O ports to probe them. This is usually safe.
> Do you want to scan for Super I/O sensors? (YES/no): y
> Probing for Super-I/O at 0x2e/0x2f
> Trying family `National Semiconductor/ITE'... No
> Trying family `SMSC'... No
> Trying family `VIA/Winbond/Nuvoton/Fintek'... No
> Trying family `ITE'... Yes
> Found unknown chip with ID 0x8628
That just means that your version of sensors-detect doesn't know
about the chip.
> Probing for Super-I/O at 0x4e/0x4f
> Trying family `National Semiconductor/ITE'... No
> Trying family `SMSC'... No
> Trying family `VIA/Winbond/Nuvoton/Fintek'... No
> Trying family `ITE'... No
> ------------------------------------------------
>
> In addition i searched drivers/hwmon/it87.c in order to find the patched code from kernel 4.5-rc5.
> Unfortunately i found no code changes from Patch v3 (i tested about 5 patches).
> Should it not be patched within 4.5-rc1 or do i miss here something?
>
Does it say anywhere that the patches were reviewed and/or accepted
for upstream integration ?
Problem is that there is hardly anyone willing to review hwmon kernel
patches nowadays, meaning they have to go in unreviewed or not at all.
Given the complexity and scope of the series, I don't want to just push
the patches into the upstream kernel without review. With that in mind,
it may take a while for the code to be upstream.
> Second question
> Is it possible to take your code from github to patch/replace it in another kernel, like 4.3 / 4.4 ?
>
Yes, that should be possible. I have been running it on earlier kernels
myself.
Guenter
_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [lm-sensors] Missing Code v4.5-rc1 [Patch v3 25/25] IT8628E
2016-02-27 14:21 [lm-sensors] Missing Code v4.5-rc1 [Patch v3 25/25] IT8628E Sardaukai
2016-02-27 18:55 ` Guenter Roeck
@ 2016-02-28 16:59 ` Sardaukai
2016-02-28 17:37 ` Guenter Roeck
2 siblings, 0 replies; 4+ messages in thread
From: Sardaukai @ 2016-02-28 16:59 UTC (permalink / raw
To: lm-sensors
Small Update
> ...
>> In addition i searched drivers/hwmon/it87.c in order to find the
>> patched code from kernel 4.5-rc5.
>> Unfortunately i found no code changes from Patch v3 (i tested about 5
>> patches).
>> Should it not be patched within 4.5-rc1 or do i miss here something?
>>
> Does it say anywhere that the patches were reviewed and/or accepted
> for upstream integration ?
>
> Problem is that there is hardly anyone willing to review hwmon kernel
> patches nowadays, meaning they have to go in unreviewed or not at all.
> Given the complexity and scope of the series, I don't want to just push
> the patches into the upstream kernel without review. With that in mind,
> it may take a while for the code to be upstream.
>
I see. You wrote that it should go up with rc-1, so i thought it is
already there, my mistake.
>> Second question
>> Is it possible to take your code from github to patch/replace it in
>> another kernel, like 4.3 / 4.4 ?
>>
> Yes, that should be possible. I have been running it on earlier kernels
> myself.
With GitHub module code for it87 chip's and a boot parameter
"acpi_enforce_resources=lax"
i was able to load it.
it8628-isa-0a40
Adapter: ISA adapter
in0: +0.43 V (min = +0.00 V, max = +3.06 V) <--- seems
to be VCore, tested with cpuBurn
in1: +2.04 V (min = +0.00 V, max = +3.06 V)
in2: +2.00 V (min = +0.00 V, max = +3.06 V)
in3: +2.04 V (min = +0.00 V, max = +3.06 V)
in4: +0.01 V (min = +0.00 V, max = +3.06 V)
in5: +1.07 V (min = +0.00 V, max = +3.06 V)
in6: +1.20 V (min = +0.00 V, max = +3.06 V) <--- could
be RAM Voltage
3VSB: +3.36 V (min = +0.00 V, max = +6.12 V)
Vbat: +3.17 V <--- Battery Voltage from EFI, really?!
fan1: 0 RPM (min = 0 RPM) <--- CPU_FAN not connected
fan2: 2280 RPM (min = 0 RPM) <--- CPU_OPT (my H80i pump)
fan3: 1078 RPM (min = 0 RPM) <--- SYS_FAN3 or 2 (radiator fan)
fan4: 0 RPM (min = 0 RPM) <--- SYS_FAN1 not connected
fan5: 1819 RPM (min = 0 RPM) <--- SYS_FAN2 or 3 (radiator fan #2)
temp1: +43.0°C (low = +127.0°C, high = +127.0°C) sensor =
thermistor
temp2: -8.0°C (low = +127.0°C, high = +127.0°C) sensor =
thermistor
temp3: +22.0°C (low = +127.0°C, high = +127.0°C) sensor =
Intel PECI
intrusion0: OK <--- Nice, i have to check where and how
to use that
Kernel 4.3.5 with Debian Testing (Stretch)
sensors version 3.4.0 with libsensors version 3.4.0
fancontrol 3.4.0-2
I'll try to get that names step by step. Further i tried fancontrol, i
got funny stuff with fan5.
It seems to be that PWM values from fan5 are inverted.
Following fancontrol setting stops all fans.
# Configuration file generated by pwmconfig, changes will be lost
INTERVAL=10
DEVPATH=hwmon2=devices/platform/it87.2624
DEVNAME=hwmon2=it8628
FCTEMPS=hwmon2/pwm5=hwmon2/temp3_input hwmon2/pwm3=hwmon2/temp3_input
FCFANS=hwmon2/pwm5=hwmon2/fan5_input hwmon2/pwm3=hwmon2/fan3_input
MINTEMP=hwmon2/pwm5=20 hwmon2/pwm3=20
MAXTEMP=hwmon2/pwm5=60 hwmon2/pwm3=60
MINSTOP=hwmon2/pwm3=1 hwmon2/pwm5=254
MINSTART=hwmon2/pwm3=1 hwmon2/pwm5=255
MINPWM=hwmon2/pwm3=0 hwmon2/pwm5=254
MAXPWM=hwmon2/pwm3=2 hwmon2/pwm5=255
I tried some different EFI settings with system fans (Silent, Normal,
PWM per degree) without
any changes. Fan3 works out of the box. I will check all other fans soon.
Any idea how to fix that?
Uwe
_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [lm-sensors] Missing Code v4.5-rc1 [Patch v3 25/25] IT8628E
2016-02-27 14:21 [lm-sensors] Missing Code v4.5-rc1 [Patch v3 25/25] IT8628E Sardaukai
2016-02-27 18:55 ` Guenter Roeck
2016-02-28 16:59 ` Sardaukai
@ 2016-02-28 17:37 ` Guenter Roeck
2 siblings, 0 replies; 4+ messages in thread
From: Guenter Roeck @ 2016-02-28 17:37 UTC (permalink / raw
To: lm-sensors
On 02/28/2016 08:59 AM, Sardaukai wrote:
> Small Update
>> ...
>>> In addition i searched drivers/hwmon/it87.c in order to find the patched code from kernel 4.5-rc5.
>>> Unfortunately i found no code changes from Patch v3 (i tested about 5 patches).
>>> Should it not be patched within 4.5-rc1 or do i miss here something?
>>>
>> Does it say anywhere that the patches were reviewed and/or accepted
>> for upstream integration ?
>>
>> Problem is that there is hardly anyone willing to review hwmon kernel
>> patches nowadays, meaning they have to go in unreviewed or not at all.
>> Given the complexity and scope of the series, I don't want to just push
>> the patches into the upstream kernel without review. With that in mind,
>> it may take a while for the code to be upstream.
>>
> I see. You wrote that it should go up with rc-1, so i thought it is already there, my mistake.
>>> Second question
>>> Is it possible to take your code from github to patch/replace it in another kernel, like 4.3 / 4.4 ?
>>>
>> Yes, that should be possible. I have been running it on earlier kernels
>> myself.
>
> With GitHub module code for it87 chip's and a boot parameter "acpi_enforce_resources=lax"
> i was able to load it.
>
> it8628-isa-0a40
> Adapter: ISA adapter
> in0: +0.43 V (min = +0.00 V, max = +3.06 V) <--- seems to be VCore, tested with cpuBurn
> in1: +2.04 V (min = +0.00 V, max = +3.06 V)
> in2: +2.00 V (min = +0.00 V, max = +3.06 V)
> in3: +2.04 V (min = +0.00 V, max = +3.06 V)
> in4: +0.01 V (min = +0.00 V, max = +3.06 V)
> in5: +1.07 V (min = +0.00 V, max = +3.06 V)
> in6: +1.20 V (min = +0.00 V, max = +3.06 V) <--- could be RAM Voltage
> 3VSB: +3.36 V (min = +0.00 V, max = +6.12 V)
> Vbat: +3.17 V <--- Battery Voltage from EFI, really?!
> fan1: 0 RPM (min = 0 RPM) <--- CPU_FAN not connected
> fan2: 2280 RPM (min = 0 RPM) <--- CPU_OPT (my H80i pump)
> fan3: 1078 RPM (min = 0 RPM) <--- SYS_FAN3 or 2 (radiator fan)
> fan4: 0 RPM (min = 0 RPM) <--- SYS_FAN1 not connected
> fan5: 1819 RPM (min = 0 RPM) <--- SYS_FAN2 or 3 (radiator fan #2)
> temp1: +43.0°C (low = +127.0°C, high = +127.0°C) sensor = thermistor
> temp2: -8.0°C (low = +127.0°C, high = +127.0°C) sensor = thermistor
> temp3: +22.0°C (low = +127.0°C, high = +127.0°C) sensor = Intel PECI
> intrusion0: OK <--- Nice, i have to check where and how to use that
>
If it is connected. On most motherboards it isn't.
> Kernel 4.3.5 with Debian Testing (Stretch)
> sensors version 3.4.0 with libsensors version 3.4.0
> fancontrol 3.4.0-2
>
> I'll try to get that names step by step. Further i tried fancontrol, i got funny stuff with fan5.
> It seems to be that PWM values from fan5 are inverted.
>
> Following fancontrol setting stops all fans.
>
> # Configuration file generated by pwmconfig, changes will be lost
> INTERVAL=10
> DEVPATH=hwmon2=devices/platform/it87.2624
> DEVNAME=hwmon2=it8628
> FCTEMPS=hwmon2/pwm5=hwmon2/temp3_input hwmon2/pwm3=hwmon2/temp3_input
> FCFANS=hwmon2/pwm5=hwmon2/fan5_input hwmon2/pwm3=hwmon2/fan3_input
> MINTEMP=hwmon2/pwm5=20 hwmon2/pwm3=20
> MAXTEMP=hwmon2/pwm5=60 hwmon2/pwm3=60
> MINSTOP=hwmon2/pwm3=1 hwmon2/pwm5=254
> MINSTART=hwmon2/pwm3=1 hwmon2/pwm5=255
> MINPWM=hwmon2/pwm3=0 hwmon2/pwm5=254
> MAXPWM=hwmon2/pwm3=2 hwmon2/pwm5=255
>
> I tried some different EFI settings with system fans (Silent, Normal, PWM per degree) without
> any changes. Fan3 works out of the box. I will check all other fans soon.
> Any idea how to fix that?
>
Sorry, no.
I prefer to stick with automatic fan control; I consider it to be less risky,
since it keeps working even if the user space code fails. the Super-IO chips usually
to a pretty good job.
Guenter
_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
^ permalink raw reply [flat|nested] 4+ messages in thread