From: "Ondřej Lysoněk" <olysonek@redhat.com>
To: lm-sensors@vger.kernel.org
Subject: Re: [PATCH v3] Add ISA ACPI sensor driver name support
Date: Thu, 20 Aug 2020 16:36:39 +0000 [thread overview]
Message-ID: <fls8se98eaw.fsf@redhat.com> (raw)
In-Reply-To: <1597276920-28290-1-git-send-email-Hoan@os.amperecomputing.com>
Hoan Tran <Hoan@os.amperecomputing.com> writes:
> From: Hoan Tran <hoan.tran@amperecomputing.com>
>
> ACPI hwmon sensor driver name has a different format such as
> APMC0D29:00
> APMC0D29:01
> compared with DTB. This patch supports this format and gives
> the correct device address as below
>
> apm_xgene-isa-0000 => APMC0D29:00
> Adapter: ISA adapter
> SoC Temperature: +35.0°C
> CPU power: 11.00 W
> IO power: 20.00 W
>
> apm_xgene-isa-0001 => APMC0D29:01
> Adapter: ISA adapter
> SoC Temperature: +33.0°C
> CPU power: 13.00 W
> IO power: 23.83 W
>
> Signed-off-by: Hoan Tran <hoan@os.amperecomputing.com>
> ---
> v3:
> Filter for single '.' or ':'
> v2:
> Filter A-Z for the name
>
> lib/sysfs.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/lib/sysfs.c b/lib/sysfs.c
> index e63688b7..9516cec4 100644
> --- a/lib/sysfs.c
> +++ b/lib/sysfs.c
> @@ -663,7 +663,7 @@ static int classify_device(const char *dev_name,
> if ((!subsys || !strcmp(subsys, "platform") ||
> !strcmp(subsys, "of_platform"))) {
> /* must be new ISA (platform driver) */
> - if (sscanf(dev_name, "%*[a-z0-9_].%d", &entry->chip.addr) != 1)
> + if (sscanf(dev_name, "%*[a-zA-Z0-9_]%*1[.:]%d", &entry->chip.addr) != 1)
> entry->chip.addr = 0;
> entry->chip.bus.type = SENSORS_BUS_TYPE_ISA;
> entry->chip.bus.nr = 0;
> @@ -938,7 +938,7 @@ int sensors_read_sysfs_attr(const sensors_chip_name *name,
> if (res == EOF) {
> if (errno == EIO)
> return -SENSORS_ERR_IO;
> - else
> + else
> return -SENSORS_ERR_ACCESS_R;
> }
> *value /= get_type_scaling(subfeature->type);
> @@ -972,7 +972,7 @@ int sensors_write_sysfs_attr(const sensors_chip_name *name,
> if (res == EOF) {
> if (errno == EIO)
> return -SENSORS_ERR_IO;
> - else
> + else
> return -SENSORS_ERR_ACCESS_W;
> }
> } else
> --
> 2.24.2
Applied. Thanks a lot!
Ondřej
prev parent reply other threads:[~2020-08-20 16:36 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-13 0:02 [PATCH v3] Add ISA ACPI sensor driver name support Hoan Tran
2020-08-20 16:36 ` Ondřej Lysoněk [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fls8se98eaw.fsf@redhat.com \
--to=olysonek@redhat.com \
--cc=lm-sensors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).