From: Qiang Ma <maqianga@uniontech.com>
To: Huacai Chen <chenhuacai@kernel.org>
Cc: kernel@xen0n.name, loongarch@lists.linux.dev,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] LoongArch: Correct the definitions related to CSR_CPUID_COREID{_WIDTH}
Date: Tue, 28 Apr 2026 21:16:28 +0800 [thread overview]
Message-ID: <56FA25D1E5889E46+22ae8ce8-3fa0-4c4e-86cc-a78c48c29b78@uniontech.com> (raw)
In-Reply-To: <CAAhV-H5O-V73k10h6d_w=QhKHDPJBXOuCkpDESTEechHEsa6Yg@mail.gmail.com>
在 2026/4/28 20:47, Huacai Chen 写道:
> Can you do some investigation about the history before coding?
> 9559d5806319a9254d9053b22a31324e1929aac ("LoongArch: Increase max
> supported CPUs up to 2048")
Uh, uh, uh, my fault. I'll be more careful next time. Besides the
document, there's also the code history submission.
>
> Huacai
>
> On Tue, Apr 28, 2026 at 8:36 PM Qiang Ma <maqianga@uniontech.com> wrote:
>> The valid bits of CPU Identity (CPUID) are 0 to 8
>> according to LoongArch Reference Manual, so change
>> 11 to 9 for the related code.
>>
>> Link: https://loongson.github.io/LoongArch-Documentation/LoongArch-Vol1-EN.html#cpu-identity
>>
>> Signed-off-by: Qiang Ma <maqianga@uniontech.com>
>> ---
>> arch/loongarch/include/asm/loongarch.h | 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/arch/loongarch/include/asm/loongarch.h b/arch/loongarch/include/asm/loongarch.h
>> index 2a6bc99177d8..bc47df90fee6 100644
>> --- a/arch/loongarch/include/asm/loongarch.h
>> +++ b/arch/loongarch/include/asm/loongarch.h
>> @@ -429,8 +429,8 @@
>>
>> /* Config CSR registers */
>> #define LOONGARCH_CSR_CPUID 0x20 /* CPU core id */
>> -#define CSR_CPUID_COREID_WIDTH 11
>> -#define CSR_CPUID_COREID _ULCAST_(0x7ff)
>> +#define CSR_CPUID_COREID_WIDTH 9
>> +#define CSR_CPUID_COREID _ULCAST_(0x1ff)
>>
>> #define LOONGARCH_CSR_PRCFG1 0x21 /* Config1 */
>> #define CSR_CONF1_VSMAX_SHIFT 12
>> --
>> 2.20.1
>>
prev parent reply other threads:[~2026-04-28 13:16 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-28 12:35 [PATCH] LoongArch: Correct the definitions related to CSR_CPUID_COREID{_WIDTH} Qiang Ma
2026-04-28 12:47 ` Huacai Chen
2026-04-28 13:16 ` Qiang Ma [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56FA25D1E5889E46+22ae8ce8-3fa0-4c4e-86cc-a78c48c29b78@uniontech.com \
--to=maqianga@uniontech.com \
--cc=chenhuacai@kernel.org \
--cc=kernel@xen0n.name \
--cc=linux-kernel@vger.kernel.org \
--cc=loongarch@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).