From: Binbin Zhou <zhoubb.aaron@gmail.com>
To: Andi Shyti <andi.shyti@kernel.org>
Cc: Binbin Zhou <zhoubinbin@loongson.cn>,
Huacai Chen <chenhuacai@loongson.cn>,
Wolfram Sang <wsa+renesas@sang-engineering.com>,
Andy Shevchenko <andy@kernel.org>,
linux-i2c@vger.kernel.org, Huacai Chen <chenhuacai@kernel.org>,
Xuerui Wang <kernel@xen0n.name>,
loongarch@lists.linux.dev
Subject: Re: [PATCH v6 2/2] i2c: ls2x-v2: Add driver for Loongson-2K0300 I2C controller
Date: Fri, 10 Apr 2026 09:33:12 +0800 [thread overview]
Message-ID: <CAMpQs4KYDVJnok5UfPJb3b=WR6u3OTdps+976YOox9dAFKkEcg@mail.gmail.com> (raw)
In-Reply-To: <adfMBWyDh27NRe0T@zenone.zhora.eu>
Hi Andi:
Thanks for your review.
On Thu, Apr 9, 2026 at 11:57 PM Andi Shyti <andi.shyti@kernel.org> wrote:
>
> Hi Binbin,
>
> > +config I2C_LS2X_V2
> > + tristate "Loongson-2 Fast Speed I2C adapter"
> > + depends on LOONGARCH || COMPILE_TEST
> > + help
>
> I'm getting a compile error here, I guess you also need
> REGMAP_MMIO here, right?
Yes, that is indeed necessary. I’ll double-check to see if there are
any other omissions.
It seems my other driver has a similar omission as well. Thank you very much.
>
> Andi
--
Thanks.
Binbin
next prev parent reply other threads:[~2026-04-10 1:33 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-20 7:25 [PATCH v6 0/2] i2c: Add Loongson-2K0300 I2C controller support Binbin Zhou
2026-03-20 7:25 ` [PATCH v6 1/2] dt-bindings: i2c: loongson,ls2x: Add ls2k0300-i2c compatible Binbin Zhou
2026-03-20 7:25 ` [PATCH v6 2/2] i2c: ls2x-v2: Add driver for Loongson-2K0300 I2C controller Binbin Zhou
2026-03-20 8:41 ` Andy Shevchenko
2026-04-09 15:57 ` Andi Shyti
2026-04-10 1:33 ` Binbin Zhou [this message]
2026-03-27 2:50 ` [PATCH v6 0/2] i2c: Add Loongson-2K0300 I2C controller support Huacai Chen
2026-04-09 8:19 ` Binbin Zhou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAMpQs4KYDVJnok5UfPJb3b=WR6u3OTdps+976YOox9dAFKkEcg@mail.gmail.com' \
--to=zhoubb.aaron@gmail.com \
--cc=andi.shyti@kernel.org \
--cc=andy@kernel.org \
--cc=chenhuacai@kernel.org \
--cc=chenhuacai@loongson.cn \
--cc=kernel@xen0n.name \
--cc=linux-i2c@vger.kernel.org \
--cc=loongarch@lists.linux.dev \
--cc=wsa+renesas@sang-engineering.com \
--cc=zhoubinbin@loongson.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).