From: Bibo Mao <maobibo@loongson.cn>
To: Huacai Chen <chenhuacai@loongson.cn>,
Paolo Bonzini <pbonzini@redhat.com>,
Huacai Chen <chenhuacai@kernel.org>,
Tianrui Zhao <zhaotianrui@loongson.cn>
Cc: kvm@vger.kernel.org, loongarch@lists.linux.dev,
linux-kernel@vger.kernel.org, Xuerui Wang <kernel@xen0n.name>,
Jiaxun Yang <jiaxun.yang@flygoat.com>,
stable@vger.kernel.org, Aurelien Jarno <aurel32@debian.org>
Subject: Re: [PATCH 2/2] LoongArch: KVM: Handle the case that EIOINTC's coremap is empty
Date: Mon, 23 Mar 2026 11:14:04 +0800 [thread overview]
Message-ID: <faf3a249-4290-8d91-8a28-738af28032c1@loongson.cn> (raw)
In-Reply-To: <20260322135346.3720577-2-chenhuacai@loongson.cn>
On 2026/3/22 下午9:53, Huacai Chen wrote:
> EIOINTC's coremap in eiointc_update_sw_coremap() can be empty, currently
> we get a cpuid with -1 in this case, but we actually need 0 because it's
> similar as the case that cpuid >= 4.
>
> This fix an out-of-bounds access to kvm_arch::phyid_map::phys_map[].
>
> Cc: <stable@vger.kernel.org>
> Fixes: 3956a52bc05bd81 ("LoongArch: KVM: Add EIOINTC read and write functions")
> Reported-by: Aurelien Jarno <aurel32@debian.org>
> Link: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1131431
> Signed-off-by: Huacai Chen <chenhuacai@loongson.cn>
> ---
> arch/loongarch/kvm/intc/eiointc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/loongarch/kvm/intc/eiointc.c b/arch/loongarch/kvm/intc/eiointc.c
> index d2acb4d09e73..c7badc813923 100644
> --- a/arch/loongarch/kvm/intc/eiointc.c
> +++ b/arch/loongarch/kvm/intc/eiointc.c
> @@ -83,7 +83,7 @@ static inline void eiointc_update_sw_coremap(struct loongarch_eiointc *s,
>
> if (!(s->status & BIT(EIOINTC_ENABLE_CPU_ENCODE))) {
> cpuid = ffs(cpuid) - 1;
> - cpuid = (cpuid >= 4) ? 0 : cpuid;
> + cpuid = ((cpuid < 0) || (cpuid >= 4)) ? 0 : cpuid;
> }
>
> vcpu = kvm_get_vcpu_by_cpuid(s->kvm, cpuid);
>
Reviewed-by: Bibo Mao <maobibo@loongson.cn>
next prev parent reply other threads:[~2026-03-23 3:16 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-22 13:53 [PATCH 1/2] LoongArch: KVM: Make kvm_get_vcpu_by_cpuid() more robust Huacai Chen
2026-03-22 13:53 ` [PATCH 2/2] LoongArch: KVM: Handle the case that EIOINTC's coremap is empty Huacai Chen
2026-03-23 3:14 ` Bibo Mao [this message]
2026-03-23 3:13 ` [PATCH 1/2] LoongArch: KVM: Make kvm_get_vcpu_by_cpuid() more robust Bibo Mao
2026-03-23 7:08 ` Huacai Chen
2026-03-23 7:56 ` Bibo Mao
2026-03-23 8:08 ` Bibo Mao
2026-03-23 8:14 ` Huacai Chen
2026-03-23 9:40 ` Bibo Mao
2026-03-23 18:36 ` Aurelien Jarno
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=faf3a249-4290-8d91-8a28-738af28032c1@loongson.cn \
--to=maobibo@loongson.cn \
--cc=aurel32@debian.org \
--cc=chenhuacai@kernel.org \
--cc=chenhuacai@loongson.cn \
--cc=jiaxun.yang@flygoat.com \
--cc=kernel@xen0n.name \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=loongarch@lists.linux.dev \
--cc=pbonzini@redhat.com \
--cc=stable@vger.kernel.org \
--cc=zhaotianrui@loongson.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).