($INBOX_DIR/description missing)
 help / color / mirror / Atom feed

* [LTP] [PATCH 1/2] tst_net.sh: tst_ping(): check for ping -I support
@ 2024-03-30 18:08 Petr Vorel
  2024-03-30 18:08 ` [LTP] [PATCH 2/2] network/README: Document ping dependencies Petr Vorel
  0 siblings, 1 reply; 2+ messages in thread
From: Petr Vorel @ 2024-03-30 18:08 UTC (permalink / raw
  To: ltp; +Cc: Xiangyu Chen

tst_ping() may require ping -I support, which is not supported by
ping from inetutils.

Link: https://github.com/linux-test-project/ltp/pull/1149#issuecomment-2027947024
Reported-by: Xiangyu Chen <xiangyu.chen@windriver.com>
Signed-off-by: Petr Vorel <pvorel@suse.cz>
---
 testcases/lib/tst_net.sh | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/testcases/lib/tst_net.sh b/testcases/lib/tst_net.sh
index 6cf7f2fcb..ee0ae1cad 100644
--- a/testcases/lib/tst_net.sh
+++ b/testcases/lib/tst_net.sh
@@ -928,7 +928,10 @@ tst_ping()
 		c) ping_count="$OPTARG";;
 		s) msg_sizes="$OPTARG";;
 		p) pattern_opt="-p $OPTARG";;
-		I) src_iface="$OPTARG";;
+		I) src_iface="$OPTARG"
+		   tst_ping_opt_unsupported -I $OPTARG && \
+			   tst_brk_ TCONF "unsupported ping version (ping from inetutils?)"
+		   ;;
 		H) dst_addr="$OPTARG";;
 		*) tst_brk_ TBROK "tst_ping: unknown option: $OPTARG";;
 		esac
-- 
2.43.0


-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

^ permalink raw reply related	[flat|nested] 2+ messages in thread

• * [LTP] [PATCH 2/2] network/README: Document ping dependencies
    2024-03-30 18:08 [LTP] [PATCH 1/2] tst_net.sh: tst_ping(): check for ping -I support Petr Vorel
  @ 2024-03-30 18:08 ` Petr Vorel
    0 siblings, 0 replies; 2+ messages in thread
  From: Petr Vorel @ 2024-03-30 18:08 UTC (permalink / raw
    To: ltp
  
  Signed-off-by: Petr Vorel <pvorel@suse.cz>
  ---
   testcases/network/README.md | 7 +++++++
   1 file changed, 7 insertions(+)
  
  diff --git a/testcases/network/README.md b/testcases/network/README.md
  index e1b1296d6..0b64df01e 100644
  --- a/testcases/network/README.md
  +++ b/testcases/network/README.md
  @@ -88,6 +88,13 @@ Tests which use `tst_netload_compare()` test also performance. They can fail on
   overloaded SUT.  To ignore performance failure and test only the network functionality,
   set `LTP_NET_FEATURES_IGNORE_PERFORMANCE_FAILURE=1` environment variable.
   
  +## Dependencies
  +
  +Some network tests which use `tst_ping()` function require `ping` with `-I` support,
  +which is not supported by `ping` from [inetutils](https://www.gnu.org/software/inetutils/).
  +Use `ping` from [iputils](https://github.com/iputils/iputils/) or from [BusyBox](https://busybox.net/)
  +(configured with `CONFIG_FEATURE_IPV6=y` `CONFIG_FEATURE_FANCY_PING=y`).
  +
   ## Debugging
   Both single and two host configurations support debugging via
   `TST_NET_RHOST_RUN_DEBUG=1` environment variable.
  -- 
  2.43.0
  
  
  -- 
  Mailing list info: https://lists.linux.it/listinfo/ltp
  
  ^ permalink raw reply related	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2024-03-30 18:09 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-03-30 18:08 [LTP] [PATCH 1/2] tst_net.sh: tst_ping(): check for ping -I support Petr Vorel
2024-03-30 18:08 ` [LTP] [PATCH 2/2] network/README: Document ping dependencies Petr Vorel

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).