From: Petr Vorel <pvorel@suse.cz>
To: Li Wang <liwang@redhat.com>
Cc: ltp@lists.linux.it
Subject: Re: [LTP] [PATCH 1/1] libs: Remove 'libltp' prefix from libs source directories
Date: Sat, 20 Apr 2024 10:54:37 +0200 [thread overview]
Message-ID: <20240420085437.GA66478@pevik> (raw)
In-Reply-To: <CAEemH2eZNO=P5c_igqNKSva-q37y7GSK=d44wUHd=Ua=DTUNDw@mail.gmail.com>
Hi Li, Cyril,
> Hi Petr, Cyril,
> On Fri, Apr 19, 2024 at 7:02 PM Petr Vorel <pvorel@suse.cz> wrote:
> > LTP internal libraries are located in libs/ directory. There is no need
> > to keep 'libltp' prefix in their own directories. NOTE: resulted
> > libraries (*.a) keep expected 'libltp' prefix.
> > Signed-off-by: Petr Vorel <pvorel@suse.cz>
> > ---
> > Hi Li, Cyril,
> > I know renaming files is not optimal. But history will be kept, when
> > browsing with gitk or git gui.
> > Improvement: less typing when cd to the directory.
> +1 I agree with this, and I always have a question, why
> we have additional libs/ parallel with lib/, is there any root
lib/ sources results in libltp.a, the others results in their own libs.
Although lib/ vs libs/ is a bit strange, kept these libraries separate
(i.e. no move libs/*/ into lib/), because these libraries are built only when
they are needed. I.e. for testing random test one does not need to wait for
building these additional libraries (although building them does not take long,
building LTP main library and tests takes much longer). But if we want, we can
move them to lib/ (as a separate effort, even this might make some patches in
ML unapplicable without patch modification).
> difference between them? or just a historical issue?
> Anyway, this patch looks good to me.
Thanks!
Kind regards,
Petr
> > Tested:
> > https://github.com/pevik/ltp/actions/runs/8752048451
> > Kind regards,
> > Petr
--
Mailing list info: https://lists.linux.it/listinfo/ltp
prev parent reply other threads:[~2024-04-20 8:55 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-19 11:02 [LTP] [PATCH 1/1] libs: Remove 'libltp' prefix from libs source directories Petr Vorel
2024-04-20 1:41 ` Li Wang
2024-04-20 8:54 ` Petr Vorel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240420085437.GA66478@pevik \
--to=pvorel@suse.cz \
--cc=liwang@redhat.com \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).