From: Petr Vorel <pvorel@suse.cz>
To: Cyril Hrubis <chrubis@suse.cz>,
Hui Min Mina Chou <minachou@andestech.com>,
ltp@lists.linux.it, tim609@andestech.com, cynthia@andestech.com
Subject: Re: [LTP] [PATCH] syscalls/setitimer: Pass the kernel-defined struct __kernel_old_itimerval to sys_setitimer().
Date: Wed, 15 May 2024 09:30:23 +0200 [thread overview]
Message-ID: <20240515073023.GA200917@pevik> (raw)
In-Reply-To: <20240515072120.GB197249@pevik>
Hi Cyril,
> Hi all,
...
> > Also we should really add tests for the libc wrapper as well, since that
> > is actually more likely to get broken by the double conversion on 32bit
> > arch, but that should be done in an subsequent patches.
> +1. Adding .test_variants with {g,s}etitimer() for {g,s}etitimer0[12].c should
> be trivial. Or did you mean to have test variants also for other functions in
> include/tst_timer.h (e.g. timerfd_{g,s}ettime()) ?
timerfd_{g,s}ettime() (and other functions) test raw syscall with variants for
64bit and the old 32bit. These tests (in testcases/kernel/syscalls/timerfd) are
already quite complicated. I'm not sure if it's a good idea to add also
timerfd_{g,s}ettime() wrappers. But they should be covered as well, right?
> BTW we already test {g,s}etitimer() libc wrapper in getitimer01.c, therefore we
> already have libc wrapper at least somehow covered (the other two test raw
> syscall).
And we of course test {g,s}etitimer() libc wrappers in open posix testsuite.
Kind regards,
Petr
> Once we agree what to do I'll either post a patch or add a ticket for it (or
> feel free to add a ticket yourself).
...
--
Mailing list info: https://lists.linux.it/listinfo/ltp
prev parent reply other threads:[~2024-05-15 7:30 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-28 8:33 [LTP] [PATCH] syscalls/setitimer: Pass the kernel-defined struct __kernel_old_itimerval to sys_setitimer() Hui Min Mina Chou via ltp
2024-05-10 15:31 ` Petr Vorel
2024-05-13 15:39 ` Cyril Hrubis
2024-05-15 7:21 ` Petr Vorel
2024-05-15 7:30 ` Petr Vorel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240515073023.GA200917@pevik \
--to=pvorel@suse.cz \
--cc=chrubis@suse.cz \
--cc=cynthia@andestech.com \
--cc=ltp@lists.linux.it \
--cc=minachou@andestech.com \
--cc=tim609@andestech.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).