From: Cyril Hrubis <chrubis@suse.cz>
To: Subramanya Swamy <subramanya.swamy.linux@gmail.com>
Cc: ltp@lists.linux.it
Subject: Re: [LTP] [PATCH v3] read_all :catch alignment faults while reading sys entries seen in commit :1bbc21785b7336619fb6a67f1fff5afdaf229acc
Date: Fri, 19 Apr 2024 15:39:22 +0200 [thread overview]
Message-ID: <ZiJ0CkYTHgk3FhRP@yuki> (raw)
In-Reply-To: <20240115133400.2431-1-subramanya.swamy.linux@gmail.com>
Hi!
> ---
> testcases/kernel/fs/read_all/read_all.c | 10 ++--------
> 1 file changed, 2 insertions(+), 8 deletions(-)
>
> diff --git a/testcases/kernel/fs/read_all/read_all.c b/testcases/kernel/fs/read_all/read_all.c
> index ddc48edd8..e87f47979 100644
> --- a/testcases/kernel/fs/read_all/read_all.c
> +++ b/testcases/kernel/fs/read_all/read_all.c
> @@ -251,17 +251,11 @@ static void read_test(const int worker, const char *const path)
> worker_heartbeat(worker);
> /*
> * This could catch any alignment faults while reading sys entries
> - * seen in commit :1bbc21785b7336619fb6a67f1fff5afdaf229acc so reading 1024 bytes
> - * in chunks of 8 bytes 128 times
> + * seen in commit :1bbc21785b7336619fb6a67f1fff5afdaf229acc
The commit id should go into tags.
> */
> char check_buf[7];
> - unsigned int i;
>
> - for (i = 0; i < 128; i++) {
> - count = read(fd, check_buf, sizeof(check_buf));
> - if (count == 0 || count < 0)
> - break;
> - }
> + count = pread(fd, check_buf, sizeof(check_buf), 1);
>
> count = pread(fd, buf, sizeof(buf) - 1, 0);
> elapsed = worker_elapsed(worker);
This is a patch on a top of a patch that does not apply...
What about this change? That should enough to trigger the problem:
diff --git a/testcases/kernel/fs/read_all/read_all.c b/testcases/kernel/fs/read_all/read_all.c
index 266678ea7..86fc6fb61 100644
--- a/testcases/kernel/fs/read_all/read_all.c
+++ b/testcases/kernel/fs/read_all/read_all.c
@@ -228,6 +228,7 @@ static int worker_ttl(const int worker)
static void read_test(const int worker, const char *const path)
{
char buf[BUFFER_SIZE];
+ char odd_buff[7];
int fd;
ssize_t count;
const pid_t pid = workers[worker].pid;
@@ -250,6 +251,8 @@ static void read_test(const int worker, const char *const path)
worker_heartbeat(worker);
count = read(fd, buf, sizeof(buf) - 1);
+ /* read at odd offset triggers bug fixed by 1bbc21785b73 */
+ pread(fd, odd_buf, sizeof(odd_buf), 1);
elapsed = worker_elapsed(worker);
if (count > 0 && verbose) {
@@ -714,4 +717,8 @@ static struct tst_test test = {
.test_all = run,
.forks_child = 1,
.max_runtime = 100,
+ .tags = (const struct tst_tag[]) {
+ {"linux-git", "1bbc21785b73"},
+ {}
+ }
};
--
Cyril Hrubis
chrubis@suse.cz
--
Mailing list info: https://lists.linux.it/listinfo/ltp
prev parent reply other threads:[~2024-04-19 13:40 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-03 12:17 [LTP] [PATCH v1] read_all :catch alignment faults while reading sys entries seen in commit :bc21785b7336619fb6a67f1fff5afdaf229acc Subramanya Swamy
2024-01-03 12:49 ` Cyril Hrubis
2024-01-03 13:42 ` Subramanya
2024-01-03 15:13 ` Cyril Hrubis
2024-01-07 10:16 ` Subramanya Swamy
2024-01-15 13:34 ` [LTP] [PATCH v3] read_all :catch alignment faults while reading sys entries seen in commit :1bbc21785b7336619fb6a67f1fff5afdaf229acc Subramanya Swamy
2024-04-19 13:39 ` Cyril Hrubis [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZiJ0CkYTHgk3FhRP@yuki \
--to=chrubis@suse.cz \
--cc=ltp@lists.linux.it \
--cc=subramanya.swamy.linux@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).