From: Cyril Hrubis <chrubis@suse.cz>
To: Sachin P Bappalige <sachinpb@linux.vnet.ibm.com>
Cc: ltp@lists.linux.it
Subject: Re: [LTP] [PATCH v3] Migrating the libhugetlbfs/testcases/shm-gettest.c test
Date: Fri, 10 May 2024 12:44:17 +0200 [thread overview]
Message-ID: <Zj36gf1qMvdZfFcm@yuki> (raw)
In-Reply-To: <20240307084513.109829-1-sachinpb@linux.vnet.ibm.com>
Hi!
> --- /dev/null
> +++ b/testcases/kernel/mem/hugetlb/hugeshmget/hugeshmget06.c
> @@ -0,0 +1,84 @@
> +// SPDX-License-Identifier: GPL-2.0-or-later
> +/*
> + * Copyright (C) 2005-2006, IBM Corporation.
> + * Author: David Gibson & Adam Litke
> + */
> +
> +/*\
> + * DESCRIPTION
This should be [Description]
> + * hugeshmget06 -
This shouldn't be there.
> + * This testcase creates shared memory segments backed by hugepages,
> + * writes specific patterns to each segment, verifies pattern,
> + * and detaches a shared memory segments in a loop.
> + * It ensures that the hugepage backed shared memory functionalities
> + * works correctly by validating the data written to segment.
> + */
> +
> +#include "hugetlb.h"
> +#include "tst_safe_sysv_ipc.h"
> +
> +#define MNTPOINT "hugetlbfs/"
> +#define NR_HUGEPAGES 4
> +
> +static long hpage_size;
> +static int shmid = -1, key = -1;
> +
> +static void do_shmtest(void)
> +{
> + size_t i, j;
> + char pattern;
> + char *shmaddr;
> +
> + shmaddr = SAFE_SHMAT(shmid, 0, SHM_RND);
> + tst_res(TINFO, "shmaddr: %p\n", shmaddr);
> +
> + for (i = 0; i < NR_HUGEPAGES; i++) {
> + pattern = 65 + (i % 26);
> + tst_res(TINFO, "Touching %p with %c\n",
> + shmaddr + (i * hpage_size), pattern);
Please do not add newlines in the tst_res() format strings. Also this
> + memset(shmaddr + (i * hpage_size), pattern, hpage_size);
> + }
> +
> + for (i = 0; i < NR_HUGEPAGES; i++) {
> + pattern = 65 + (i % 26);
> + tst_res(TINFO, "Verifying %p\n", (shmaddr + (i * hpage_size)));
Here as well.
> + for (j = 0; j < (size_t)hpage_size; j++)
> + if (*(shmaddr + (i * hpage_size) + j) != pattern) {
> + tst_res(TFAIL, "Got wrong byte 0x%02x expected 0x%02x",
> + *(shmaddr + (i * hpage_size) + j),
> + pattern);
> + return;
> + }
> + }
> + SAFE_SHMDT((const void *)shmaddr);
> + tst_res(TPASS, "shm hugepages works correctly");
> +}
> +
> +static void run_test(void)
> +{
> + do_shmtest();
What is the point of this indirection?
Just put the test code in the do_test() function instead.
> +}
> +
> +static void setup(void)
> +{
> + hpage_size = tst_get_hugepage_size();
> + tst_res(TINFO, "hugepage size is %ld", hpage_size);
^
Just one space here.
> + shmid = SAFE_SHMGET(key, NR_HUGEPAGES * hpage_size, SHM_HUGETLB|IPC_CREAT|SHM_R|SHM_W);
> + tst_res(TINFO, "shmid: 0x%x\n", shmid);
^
Here as well, no newlines.
> +}
> +
> +static void cleanup(void)
> +{
> + if (shmid >= 0)
> + SAFE_SHMCTL(shmid, IPC_RMID, NULL);
> +}
> +
> +static struct tst_test test = {
> + .needs_root = 1,
> + .mntpoint = MNTPOINT,
> + .needs_hugetlbfs = 1,
The test does not use the hugetlbfs, no need to mount it at all.
> + .setup = setup,
> + .cleanup = cleanup,
> + .test_all = run_test,
> + .hugepages = {NR_HUGEPAGES, TST_NEEDS},
> +};
> --
> 2.43.0
>
--
Cyril Hrubis
chrubis@suse.cz
--
Mailing list info: https://lists.linux.it/listinfo/ltp
prev parent reply other threads:[~2024-05-10 10:45 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-07 8:45 [LTP] [PATCH v3] Migrating the libhugetlbfs/testcases/shm-gettest.c test Sachin P Bappalige
2024-05-10 10:44 ` Cyril Hrubis [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zj36gf1qMvdZfFcm@yuki \
--to=chrubis@suse.cz \
--cc=ltp@lists.linux.it \
--cc=sachinpb@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).