From: Li-Kuan Ou via lttng-dev <lttng-dev@lists.lttng.org>
To: lttng-dev@lists.lttng.org
Subject: [lttng-dev] [PATCH] Fix: revise urcu_read_lock_update() comment
Date: Tue, 13 Jun 2023 23:45:23 +0800 [thread overview]
Message-ID: <20230613154523.17184-1-k777k777tw@gmail.com> (raw)
Read-side critical section nesting is tracked in lower-order bits
and grace-period phase number use a single high-order bit
Signed-off-by: Li-Kuan Ou <k777k777tw@gmail.com>
---
include/urcu/static/urcu-bp.h | 4 ++--
include/urcu/static/urcu-mb.h | 4 ++--
include/urcu/static/urcu-memb.h | 4 ++--
include/urcu/static/urcu-signal.h | 4 ++--
4 files changed, 8 insertions(+), 8 deletions(-)
diff --git a/include/urcu/static/urcu-bp.h b/include/urcu/static/urcu-bp.h
index 8ba3830..c90c9f1 100644
--- a/include/urcu/static/urcu-bp.h
+++ b/include/urcu/static/urcu-bp.h
@@ -137,8 +137,8 @@ static inline enum urcu_bp_state urcu_bp_reader_state(unsigned long *ctr)
/*
* Helper for _urcu_bp_read_lock(). The format of urcu_bp_gp.ctr (as well as
- * the per-thread rcu_reader.ctr) has the upper bits containing a count of
- * _urcu_bp_read_lock() nesting, and a lower-order bit that contains either zero
+ * the per-thread rcu_reader.ctr) has the lower-order bits containing a count of
+ * _urcu_bp_read_lock() nesting, and a single high-order bit that contains either zero
* or URCU_BP_GP_CTR_PHASE. The smp_mb_slave() ensures that the accesses in
* _urcu_bp_read_lock() happen before the subsequent read-side critical section.
*/
diff --git a/include/urcu/static/urcu-mb.h b/include/urcu/static/urcu-mb.h
index b97e42a..218e2f3 100644
--- a/include/urcu/static/urcu-mb.h
+++ b/include/urcu/static/urcu-mb.h
@@ -63,8 +63,8 @@ extern DECLARE_URCU_TLS(struct urcu_reader, urcu_mb_reader);
/*
* Helper for _urcu_mb_read_lock(). The format of urcu_mb_gp.ctr (as well as
- * the per-thread rcu_reader.ctr) has the upper bits containing a count of
- * _urcu_mb_read_lock() nesting, and a lower-order bit that contains either zero
+ * the per-thread rcu_reader.ctr) has the lower-order bits containing a count of
+ * _urcu_mb_read_lock() nesting, and a single high-order bit that contains either zero
* or URCU_GP_CTR_PHASE. The cmm_smp_mb() ensures that the accesses in
* _urcu_mb_read_lock() happen before the subsequent read-side critical section.
*/
diff --git a/include/urcu/static/urcu-memb.h b/include/urcu/static/urcu-memb.h
index c8d102f..b923f73 100644
--- a/include/urcu/static/urcu-memb.h
+++ b/include/urcu/static/urcu-memb.h
@@ -86,8 +86,8 @@ extern DECLARE_URCU_TLS(struct urcu_reader, urcu_memb_reader);
/*
* Helper for _rcu_read_lock(). The format of urcu_memb_gp.ctr (as well as
- * the per-thread rcu_reader.ctr) has the upper bits containing a count of
- * _rcu_read_lock() nesting, and a lower-order bit that contains either zero
+ * the per-thread rcu_reader.ctr) has the lower-order bits containing a count of
+ * _rcu_read_lock() nesting, and a single high-order bit that contains either zero
* or URCU_GP_CTR_PHASE. The smp_mb_slave() ensures that the accesses in
* _rcu_read_lock() happen before the subsequent read-side critical section.
*/
diff --git a/include/urcu/static/urcu-signal.h b/include/urcu/static/urcu-signal.h
index c7577d3..00588b8 100644
--- a/include/urcu/static/urcu-signal.h
+++ b/include/urcu/static/urcu-signal.h
@@ -64,8 +64,8 @@ extern DECLARE_URCU_TLS(struct urcu_reader, urcu_signal_reader);
/*
* Helper for _rcu_read_lock(). The format of urcu_signal_gp.ctr (as well as
- * the per-thread rcu_reader.ctr) has the upper bits containing a count of
- * _rcu_read_lock() nesting, and a lower-order bit that contains either zero
+ * the per-thread rcu_reader.ctr) has the lower-order bits containing a count of
+ * _rcu_read_lock() nesting, and a single high-order bit that contains either zero
* or URCU_GP_CTR_PHASE. The cmm_barrier() ensures that the accesses in
* _rcu_read_lock() happen before the subsequent read-side critical section.
*/
--
2.34.1
_______________________________________________
lttng-dev mailing list
lttng-dev@lists.lttng.org
https://lists.lttng.org/cgi-bin/mailman/listinfo/lttng-dev
next reply other threads:[~2023-06-13 15:45 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-13 15:45 Li-Kuan Ou via lttng-dev [this message]
2023-06-13 20:16 ` [lttng-dev] [PATCH] Fix: revise urcu_read_lock_update() comment Mathieu Desnoyers via lttng-dev
2023-06-14 1:51 ` Li-Kuan Ou via lttng-dev
2023-06-15 20:26 ` Mathieu Desnoyers via lttng-dev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230613154523.17184-1-k777k777tw@gmail.com \
--to=lttng-dev@lists.lttng.org \
--cc=k777k777tw@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).