Re: [lttng-dev] [PATCH v2] Tests: select_poll_epoll: Add support for _time64 - Alistair Francis via lttng-dev

From: Alistair Francis via lttng-dev <lttng-dev@lists.lttng.org>
To: "Jérémie Galarneau" <jgalar@efficios.com>
Cc: Alistair Francis <alistair.francis@opensource.wdc.com>,
	 "lttng-dev@lists.lttng.org" <lttng-dev@lists.lttng.org>
Subject: Re: [lttng-dev] [PATCH v2] Tests: select_poll_epoll: Add support for _time64
Date: Tue, 31 Jan 2023 18:56:44 +1000	[thread overview]
Message-ID: <CAKmqyKOEfX0tDXSuZGzd5v4HK7yoaJ5ggYUQXCei4dWANOkUOQ@mail.gmail.com> (raw)
In-Reply-To: <YT2PR01MB598408FB1F15EAE0FDF96E3FBCE09@YT2PR01MB5984.CANPRD01.PROD.OUTLOOK.COM>

On Thu, Dec 15, 2022 at 6:20 AM Jérémie Galarneau <jgalar@efficios.com> wrote:
>
> Hi Alistair,
>
> The patch you submitted doesn't pass on x86 and x86-64.

Are you able to provide the failures? It should just be a simple fix

>
> I have written an alternative patch that works on the 32/64 variants of ARM and x86. I could only verify that it builds on RISC-V 64.
>
> Are you able to compile-test it on RISC-V 32?
>
> https://review.lttng.org/c/lttng-tools/+/8907

Thanks!

I am currently having some trouble building it. The requirement on
liburcu >= 0.14 is proving difficult to meet and the patch conflicts
with earlier versions of lttng.

I had a look at the patch though.

It seems like you still call SYS_ppoll, which won't work on 64-bit
time_t 32-bit systems.

Changes like this:

+       #ifdef sys_pselect6_time64
+       test_pselect_time64();
+       #else
       test_pselect();
+       #endif /* sys_pselect6_time64 */

will mean that test_pselect() isn't called on 32-bit platforms with a
5.4+ kernel. Which I thought is what you wanted to avoid.

Alistair
_______________________________________________
lttng-dev mailing list
lttng-dev@lists.lttng.org
https://lists.lttng.org/cgi-bin/mailman/listinfo/lttng-dev