lttng-dev Archive mirror
 help / color / mirror / Atom feed
From: "Jérémie Galarneau via lttng-dev" <lttng-dev@lists.lttng.org>
To: lttng-dev <lttng-dev@lists.lttng.org>
Cc: "thomas.gatterweh@siemens.com" <thomas.gatterweh@siemens.com>
Subject: Re: [lttng-dev] UST context field "ip" is now in decimal since 2.13 instead of hexadecimal as before
Date: Thu, 16 Mar 2023 16:22:34 +0000	[thread overview]
Message-ID: <YT2PR01MB5984E8854B2BD53408235823BCBC9@YT2PR01MB5984.CANPRD01.PROD.OUTLOOK.COM> (raw)
In-Reply-To: <AM7PR10MB3175ABFF6003EA76635C94BB96BE9@AM7PR10MB3175.EURPRD10.PROD.OUTLOOK.COM>


[-- Attachment #1.1: Type: text/plain, Size: 1039 bytes --]

Hi Thomas,

I have submitted a patch on our gerrit, see:
https://review.lttng.org/c/lttng-ust/+/9659

Thanks for the report!
Jérémie

--
Jérémie Galarneau
EfficiOS Inc.
https://www.efficios.com
________________________________
From: lttng-dev <lttng-dev-bounces@lists.lttng.org> on behalf of thomas.gatterweh--- via lttng-dev <lttng-dev@lists.lttng.org>
Sent: March 14, 2023 05:03
To: lttng-dev <lttng-dev@lists.lttng.org>
Subject: [lttng-dev] UST context field "ip" is now in decimal since 2.13 instead of hexadecimal as before


Hi!



In this commit  https://github.com/lttng/lttng-ust/commit/4e48b5d2debaf6c0c598489c183cc6cb2125c8a3  the base for UST context field “ip” was changed from 16 (hexadecimal) to 10 (decimal), most likely an unintentional copy&paste error. See change in lttng-context-ip.c, line 47.

Can it be changed back to 16 (hexadecimal), so that the ip address recorded by this context field gets displayed in hex again, which makes much more sense?



Best regards,

Thomas Gatterweh

[-- Attachment #1.2: Type: text/html, Size: 4526 bytes --]

[-- Attachment #2: Type: text/plain, Size: 156 bytes --]

_______________________________________________
lttng-dev mailing list
lttng-dev@lists.lttng.org
https://lists.lttng.org/cgi-bin/mailman/listinfo/lttng-dev

      reply	other threads:[~2023-03-16 16:24 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-14  9:03 [lttng-dev] UST context field "ip" is now in decimal since 2.13 instead of hexadecimal as before thomas.gatterweh--- via lttng-dev
2023-03-16 16:22 ` Jérémie Galarneau via lttng-dev [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YT2PR01MB5984E8854B2BD53408235823BCBC9@YT2PR01MB5984.CANPRD01.PROD.OUTLOOK.COM \
    --to=lttng-dev@lists.lttng.org \
    --cc=jgalar@efficios.com \
    --cc=thomas.gatterweh@siemens.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).