From: Matthieu Baerts <matttbe@kernel.org>
To: Mat Martineau <martineau@kernel.org>
Cc: mptcp@lists.linux.dev
Subject: Re: [PATCH mptcp-next 3/3] doc: new 'mptcp' page in 'networking'
Date: Sat, 18 May 2024 17:50:48 +0200 [thread overview]
Message-ID: <1ee379f5-e692-44a1-83de-c8a59a7a3c7d@kernel.org> (raw)
In-Reply-To: <67ec014d-134a-28be-f20b-0d4d42a8bafc@kernel.org>
Hi Mat,
On 17/05/2024 22:43, Mat Martineau wrote:
> On Fri, 17 May 2024, Matthieu Baerts (NGI0) wrote:
(...)
> Looks like most of the above is verbatim from mptcp.dev - LGTM
Thank you for the code review!
>
>> +Socket options
>> +--------------
>> +
>> +MPTCP supports most socket options handled by TCP. It is possible
>> some less
>> +common ones are not supported, but contributions are welcomed.
>
> "common options are not supported, but contributions are welcome."
>
>> +
>> +Generally, the same value is propagated to all subflows, including
>> the ones
>> +created later. eBPF can be used to set different values per subflows.
>
> Same edit here as the mptcp.dev PR:
>
> "created after the calls to `setsockopt()`. eBPF can be used to set
> different values per subflow."
(sorry for the duplicated error :) )
I just applied this modification, but using two pairs of backquotes
around 'setsockopt()', because the RST format is used here.
Cheers,
Matt
--
Sponsored by the NGI0 Core fund.
next prev parent reply other threads:[~2024-05-18 15:50 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-17 17:40 [PATCH mptcp-next 0/3] doc: introduce MPTCP global doc Matthieu Baerts (NGI0)
2024-05-17 17:40 ` [PATCH mptcp-next 1/3] doc: mptcp: add missing 'available_schedulers' entry Matthieu Baerts (NGI0)
2024-05-17 20:34 ` Mat Martineau
2024-05-17 17:40 ` [PATCH mptcp-next 2/3] doc: mptcp: alphabetical order Matthieu Baerts (NGI0)
2024-05-17 20:37 ` Mat Martineau
2024-05-18 15:46 ` Matthieu Baerts
2024-05-17 17:40 ` [PATCH mptcp-next 3/3] doc: new 'mptcp' page in 'networking' Matthieu Baerts (NGI0)
2024-05-17 20:43 ` Mat Martineau
2024-05-18 15:50 ` Matthieu Baerts [this message]
2024-05-17 18:28 ` [PATCH mptcp-next 0/3] doc: introduce MPTCP global doc MPTCP CI
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1ee379f5-e692-44a1-83de-c8a59a7a3c7d@kernel.org \
--to=matttbe@kernel.org \
--cc=martineau@kernel.org \
--cc=mptcp@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).