From: Geliang Tang <geliang@kernel.org>
To: mptcp@lists.linux.dev
Cc: Geliang Tang <tanggeliang@kylinos.cn>
Subject: [PATCH mptcp-next v2 9/9] selftests: mptcp: netlink: drop disable=SC2086
Date: Sat, 16 Mar 2024 11:50:37 +0800 [thread overview]
Message-ID: <684b53f36e84de0281604d06045facde8b02a733.1710560839.git.tanggeliang@kylinos.cn> (raw)
In-Reply-To: <cover.1710560839.git.tanggeliang@kylinos.cn>
From: Geliang Tang <tanggeliang@kylinos.cn>
Now there are only a few of variables are not using double quotes.
Modifying them, then "shellcheck disable=SC2086" can be dropped.
Signed-off-by: Geliang Tang <tanggeliang@kylinos.cn>
---
tools/testing/selftests/net/mptcp/pm_netlink.sh | 11 +++--------
1 file changed, 3 insertions(+), 8 deletions(-)
diff --git a/tools/testing/selftests/net/mptcp/pm_netlink.sh b/tools/testing/selftests/net/mptcp/pm_netlink.sh
index b48476d73e9e..e4f5f1f9ab95 100755
--- a/tools/testing/selftests/net/mptcp/pm_netlink.sh
+++ b/tools/testing/selftests/net/mptcp/pm_netlink.sh
@@ -1,11 +1,6 @@
#!/bin/bash
# SPDX-License-Identifier: GPL-2.0
-# Double quotes to prevent globbing and word splitting is recommended in new
-# code but we accept it, especially because there were too many before having
-# address all other issues detected by shellcheck.
-#shellcheck disable=SC2086
-
. "$(dirname "${0}")/mptcp_lib.sh"
ret=0
@@ -20,14 +15,14 @@ optstring=hi
while getopts "$optstring" option;do
case "$option" in
"h")
- usage $0
+ usage "$0"
exit ${KSFT_PASS}
;;
"i")
mptcp_lib_set_ip_mptcp
;;
"?")
- usage $0
+ usage "$0"
exit ${KSFT_FAIL}
;;
esac
@@ -40,7 +35,7 @@ err=$(mktemp)
#shellcheck disable=SC2317
cleanup()
{
- rm -f $err
+ rm -f "${err}"
mptcp_lib_ns_exit "${ns1}"
}
--
2.40.1
prev parent reply other threads:[~2024-03-16 3:51 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-16 3:50 [PATCH mptcp-next v2 0/9] add helpers and vars in mptcp_lib.sh, final Geliang Tang
2024-03-16 3:50 ` [PATCH mptcp-next v2 1/9] selftests: mptcp: export ip_mptcp to mptcp_lib Geliang Tang
2024-03-16 3:50 ` [PATCH mptcp-next v2 2/9] selftests: mptcp: format limits/endpoints outputs Geliang Tang
2024-03-16 3:50 ` [PATCH mptcp-next v2 3/9] selftests: mptcp: add get_limits helper Geliang Tang
2024-03-16 3:50 ` [PATCH mptcp-next v2 4/9] selftests: mptcp: add get_endpoint helper Geliang Tang
2024-03-16 3:50 ` [PATCH mptcp-next v2 5/9] selftests: mptcp: add change_address helper Geliang Tang
2024-03-16 3:50 ` [PATCH mptcp-next v2 6/9] selftests: mptcp: join: update endpoint ops Geliang Tang
2024-03-16 3:50 ` [PATCH mptcp-next v2 7/9] selftests: mptcp: export more " Geliang Tang
2024-03-16 3:50 ` [PATCH mptcp-next v2 8/9] selftests: mptcp: ip_mptcp option for more scripts Geliang Tang
2024-03-16 3:50 ` Geliang Tang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=684b53f36e84de0281604d06045facde8b02a733.1710560839.git.tanggeliang@kylinos.cn \
--to=geliang@kernel.org \
--cc=mptcp@lists.linux.dev \
--cc=tanggeliang@kylinos.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).