From: "Jiawen Wu" <jiawenwu@trustnetic.com>
To: "'Simon Horman'" <horms@kernel.org>
Cc: <davem@davemloft.net>, <edumazet@google.com>, <kuba@kernel.org>,
<pabeni@redhat.com>, <rmk+kernel@armlinux.org.uk>,
<andrew@lunn.ch>, <netdev@vger.kernel.org>,
<mengyuanlou@net-swift.com>, <duanqiangwen@net-swift.com>
Subject: RE: [PATCH net v2 2/4] net: wangxun: fix to change Rx features
Date: Fri, 10 May 2024 09:57:39 +0800 [thread overview]
Message-ID: <011501daa27d$703c9080$50b5b180$@trustnetic.com> (raw)
In-Reply-To: <20240502083614.GC2821784@kernel.org>
> > diff --git a/drivers/net/ethernet/wangxun/libwx/wx_lib.c b/drivers/net/ethernet/wangxun/libwx/wx_lib.c
> > index 6fae161cbcb8..667a5675998c 100644
> > --- a/drivers/net/ethernet/wangxun/libwx/wx_lib.c
> > +++ b/drivers/net/ethernet/wangxun/libwx/wx_lib.c
> > @@ -2690,12 +2690,14 @@ int wx_set_features(struct net_device *netdev, netdev_features_t features)
> > wx->rss_enabled = false;
> > }
> >
> > + netdev->features = features;
> > +
>
> nit: I think it would be slightly nicer to place this
> at the end of the function, just before return.
> But it would make no difference to the logic,
> so I don't feel strongly about this.
Thanks for your notice, but it does have to be written here.
Since 'netdev->features' will be checked in wx_set_rx_mode().
>
> > if (changed &
> > (NETIF_F_HW_VLAN_CTAG_RX |
> > NETIF_F_HW_VLAN_STAG_RX))
> > wx_set_rx_mode(netdev);
> >
> > - return 1;
> > + return 0;
> > }
> > EXPORT_SYMBOL(wx_set_features);
> >
> > --
> > 2.27.0
> >
> >
>
next prev parent reply other threads:[~2024-05-10 2:01 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-29 10:25 [PATCH net v2 0/4] Wangxun fixes Jiawen Wu
2024-04-29 10:25 ` [PATCH net v2 1/4] net: wangxun: fix the incorrect display of queue number in statistics Jiawen Wu
2024-05-01 1:59 ` Jakub Kicinski
2024-05-09 2:39 ` Jiawen Wu
2024-05-09 15:19 ` Jakub Kicinski
2024-04-29 10:25 ` [PATCH net v2 2/4] net: wangxun: fix to change Rx features Jiawen Wu
2024-05-02 8:36 ` Simon Horman
2024-05-10 1:57 ` Jiawen Wu [this message]
2024-04-29 10:25 ` [PATCH net v2 3/4] net: wangxun: match VLAN CTAG and STAG features Jiawen Wu
2024-04-29 16:07 ` Sai Krishna Gajula
2024-05-02 8:29 ` Simon Horman
2024-04-29 10:25 ` [PATCH net v2 4/4] net: txgbe: fix to control VLAN strip Jiawen Wu
2024-05-02 9:25 ` Simon Horman
2024-05-09 3:08 ` Jiawen Wu
2024-05-09 13:38 ` Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='011501daa27d$703c9080$50b5b180$@trustnetic.com' \
--to=jiawenwu@trustnetic.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=duanqiangwen@net-swift.com \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=kuba@kernel.org \
--cc=mengyuanlou@net-swift.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=rmk+kernel@armlinux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).