* [PATCH net-next 0/5] DSA/switchdev documentation fixups
@ 2021-03-17 17:44 Vladimir Oltean
2021-03-17 17:44 ` [PATCH net-next 1/5] Documentation: networking: switchdev: separate bulleted items with new line Vladimir Oltean
` (5 more replies)
0 siblings, 6 replies; 7+ messages in thread
From: Vladimir Oltean @ 2021-03-17 17:44 UTC (permalink / raw
To: netdev, David S . Miller, Jakub Kicinski
Cc: Andrew Lunn, Florian Fainelli, Vivien Didelot, Jiri Pirko,
Ido Schimmel, Stephen Rothwell
These are some small fixups after the recently merged documentation
update.
Vladimir Oltean (5):
Documentation: networking: switchdev: separate bulleted items with new
line
Documentation: networking: switchdev: add missing "and" word
Documentation: networking: dsa: add missing new line in devlink
section
Documentation: networking: dsa: demote subsections to simple
emphasized words
Documentation: networking: dsa: mention that the master is brought up
automatically
.../networking/dsa/configuration.rst | 330 +++++++++---------
Documentation/networking/dsa/dsa.rst | 1 +
Documentation/networking/switchdev.rst | 3 +-
3 files changed, 169 insertions(+), 165 deletions(-)
--
2.25.1
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH net-next 1/5] Documentation: networking: switchdev: separate bulleted items with new line
2021-03-17 17:44 [PATCH net-next 0/5] DSA/switchdev documentation fixups Vladimir Oltean
@ 2021-03-17 17:44 ` Vladimir Oltean
2021-03-17 17:44 ` [PATCH net-next 2/5] Documentation: networking: switchdev: add missing "and" word Vladimir Oltean
` (4 subsequent siblings)
5 siblings, 0 replies; 7+ messages in thread
From: Vladimir Oltean @ 2021-03-17 17:44 UTC (permalink / raw
To: netdev, David S . Miller, Jakub Kicinski
Cc: Andrew Lunn, Florian Fainelli, Vivien Didelot, Jiri Pirko,
Ido Schimmel, Stephen Rothwell
It looks like "make htmldocs" produces this warning:
Documentation/networking/switchdev.rst:482: WARNING: Unexpected indentation.
Fixes: 0f22ad45f47c ("Documentation: networking: switchdev: clarify device driver behavior")
Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>
---
Documentation/networking/switchdev.rst | 1 +
1 file changed, 1 insertion(+)
diff --git a/Documentation/networking/switchdev.rst b/Documentation/networking/switchdev.rst
index 1b56367d85ad..aa78102c9fab 100644
--- a/Documentation/networking/switchdev.rst
+++ b/Documentation/networking/switchdev.rst
@@ -479,6 +479,7 @@ is not possible.
be added to a second bridge, which includes other switch ports or software
interfaces. Some approaches to ensure that the forwarding domain for traffic
belonging to the VLAN upper interfaces are managed properly:
+
* If forwarding destinations can be managed per VLAN, the hardware could be
configured to map all traffic, except the packets tagged with a VID
belonging to a VLAN upper interface, to an internal VID corresponding to
--
2.25.1
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [PATCH net-next 2/5] Documentation: networking: switchdev: add missing "and" word
2021-03-17 17:44 [PATCH net-next 0/5] DSA/switchdev documentation fixups Vladimir Oltean
2021-03-17 17:44 ` [PATCH net-next 1/5] Documentation: networking: switchdev: separate bulleted items with new line Vladimir Oltean
@ 2021-03-17 17:44 ` Vladimir Oltean
2021-03-17 17:44 ` [PATCH net-next 3/5] Documentation: networking: dsa: add missing new line in devlink section Vladimir Oltean
` (3 subsequent siblings)
5 siblings, 0 replies; 7+ messages in thread
From: Vladimir Oltean @ 2021-03-17 17:44 UTC (permalink / raw
To: netdev, David S . Miller, Jakub Kicinski
Cc: Andrew Lunn, Florian Fainelli, Vivien Didelot, Jiri Pirko,
Ido Schimmel, Stephen Rothwell, Ido Schimmel
Even though this is clear from the context, it is nice to actually be
grammatically correct.
Fixes: 0f22ad45f47c ("Documentation: networking: switchdev: clarify device driver behavior")
Reported-by: Ido Schimmel <idosch@nvidia.com>
Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>
---
Documentation/networking/switchdev.rst | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Documentation/networking/switchdev.rst b/Documentation/networking/switchdev.rst
index aa78102c9fab..f1f4e6a85a29 100644
--- a/Documentation/networking/switchdev.rst
+++ b/Documentation/networking/switchdev.rst
@@ -523,7 +523,7 @@ as untagged packets, since the bridge device does not allow the manipulation of
VID 0 in its database.
When the bridge has VLAN filtering enabled and a PVID is not configured on the
-ingress port, untagged 802.1p tagged packets must be dropped. When the bridge
+ingress port, untagged and 802.1p tagged packets must be dropped. When the bridge
has VLAN filtering enabled and a PVID exists on the ingress port, untagged and
priority-tagged packets must be accepted and forwarded according to the
bridge's port membership of the PVID VLAN. When the bridge has VLAN filtering
--
2.25.1
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [PATCH net-next 3/5] Documentation: networking: dsa: add missing new line in devlink section
2021-03-17 17:44 [PATCH net-next 0/5] DSA/switchdev documentation fixups Vladimir Oltean
2021-03-17 17:44 ` [PATCH net-next 1/5] Documentation: networking: switchdev: separate bulleted items with new line Vladimir Oltean
2021-03-17 17:44 ` [PATCH net-next 2/5] Documentation: networking: switchdev: add missing "and" word Vladimir Oltean
@ 2021-03-17 17:44 ` Vladimir Oltean
2021-03-17 17:44 ` [PATCH net-next 4/5] Documentation: networking: dsa: demote subsections to simple emphasized words Vladimir Oltean
` (2 subsequent siblings)
5 siblings, 0 replies; 7+ messages in thread
From: Vladimir Oltean @ 2021-03-17 17:44 UTC (permalink / raw
To: netdev, David S . Miller, Jakub Kicinski
Cc: Andrew Lunn, Florian Fainelli, Vivien Didelot, Jiri Pirko,
Ido Schimmel, Stephen Rothwell
"make htmldocs" produces these warnings:
Documentation/networking/dsa/dsa.rst:468: WARNING: Unexpected indentation.
Documentation/networking/dsa/dsa.rst:477: WARNING: Block quote ends without a blank line; unexpected unindent.
Fixes: 8411abbcad8e ("Documentation: networking: dsa: mention integration with devlink")
Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>
---
Documentation/networking/dsa/dsa.rst | 1 +
1 file changed, 1 insertion(+)
diff --git a/Documentation/networking/dsa/dsa.rst b/Documentation/networking/dsa/dsa.rst
index 69040e11ee5e..8688009514cc 100644
--- a/Documentation/networking/dsa/dsa.rst
+++ b/Documentation/networking/dsa/dsa.rst
@@ -464,6 +464,7 @@ For each devlink device, every physical port (i.e. user ports, CPU ports, DSA
links or unused ports) is exposed as a devlink port.
DSA drivers can make use of the following devlink features:
+
- Regions: debugging feature which allows user space to dump driver-defined
areas of hardware information in a low-level, binary format. Both global
regions as well as per-port regions are supported. It is possible to export
--
2.25.1
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [PATCH net-next 4/5] Documentation: networking: dsa: demote subsections to simple emphasized words
2021-03-17 17:44 [PATCH net-next 0/5] DSA/switchdev documentation fixups Vladimir Oltean
` (2 preceding siblings ...)
2021-03-17 17:44 ` [PATCH net-next 3/5] Documentation: networking: dsa: add missing new line in devlink section Vladimir Oltean
@ 2021-03-17 17:44 ` Vladimir Oltean
2021-03-17 17:44 ` [PATCH net-next 5/5] Documentation: networking: dsa: mention that the master is brought up automatically Vladimir Oltean
2021-03-17 19:40 ` [PATCH net-next 0/5] DSA/switchdev documentation fixups patchwork-bot+netdevbpf
5 siblings, 0 replies; 7+ messages in thread
From: Vladimir Oltean @ 2021-03-17 17:44 UTC (permalink / raw
To: netdev, David S . Miller, Jakub Kicinski
Cc: Andrew Lunn, Florian Fainelli, Vivien Didelot, Jiri Pirko,
Ido Schimmel, Stephen Rothwell
"make htmldocs" complains:
configuration.rst:165: WARNING: duplicate label networking/dsa/configuration:single port, other instance in (...)
configuration.rst:212: WARNING: duplicate label networking/dsa/configuration:bridge, other instance in (...)
configuration.rst:252: WARNING: duplicate label networking/dsa/configuration:gateway, other instance in (...)
And for good reason, because the "single port", "bridge" and "gateway"
use cases are replicated twice, once for normal taggers and twice for
DSA_TAG_PROTO_NONE. So when trying to reference these sections via a
hyperlink such as:
https://www.kernel.org/doc/html/latest/networking/dsa/configuration.html#single-port
it will always reference the first occurrence, and never the second one.
This change makes the "single port", "bridge" and "gateway"
configuration examples consistent with the formatting used in the
"Configuration showcases" subsection.
Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>
---
.../networking/dsa/configuration.rst | 295 +++++++++---------
1 file changed, 142 insertions(+), 153 deletions(-)
diff --git a/Documentation/networking/dsa/configuration.rst b/Documentation/networking/dsa/configuration.rst
index 11bd5e6108c0..d20b908bd861 100644
--- a/Documentation/networking/dsa/configuration.rst
+++ b/Documentation/networking/dsa/configuration.rst
@@ -78,79 +78,73 @@ The tagging based configuration is desired and supported by the majority of
DSA switches. These switches are capable to tag incoming and outgoing traffic
without using a VLAN based configuration.
-single port
-~~~~~~~~~~~
-
-.. code-block:: sh
-
- # configure each interface
- ip addr add 192.0.2.1/30 dev lan1
- ip addr add 192.0.2.5/30 dev lan2
- ip addr add 192.0.2.9/30 dev lan3
-
- # The master interface needs to be brought up before the slave ports.
- ip link set eth0 up
+*single port*
+ .. code-block:: sh
- # bring up the slave interfaces
- ip link set lan1 up
- ip link set lan2 up
- ip link set lan3 up
+ # configure each interface
+ ip addr add 192.0.2.1/30 dev lan1
+ ip addr add 192.0.2.5/30 dev lan2
+ ip addr add 192.0.2.9/30 dev lan3
-bridge
-~~~~~~
+ # The master interface needs to be brought up before the slave ports.
+ ip link set eth0 up
-.. code-block:: sh
+ # bring up the slave interfaces
+ ip link set lan1 up
+ ip link set lan2 up
+ ip link set lan3 up
- # The master interface needs to be brought up before the slave ports.
- ip link set eth0 up
+*bridge*
+ .. code-block:: sh
- # bring up the slave interfaces
- ip link set lan1 up
- ip link set lan2 up
- ip link set lan3 up
+ # The master interface needs to be brought up before the slave ports.
+ ip link set eth0 up
- # create bridge
- ip link add name br0 type bridge
+ # bring up the slave interfaces
+ ip link set lan1 up
+ ip link set lan2 up
+ ip link set lan3 up
- # add ports to bridge
- ip link set dev lan1 master br0
- ip link set dev lan2 master br0
- ip link set dev lan3 master br0
+ # create bridge
+ ip link add name br0 type bridge
- # configure the bridge
- ip addr add 192.0.2.129/25 dev br0
+ # add ports to bridge
+ ip link set dev lan1 master br0
+ ip link set dev lan2 master br0
+ ip link set dev lan3 master br0
- # bring up the bridge
- ip link set dev br0 up
+ # configure the bridge
+ ip addr add 192.0.2.129/25 dev br0
-gateway
-~~~~~~~
+ # bring up the bridge
+ ip link set dev br0 up
-.. code-block:: sh
+*gateway*
+ .. code-block:: sh
- # The master interface needs to be brought up before the slave ports.
- ip link set eth0 up
+ # The master interface needs to be brought up before the slave ports.
+ ip link set eth0 up
- # bring up the slave interfaces
- ip link set wan up
- ip link set lan1 up
- ip link set lan2 up
+ # bring up the slave interfaces
+ ip link set wan up
+ ip link set lan1 up
+ ip link set lan2 up
- # configure the upstream port
- ip addr add 192.0.2.1/30 dev wan
+ # configure the upstream port
+ ip addr add 192.0.2.1/30 dev wan
- # create bridge
- ip link add name br0 type bridge
+ # create bridge
+ ip link add name br0 type bridge
- # add ports to bridge
- ip link set dev lan1 master br0
- ip link set dev lan2 master br0
+ # add ports to bridge
+ ip link set dev lan1 master br0
+ ip link set dev lan2 master br0
- # configure the bridge
- ip addr add 192.0.2.129/25 dev br0
+ # configure the bridge
+ ip addr add 192.0.2.129/25 dev br0
- # bring up the bridge
- ip link set dev br0 up
+ # bring up the bridge
+ ip link set dev br0 up
.. _dsa-vlan-configuration:
@@ -161,132 +155,127 @@ A minority of switches are not capable to use a taging protocol
(DSA_TAG_PROTO_NONE). These switches can be configured by a VLAN based
configuration.
-single port
-~~~~~~~~~~~
-The configuration can only be set up via VLAN tagging and bridge setup.
-
-.. code-block:: sh
-
- # tag traffic on CPU port
- ip link add link eth0 name eth0.1 type vlan id 1
- ip link add link eth0 name eth0.2 type vlan id 2
- ip link add link eth0 name eth0.3 type vlan id 3
+*single port*
+ The configuration can only be set up via VLAN tagging and bridge setup.
- # The master interface needs to be brought up before the slave ports.
- ip link set eth0 up
- ip link set eth0.1 up
- ip link set eth0.2 up
- ip link set eth0.3 up
+ .. code-block:: sh
- # bring up the slave interfaces
- ip link set lan1 up
- ip link set lan2 up
- ip link set lan3 up
+ # tag traffic on CPU port
+ ip link add link eth0 name eth0.1 type vlan id 1
+ ip link add link eth0 name eth0.2 type vlan id 2
+ ip link add link eth0 name eth0.3 type vlan id 3
- # create bridge
- ip link add name br0 type bridge
+ # The master interface needs to be brought up before the slave ports.
+ ip link set eth0 up
+ ip link set eth0.1 up
+ ip link set eth0.2 up
+ ip link set eth0.3 up
- # activate VLAN filtering
- ip link set dev br0 type bridge vlan_filtering 1
+ # bring up the slave interfaces
+ ip link set lan1 up
+ ip link set lan2 up
+ ip link set lan3 up
- # add ports to bridges
- ip link set dev lan1 master br0
- ip link set dev lan2 master br0
- ip link set dev lan3 master br0
+ # create bridge
+ ip link add name br0 type bridge
- # tag traffic on ports
- bridge vlan add dev lan1 vid 1 pvid untagged
- bridge vlan add dev lan2 vid 2 pvid untagged
- bridge vlan add dev lan3 vid 3 pvid untagged
+ # activate VLAN filtering
+ ip link set dev br0 type bridge vlan_filtering 1
- # configure the VLANs
- ip addr add 192.0.2.1/30 dev eth0.1
- ip addr add 192.0.2.5/30 dev eth0.2
- ip addr add 192.0.2.9/30 dev eth0.3
+ # add ports to bridges
+ ip link set dev lan1 master br0
+ ip link set dev lan2 master br0
+ ip link set dev lan3 master br0
- # bring up the bridge devices
- ip link set br0 up
+ # tag traffic on ports
+ bridge vlan add dev lan1 vid 1 pvid untagged
+ bridge vlan add dev lan2 vid 2 pvid untagged
+ bridge vlan add dev lan3 vid 3 pvid untagged
+ # configure the VLANs
+ ip addr add 192.0.2.1/30 dev eth0.1
+ ip addr add 192.0.2.5/30 dev eth0.2
+ ip addr add 192.0.2.9/30 dev eth0.3
-bridge
-~~~~~~
+ # bring up the bridge devices
+ ip link set br0 up
-.. code-block:: sh
- # tag traffic on CPU port
- ip link add link eth0 name eth0.1 type vlan id 1
+*bridge*
+ .. code-block:: sh
- # The master interface needs to be brought up before the slave ports.
- ip link set eth0 up
- ip link set eth0.1 up
+ # tag traffic on CPU port
+ ip link add link eth0 name eth0.1 type vlan id 1
- # bring up the slave interfaces
- ip link set lan1 up
- ip link set lan2 up
- ip link set lan3 up
+ # The master interface needs to be brought up before the slave ports.
+ ip link set eth0 up
+ ip link set eth0.1 up
- # create bridge
- ip link add name br0 type bridge
+ # bring up the slave interfaces
+ ip link set lan1 up
+ ip link set lan2 up
+ ip link set lan3 up
- # activate VLAN filtering
- ip link set dev br0 type bridge vlan_filtering 1
+ # create bridge
+ ip link add name br0 type bridge
- # add ports to bridge
- ip link set dev lan1 master br0
- ip link set dev lan2 master br0
- ip link set dev lan3 master br0
- ip link set eth0.1 master br0
+ # activate VLAN filtering
+ ip link set dev br0 type bridge vlan_filtering 1
- # tag traffic on ports
- bridge vlan add dev lan1 vid 1 pvid untagged
- bridge vlan add dev lan2 vid 1 pvid untagged
- bridge vlan add dev lan3 vid 1 pvid untagged
+ # add ports to bridge
+ ip link set dev lan1 master br0
+ ip link set dev lan2 master br0
+ ip link set dev lan3 master br0
+ ip link set eth0.1 master br0
- # configure the bridge
- ip addr add 192.0.2.129/25 dev br0
+ # tag traffic on ports
+ bridge vlan add dev lan1 vid 1 pvid untagged
+ bridge vlan add dev lan2 vid 1 pvid untagged
+ bridge vlan add dev lan3 vid 1 pvid untagged
- # bring up the bridge
- ip link set dev br0 up
+ # configure the bridge
+ ip addr add 192.0.2.129/25 dev br0
-gateway
-~~~~~~~
+ # bring up the bridge
+ ip link set dev br0 up
-.. code-block:: sh
+*gateway*
+ .. code-block:: sh
- # tag traffic on CPU port
- ip link add link eth0 name eth0.1 type vlan id 1
- ip link add link eth0 name eth0.2 type vlan id 2
+ # tag traffic on CPU port
+ ip link add link eth0 name eth0.1 type vlan id 1
+ ip link add link eth0 name eth0.2 type vlan id 2
- # The master interface needs to be brought up before the slave ports.
- ip link set eth0 up
- ip link set eth0.1 up
- ip link set eth0.2 up
+ # The master interface needs to be brought up before the slave ports.
+ ip link set eth0 up
+ ip link set eth0.1 up
+ ip link set eth0.2 up
- # bring up the slave interfaces
- ip link set wan up
- ip link set lan1 up
- ip link set lan2 up
+ # bring up the slave interfaces
+ ip link set wan up
+ ip link set lan1 up
+ ip link set lan2 up
- # create bridge
- ip link add name br0 type bridge
+ # create bridge
+ ip link add name br0 type bridge
- # activate VLAN filtering
- ip link set dev br0 type bridge vlan_filtering 1
+ # activate VLAN filtering
+ ip link set dev br0 type bridge vlan_filtering 1
- # add ports to bridges
- ip link set dev wan master br0
- ip link set eth0.1 master br0
- ip link set dev lan1 master br0
- ip link set dev lan2 master br0
+ # add ports to bridges
+ ip link set dev wan master br0
+ ip link set eth0.1 master br0
+ ip link set dev lan1 master br0
+ ip link set dev lan2 master br0
- # tag traffic on ports
- bridge vlan add dev lan1 vid 1 pvid untagged
- bridge vlan add dev lan2 vid 1 pvid untagged
- bridge vlan add dev wan vid 2 pvid untagged
+ # tag traffic on ports
+ bridge vlan add dev lan1 vid 1 pvid untagged
+ bridge vlan add dev lan2 vid 1 pvid untagged
+ bridge vlan add dev wan vid 2 pvid untagged
- # configure the VLANs
- ip addr add 192.0.2.1/30 dev eth0.2
- ip addr add 192.0.2.129/25 dev br0
+ # configure the VLANs
+ ip addr add 192.0.2.1/30 dev eth0.2
+ ip addr add 192.0.2.129/25 dev br0
- # bring up the bridge devices
- ip link set br0 up
+ # bring up the bridge devices
+ ip link set br0 up
--
2.25.1
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [PATCH net-next 5/5] Documentation: networking: dsa: mention that the master is brought up automatically
2021-03-17 17:44 [PATCH net-next 0/5] DSA/switchdev documentation fixups Vladimir Oltean
` (3 preceding siblings ...)
2021-03-17 17:44 ` [PATCH net-next 4/5] Documentation: networking: dsa: demote subsections to simple emphasized words Vladimir Oltean
@ 2021-03-17 17:44 ` Vladimir Oltean
2021-03-17 19:40 ` [PATCH net-next 0/5] DSA/switchdev documentation fixups patchwork-bot+netdevbpf
5 siblings, 0 replies; 7+ messages in thread
From: Vladimir Oltean @ 2021-03-17 17:44 UTC (permalink / raw
To: netdev, David S . Miller, Jakub Kicinski
Cc: Andrew Lunn, Florian Fainelli, Vivien Didelot, Jiri Pirko,
Ido Schimmel, Stephen Rothwell
Since commit 9d5ef190e561 ("net: dsa: automatically bring up DSA master
when opening user port"), DSA manages the administrative status of the
host port automatically. Update the configuration steps to reflect this.
Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>
---
.../networking/dsa/configuration.rst | 29 ++++++++++++++-----
1 file changed, 21 insertions(+), 8 deletions(-)
diff --git a/Documentation/networking/dsa/configuration.rst b/Documentation/networking/dsa/configuration.rst
index d20b908bd861..774f0e76c746 100644
--- a/Documentation/networking/dsa/configuration.rst
+++ b/Documentation/networking/dsa/configuration.rst
@@ -34,8 +34,15 @@ interface. The CPU port is the switch port connected to an Ethernet MAC chip.
The corresponding linux Ethernet interface is called the master interface.
All other corresponding linux interfaces are called slave interfaces.
-The slave interfaces depend on the master interface. They can only brought up,
-when the master interface is up.
+The slave interfaces depend on the master interface being up in order for them
+to send or receive traffic. Prior to kernel v5.12, the state of the master
+interface had to be managed explicitly by the user. Starting with kernel v5.12,
+the behavior is as follows:
+
+- when a DSA slave interface is brought up, the master interface is
+ automatically brought up.
+- when the master interface is brought down, all DSA slave interfaces are
+ automatically brought down.
In this documentation the following Ethernet interfaces are used:
@@ -86,7 +93,8 @@ without using a VLAN based configuration.
ip addr add 192.0.2.5/30 dev lan2
ip addr add 192.0.2.9/30 dev lan3
- # The master interface needs to be brought up before the slave ports.
+ # For kernels earlier than v5.12, the master interface needs to be
+ # brought up manually before the slave ports.
ip link set eth0 up
# bring up the slave interfaces
@@ -97,7 +105,8 @@ without using a VLAN based configuration.
*bridge*
.. code-block:: sh
- # The master interface needs to be brought up before the slave ports.
+ # For kernels earlier than v5.12, the master interface needs to be
+ # brought up manually before the slave ports.
ip link set eth0 up
# bring up the slave interfaces
@@ -122,7 +131,8 @@ without using a VLAN based configuration.
*gateway*
.. code-block:: sh
- # The master interface needs to be brought up before the slave ports.
+ # For kernels earlier than v5.12, the master interface needs to be
+ # brought up manually before the slave ports.
ip link set eth0 up
# bring up the slave interfaces
@@ -165,7 +175,8 @@ configuration.
ip link add link eth0 name eth0.2 type vlan id 2
ip link add link eth0 name eth0.3 type vlan id 3
- # The master interface needs to be brought up before the slave ports.
+ # For kernels earlier than v5.12, the master interface needs to be
+ # brought up manually before the slave ports.
ip link set eth0 up
ip link set eth0.1 up
ip link set eth0.2 up
@@ -207,7 +218,8 @@ configuration.
# tag traffic on CPU port
ip link add link eth0 name eth0.1 type vlan id 1
- # The master interface needs to be brought up before the slave ports.
+ # For kernels earlier than v5.12, the master interface needs to be
+ # brought up manually before the slave ports.
ip link set eth0 up
ip link set eth0.1 up
@@ -246,7 +258,8 @@ configuration.
ip link add link eth0 name eth0.1 type vlan id 1
ip link add link eth0 name eth0.2 type vlan id 2
- # The master interface needs to be brought up before the slave ports.
+ # For kernels earlier than v5.12, the master interface needs to be
+ # brought up manually before the slave ports.
ip link set eth0 up
ip link set eth0.1 up
ip link set eth0.2 up
--
2.25.1
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH net-next 0/5] DSA/switchdev documentation fixups
2021-03-17 17:44 [PATCH net-next 0/5] DSA/switchdev documentation fixups Vladimir Oltean
` (4 preceding siblings ...)
2021-03-17 17:44 ` [PATCH net-next 5/5] Documentation: networking: dsa: mention that the master is brought up automatically Vladimir Oltean
@ 2021-03-17 19:40 ` patchwork-bot+netdevbpf
5 siblings, 0 replies; 7+ messages in thread
From: patchwork-bot+netdevbpf @ 2021-03-17 19:40 UTC (permalink / raw
To: Vladimir Oltean
Cc: netdev, davem, kuba, andrew, f.fainelli, vivien.didelot, jiri,
idosch, sfr
Hello:
This series was applied to netdev/net-next.git (refs/heads/master):
On Wed, 17 Mar 2021 19:44:53 +0200 you wrote:
> These are some small fixups after the recently merged documentation
> update.
>
> Vladimir Oltean (5):
> Documentation: networking: switchdev: separate bulleted items with new
> line
> Documentation: networking: switchdev: add missing "and" word
> Documentation: networking: dsa: add missing new line in devlink
> section
> Documentation: networking: dsa: demote subsections to simple
> emphasized words
> Documentation: networking: dsa: mention that the master is brought up
> automatically
>
> [...]
Here is the summary with links:
- [net-next,1/5] Documentation: networking: switchdev: separate bulleted items with new line
https://git.kernel.org/netdev/net-next/c/cfeb961a2b5f
- [net-next,2/5] Documentation: networking: switchdev: add missing "and" word
https://git.kernel.org/netdev/net-next/c/6b38c5719836
- [net-next,3/5] Documentation: networking: dsa: add missing new line in devlink section
https://git.kernel.org/netdev/net-next/c/8794be45cd45
- [net-next,4/5] Documentation: networking: dsa: demote subsections to simple emphasized words
https://git.kernel.org/netdev/net-next/c/e322bacb914d
- [net-next,5/5] Documentation: networking: dsa: mention that the master is brought up automatically
https://git.kernel.org/netdev/net-next/c/0929ff71cf92
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2021-03-17 19:40 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-03-17 17:44 [PATCH net-next 0/5] DSA/switchdev documentation fixups Vladimir Oltean
2021-03-17 17:44 ` [PATCH net-next 1/5] Documentation: networking: switchdev: separate bulleted items with new line Vladimir Oltean
2021-03-17 17:44 ` [PATCH net-next 2/5] Documentation: networking: switchdev: add missing "and" word Vladimir Oltean
2021-03-17 17:44 ` [PATCH net-next 3/5] Documentation: networking: dsa: add missing new line in devlink section Vladimir Oltean
2021-03-17 17:44 ` [PATCH net-next 4/5] Documentation: networking: dsa: demote subsections to simple emphasized words Vladimir Oltean
2021-03-17 17:44 ` [PATCH net-next 5/5] Documentation: networking: dsa: mention that the master is brought up automatically Vladimir Oltean
2021-03-17 19:40 ` [PATCH net-next 0/5] DSA/switchdev documentation fixups patchwork-bot+netdevbpf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).