From: David Wei <dw@davidwei.uk>
To: netdev@vger.kernel.org
Cc: Jakub Kicinski <kuba@kernel.org>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>
Subject: [PATCH net-next v5 0/2] netdevsim: add NAPI support
Date: Tue, 7 May 2024 09:32:26 -0700 [thread overview]
Message-ID: <20240507163228.2066817-1-dw@davidwei.uk> (raw)
Add NAPI support to netdevsim and register its Rx queues with NAPI
instances. Then add a selftest using the new netdev Python selftest
infra to exercise the existing Netdev Netlink API, specifically the
queue-get API.
This expands test coverage and further fleshes out netdevsim as a test
device. It's still my goal to make it useful for testing things like
flow steering and ZC Rx.
-----
Changes since v4:
* Rebase
Changes since v3:
* Add missing ksft_exit() at end of test
* Check for queue-api at start of test and skip early
* Don't swallow exceptions and convert to skip
Changes since v2:
* Fix null-ptr-deref on cleanup path if netdevsim is init as VF
* Handle selftest failure if real netdev fails to change queues
* Selftest addremove_queue test case:
* Skip if queues == 1
* Changes either combined or rx queue depending on how the netdev is
configured
Changes since v1:
* Use sk_buff_head instead of a list for per-rq skb queue
* Drop napi_schedule() if skb queue is not empty in napi poll
* Remove netif_carrier_on() in open()
* Remove unused page pool ptr in struct netdevsim
* Up the netdev in NetDrvEnv automatically
* Pass Netdev Netlink as a param instead of using globals
* Remove unused Python imports in selftest
David Wei (2):
netdevsim: add NAPI support
net: selftest: add test for netdev netlink queue-get API
drivers/net/netdevsim/netdev.c | 209 +++++++++++++++++-
drivers/net/netdevsim/netdevsim.h | 8 +-
tools/testing/selftests/drivers/net/Makefile | 1 +
.../selftests/drivers/net/lib/py/env.py | 6 +-
tools/testing/selftests/drivers/net/queues.py | 66 ++++++
tools/testing/selftests/net/lib/py/nsim.py | 4 +-
tools/testing/selftests/net/lib/py/utils.py | 8 +-
7 files changed, 282 insertions(+), 20 deletions(-)
create mode 100755 tools/testing/selftests/drivers/net/queues.py
--
2.43.0
next reply other threads:[~2024-05-07 16:32 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-07 16:32 David Wei [this message]
2024-05-07 16:32 ` [PATCH net-next v5 1/2] netdevsim: add NAPI support David Wei
2024-05-07 16:32 ` [PATCH net-next v5 2/2] net: selftest: add test for netdev netlink queue-get API David Wei
2024-05-09 2:10 ` [PATCH net-next v5 0/2] netdevsim: add NAPI support patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240507163228.2066817-1-dw@davidwei.uk \
--to=dw@davidwei.uk \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).