From: Shay Drory <shayd@nvidia.com>
To: <netdev@vger.kernel.org>, <pabeni@redhat.com>,
<davem@davemloft.net>, <kuba@kernel.org>, <edumazet@google.com>,
<gregkh@linuxfoundation.org>, <david.m.ertman@intel.com>
Cc: <rafael@kernel.org>, <ira.weiny@intel.com>,
<linux-rdma@vger.kernel.org>, <leon@kernel.org>,
<tariqt@nvidia.com>, Shay Drory <shayd@nvidia.com>
Subject: [PATCH net-next v3 0/2] Introduce auxiliary bus IRQs sysfs
Date: Wed, 8 May 2024 07:04:51 +0300 [thread overview]
Message-ID: <20240508040453.602230-1-shayd@nvidia.com> (raw)
Today, PCI PFs and VFs, which are anchored on the PCI bus, display their
IRQ information in the <pci_device>/msi_irqs/<irq_num> sysfs files.
PCI subfunctions (SFs) are similar to PFs and VFs and these SFs are
anchored on the auxiliary bus. However, these PCI SFs lack such IRQ
information on the auxiliary bus, leaving users without visibility into
which IRQs are used by the SFs. This absence makes it impossible to debug
situations and to understand the source of interrupts/SFs for performance
tuning and debug.
Additionally, the SFs are multifunctional devices supporting RDMA,
network devices, clocks, and more, similar to their peer PCI PFs and
VFs. Therefore, it is desirable to have SFs' IRQ information available
at the bus/device level.
To overcome the above limitations, this short series extends the auxiliary
bus to display IRQ information in sysfs, similar to that of PFs and VFs.
It adds an 'irqs' directory under the auxiliary device and includes an
<irq_num> sysfs file within it. Sometimes, the PCI SF auxiliary devices
share the IRQ with other SFs, a detail that is also not available to the
users. Consequently, this <irq_num> file indicates whether the IRQ is
'exclusive' or 'shared'.
This 'irqs' directory extenstion is optional, i.e. only for PCI SFs the
sysfs irq information is optionally exposed.
For example:
$ ls /sys/bus/auxiliary/devices/mlx5_core.sf.1/irqs/
50 51 52 53 54 55 56 57 58
$ cat /sys/bus/auxiliary/devices/mlx5_core.sf.1/irqs/52
exclusive
Patch summary:
==============
patch-1 adds auxiliary bus to support irqs used by auxiliary device
patch-2 mlx5 driver using exposing irqs for PCI SF devices via auxiliary
bus
---
v2->v3:
- addressed comments from Parav and Przemek in patch #1.
- fixed a bug in patch #2.
v1->v2:
- addressed comments from Greg, Simon H and kernel test boot in patch #1.
Shay Drory (2):
driver core: auxiliary bus: show auxiliary device IRQs
net/mlx5: Expose SFs IRQs
Documentation/ABI/testing/sysfs-bus-auxiliary | 14 ++
drivers/base/auxiliary.c | 170 +++++++++++++++++-
drivers/net/ethernet/mellanox/mlx5/core/eq.c | 6 +-
.../mellanox/mlx5/core/irq_affinity.c | 15 +-
.../ethernet/mellanox/mlx5/core/mlx5_core.h | 6 +
.../ethernet/mellanox/mlx5/core/mlx5_irq.h | 12 +-
.../net/ethernet/mellanox/mlx5/core/pci_irq.c | 12 +-
.../ethernet/mellanox/mlx5/core/sf/dev/dev.c | 2 +-
include/linux/auxiliary_bus.h | 15 +-
9 files changed, 237 insertions(+), 15 deletions(-)
create mode 100644 Documentation/ABI/testing/sysfs-bus-auxiliary
--
2.38.1
next reply other threads:[~2024-05-08 4:05 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-08 4:04 Shay Drory [this message]
2024-05-08 4:04 ` [PATCH net-next v3 1/2] driver core: auxiliary bus: show auxiliary device IRQs Shay Drory
2024-05-08 9:34 ` Przemek Kitszel
2024-05-08 11:33 ` Shay Drori
2024-05-10 13:07 ` Przemek Kitszel
2024-05-12 7:26 ` Shay Drori
2024-05-08 4:04 ` [PATCH net-next v3 2/2] net/mlx5: Expose SFs IRQs Shay Drory
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240508040453.602230-1-shayd@nvidia.com \
--to=shayd@nvidia.com \
--cc=davem@davemloft.net \
--cc=david.m.ertman@intel.com \
--cc=edumazet@google.com \
--cc=gregkh@linuxfoundation.org \
--cc=ira.weiny@intel.com \
--cc=kuba@kernel.org \
--cc=leon@kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=rafael@kernel.org \
--cc=tariqt@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).