From: Xuan Zhuo <xuanzhuo@linux.alibaba.com>
To: netdev@vger.kernel.org
Cc: "Michael S. Tsirkin" <mst@redhat.com>,
Jason Wang <jasowang@redhat.com>,
Xuan Zhuo <xuanzhuo@linux.alibaba.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
virtualization@lists.linux.dev
Subject: [PATCH net-next v4 0/4] virtio_net: rx enable premapped mode by default
Date: Wed, 8 May 2024 14:37:14 +0800 [thread overview]
Message-ID: <20240508063718.69806-1-xuanzhuo@linux.alibaba.com> (raw)
Actually, for the virtio drivers, we can enable premapped mode whatever
the value of use_dma_api. Because we provide the virtio dma apis.
So the driver can enable premapped mode unconditionally.
This patch set makes the big mode of virtio-net to support premapped mode.
And enable premapped mode for rx by default.
Based on the following points, we do not use page pool to manage these
pages:
1. virtio-net uses the DMA APIs wrapped by virtio core. Therefore,
we can only prevent the page pool from performing DMA operations, and
let the driver perform DMA operations on the allocated pages.
2. But when the page pool releases the page, we have no chance to
execute dma unmap.
3. A solution to #2 is to execute dma unmap every time before putting
the page back to the page pool. (This is actually a waste, we don't
execute unmap so frequently.)
4. But there is another problem, we still need to use page.dma_addr to
save the dma address. Using page.dma_addr while using page pool is
unsafe behavior.
5. And we need space the chain the pages submitted once to virtio core.
More:
https://lore.kernel.org/all/CACGkMEu=Aok9z2imB_c5qVuujSh=vjj1kx12fy9N7hqyi+M5Ow@mail.gmail.com/
Why we do not use the page space to store the dma?
http://lore.kernel.org/all/CACGkMEuyeJ9mMgYnnB42=hw6umNuo=agn7VBqBqYPd7GN=+39Q@mail.gmail.com
Please review.
v4:
1. For the conflict, switch to the net-next branch
v3:
1. big mode still use the mode that virtio core does the dma map/unmap
v2:
1. make gcc happy in page_chain_get_dma()
http://lore.kernel.org/all/202404221325.SX5ChRGP-lkp@intel.com
v1:
1. discussed for using page pool
2. use dma sync to replace the unmap for the first page
Thanks.
Xuan Zhuo (4):
virtio_ring: enable premapped mode whatever use_dma_api
virtio_net: big mode skip the unmap check
virtio_net: rx remove premapped failover code
virtio_net: remove the misleading comment
drivers/net/virtio_net.c | 90 +++++++++++++++---------------------
drivers/virtio/virtio_ring.c | 7 +--
2 files changed, 38 insertions(+), 59 deletions(-)
--
2.32.0.3.g01195cf9f
next reply other threads:[~2024-05-08 6:37 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-08 6:37 Xuan Zhuo [this message]
2024-05-08 6:37 ` [PATCH net-next v4 1/4] virtio_ring: enable premapped mode whatever use_dma_api Xuan Zhuo
2024-05-10 7:19 ` Larysa Zaremba
2024-05-08 6:37 ` [PATCH net-next v4 2/4] virtio_net: big mode skip the unmap check Xuan Zhuo
2024-05-08 6:37 ` [PATCH net-next v4 3/4] virtio_net: rx remove premapped failover code Xuan Zhuo
2024-05-10 7:42 ` Larysa Zaremba
2024-05-08 6:37 ` [PATCH net-next v4 4/4] virtio_net: remove the misleading comment Xuan Zhuo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240508063718.69806-1-xuanzhuo@linux.alibaba.com \
--to=xuanzhuo@linux.alibaba.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=jasowang@redhat.com \
--cc=kuba@kernel.org \
--cc=mst@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=virtualization@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).