From: Joe Damato <jdamato@fastly.com>
To: linux-kernel@vger.kernel.org, netdev@vger.kernel.org
Cc: zyjzyj2000@gmail.com, nalramli@fastly.com,
Joe Damato <jdamato@fastly.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>,
Leon Romanovsky <leon@kernel.org>,
linux-rdma@vger.kernel.org (open list:MELLANOX MLX5 core VPI
driver), Paolo Abeni <pabeni@redhat.com>,
Richard Cochran <richardcochran@gmail.com>,
Saeed Mahameed <saeedm@nvidia.com>,
Tariq Toukan <tariqt@nvidia.com>
Subject: [PATCH net-next v2 0/1] mlx5: Add netdev-genl queue stats
Date: Fri, 10 May 2024 04:17:03 +0000 [thread overview]
Message-ID: <20240510041705.96453-1-jdamato@fastly.com> (raw)
Greetings:
Welcome to v2.
I know that this is only 1 patch, so a cover letter isn't necessary, but
worth mentioning a few things.
This change adds support for the per queue netdev-genl API to mlx5,
which seems to output stats:
./cli.py --spec ../../../Documentation/netlink/specs/netdev.yaml \
--dump qstats-get --json '{"scope": "queue"}'
...snip
{'ifindex': 7,
'queue-id': 28,
'queue-type': 'tx',
'tx-bytes': 399462,
'tx-packets': 3311},
...snip
I've used the suggested tooling to verify the per queue stats match
rtnl by doing this:
NETIF=eth0 tools/testing/selftests/drivers/net/stats.py
I've tested the following scenarios:
- The machine at boot (default queue configuration)
- Adjusting the queue configuration to various amounts via ethtool
- Add mqprio TCs
- Removing the mqprio TCs
and in each scenario the stats script above reports that the stats match
rtnl. Hopefully, I got all the test cases right.
Worth noting that Tariq suggested I also export HTB/QOS stats in
mlx5e_get_base_stats.
I am open to doing this, but I think if I were to do that, HTB/QOS queue
stats should also be exported by rtnl so that the script above will
continue to show that the output is correct.
I'd like to propose: adding HTB/QOS to both rtnl *and* the netdev-genl
code together at the same time, but a later time, separate from this
change. Would that be OK?
Special thanks to Jakub, Tariq, Zhu and everyone else who chimed on the
extremely long thread for the v1 trying to help me get this figured out.
Hopefully, this v2 got it right and there won't need to be a v3 :)
Thanks,
Joe
Joe Damato (1):
net/mlx5e: Add per queue netdev-genl stats
.../net/ethernet/mellanox/mlx5/core/en_main.c | 144 ++++++++++++++++++
1 file changed, 144 insertions(+)
--
2.25.1
next reply other threads:[~2024-05-10 4:17 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-10 4:17 Joe Damato [this message]
2024-05-10 4:17 ` [PATCH net-next v2 1/1] net/mlx5e: Add per queue netdev-genl stats Joe Damato
2024-05-13 14:58 ` Jakub Kicinski
2024-05-13 17:33 ` Joe Damato
2024-05-13 18:46 ` Joe Damato
2024-05-13 18:55 ` Jakub Kicinski
2024-05-14 18:44 ` Tariq Toukan
2024-05-14 19:17 ` Joe Damato
2024-05-15 7:19 ` Joe Damato
2024-05-23 7:27 ` Tariq Toukan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240510041705.96453-1-jdamato@fastly.com \
--to=jdamato@fastly.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=leon@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=nalramli@fastly.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=richardcochran@gmail.com \
--cc=saeedm@nvidia.com \
--cc=tariqt@nvidia.com \
--cc=zyjzyj2000@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).