From: Vladimir Oltean <vladimir.oltean@nxp.com>
To: Jakub Kicinski <kuba@kernel.org>
Cc: netdev@vger.kernel.org, "David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>, Shuah Khan <shuah@kernel.org>,
Petr Machata <petrm@nvidia.com>,
Benjamin Poirier <bpoirier@nvidia.com>,
Hangbin Liu <liuhangbin@gmail.com>,
Ido Schimmel <idosch@nvidia.com>, Jiri Pirko <jiri@resnulli.us>,
linux-kselftest@vger.kernel.org,
Joachim Wiberg <troglobit@gmail.com>
Subject: Re: [PATCH net-next] selftests: net: use upstream mtools
Date: Fri, 10 May 2024 18:34:57 +0300 [thread overview]
Message-ID: <20240510153457.wtaycdzg3iwbcq7a@skbuf> (raw)
In-Reply-To: <20240510072424.7c05850b@kernel.org>
On Fri, May 10, 2024 at 07:24:24AM -0700, Jakub Kicinski wrote:
> On Fri, 10 May 2024 14:28:56 +0300 Vladimir Oltean wrote:
> > Check that the deployed mtools version is 3.0 or above. Note that the
> > version check breaks compatibility with my fork
>
> And Joachim's tree from before the tag, the PR was merged a while back
> ;)
Yet "git tag --contains <the pull request>" shows "v3.0". I have no
other reliable way of determining whether IPv6 is supported. Maybe look
at msend -h | grep '\-6'.
> > where I didn't bump the version, but I assume that won't be a problem.
>
> Agreed, no point accumulating more bespoke checks.
> I updated NIPA, next run should have tagged 3.0.
>
> Speaking of requirement checks - I run the test on a fresh Fedora
> install yesterday and it was failing with no indication of why.
> Then I realized tcpdump wasn't installed :(
Huh, for me, "why isn't this running properly?" ends up being answered
by the following Kconfig options not being active:
CONFIG_IP_ADVANCED_ROUTER=y
CONFIG_IP_MULTIPLE_TABLES=y
CONFIG_NET_L3_MASTER_DEV=y
CONFIG_IPV6=y
CONFIG_IPV6_MULTIPLE_TABLES=y
CONFIG_NET_VRF=y
next prev parent reply other threads:[~2024-05-10 15:35 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-10 11:28 [PATCH net-next] selftests: net: use upstream mtools Vladimir Oltean
2024-05-10 14:24 ` Jakub Kicinski
2024-05-10 15:34 ` Vladimir Oltean [this message]
2024-05-13 21:00 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240510153457.wtaycdzg3iwbcq7a@skbuf \
--to=vladimir.oltean@nxp.com \
--cc=bpoirier@nvidia.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=idosch@nvidia.com \
--cc=jiri@resnulli.us \
--cc=kuba@kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=liuhangbin@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=petrm@nvidia.com \
--cc=shuah@kernel.org \
--cc=troglobit@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).