From: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
To: Jesper Dangaard Brouer <hawk@kernel.org>
Cc: "Alexei Starovoitov" <alexei.starovoitov@gmail.com>,
"Toke Høiland-Jørgensen" <toke@redhat.com>,
LKML <linux-kernel@vger.kernel.org>,
"Network Development" <netdev@vger.kernel.org>,
"David S. Miller" <davem@davemloft.net>,
"Boqun Feng" <boqun.feng@gmail.com>,
"Daniel Borkmann" <daniel@iogearbox.net>,
"Eric Dumazet" <edumazet@google.com>,
"Frederic Weisbecker" <frederic@kernel.org>,
"Ingo Molnar" <mingo@redhat.com>,
"Jakub Kicinski" <kuba@kernel.org>,
"Paolo Abeni" <pabeni@redhat.com>,
"Peter Zijlstra" <peterz@infradead.org>,
"Thomas Gleixner" <tglx@linutronix.de>,
"Waiman Long" <longman@redhat.com>,
"Will Deacon" <will@kernel.org>,
"Alexei Starovoitov" <ast@kernel.org>,
"Andrii Nakryiko" <andrii@kernel.org>,
"Eduard Zingerman" <eddyz87@gmail.com>,
"Hao Luo" <haoluo@google.com>, "Jiri Olsa" <jolsa@kernel.org>,
"John Fastabend" <john.fastabend@gmail.com>,
"KP Singh" <kpsingh@kernel.org>,
"Martin KaFai Lau" <martin.lau@linux.dev>,
"Song Liu" <song@kernel.org>,
"Stanislav Fomichev" <sdf@google.com>,
"Yonghong Song" <yonghong.song@linux.dev>,
bpf <bpf@vger.kernel.org>
Subject: Re: [PATCH net-next 14/15 v2] net: Reference bpf_redirect_info via task_struct on PREEMPT_RT.
Date: Fri, 10 May 2024 18:22:14 +0200 [thread overview]
Message-ID: <20240510162214.zNWRKgFU@linutronix.de> (raw)
In-Reply-To: <20240510162121.f-tvqcyf@linutronix.de>
On 2024-05-10 18:21:24 [+0200], To Jesper Dangaard Brouer wrote:
> The XDP redirect process is two staged:
…
On 2024-05-07 15:27:44 [+0200], Jesper Dangaard Brouer wrote:
>
> I need/want to echo Toke's request to benchmark these changes.
I have:
boxA: ixgbe
boxB: i40e
Both are bigger NUMA boxes. I have to patch ixgbe to ignore the 64CPU
limit and I boot box with only 64CPUs. The IOMMU has been disabled on
both box as well as CPU mitigations. The link is 10G.
The base for testing I have is commit a17ef9e6c2c1c ("net_sched:
sch_sfq: annotate data-races around q->perturb_period") which I used to
rebase my series on top of.
pktgen_sample03_burst_single_flow.sh has been used to send packets and
"xdp-bench drop $nic -e" to receive them.
baseline
~~~~~~~~
boxB -> boxA | gov performance
-t2 (to pktgen)
| receive total 14,854,233 pkt/s 14,854,233 drop/s 0 error/s
-t1 (to pktgen)
| receive total 10,642,895 pkt/s 10,642,895 drop/s 0 error/s
boxB -> boxA | gov powersave
-t2 (to pktgen)
receive total 10,196,085 pkt/s 10,196,085 drop/s 0 error/s
receive total 10,187,254 pkt/s 10,187,254 drop/s 0 error/s
receive total 10,553,298 pkt/s 10,553,298 drop/s 0 error/s
-t1
receive total 10,427,732 pkt/s 10,427,732 drop/s 0 error/s
======
boxA -> boxB (-t1) gov performance
performace:
receive total 13,171,962 pkt/s 13,171,962 drop/s 0 error/s
receive total 13,368,344 pkt/s 13,368,344 drop/s 0 error/s
powersave:
receive total 13,343,136 pkt/s 13,343,136 drop/s 0 error/s
receive total 13,220,326 pkt/s 13,220,326 drop/s 0 error/s
(I the CPU governor had no impact, just noise)
The series applied (with updated 14/15)
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
boxB -> boxA | gov performance
-t2:
receive total 14,880,199 pkt/s 14,880,199 drop/s 0 error/s
-t1:
receive total 10,769,082 pkt/s 10,769,082 drop/s 0 error/s
boxB -> boxA | gov powersave
-t2:
receive total 11,163,323 pkt/s 11,163,323 drop/s 0 error/s
-t1:
receive total 10,756,515 pkt/s 10,756,515 drop/s 0 error/s
boxA -> boxB | gov perfomance
receive total 13,395,919 pkt/s 13,395,919 drop/s 0 error/s
boxA -> boxB | gov perfomance
receive total 13,290,527 pkt/s 13,290,527 drop/s 0 error/s
Based on my numbers, there is just noise. BoxA hit the CPU limit during
receive while lowering the CPU-freq. BoxB seems to be unaffected by
lowing CPU frequency during receive.
I can't comment on anything >10G due to HW limits.
Sebastian
next prev parent reply other threads:[~2024-05-10 16:22 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-03 18:25 [PATCH v2 net-next 00/15] locking: Introduce nested-BH locking Sebastian Andrzej Siewior
2024-05-03 18:25 ` [PATCH net-next 01/15] locking/local_lock: Introduce guard definition for local_lock Sebastian Andrzej Siewior
2024-05-03 18:25 ` [PATCH net-next 02/15] locking/local_lock: Add local nested BH locking infrastructure Sebastian Andrzej Siewior
2024-05-03 18:25 ` [PATCH net-next 03/15] net: Use __napi_alloc_frag_align() instead of open coding it Sebastian Andrzej Siewior
2024-05-03 18:25 ` [PATCH net-next 04/15] net: Use nested-BH locking for napi_alloc_cache Sebastian Andrzej Siewior
2024-05-03 18:25 ` [PATCH net-next 05/15] net/tcp_sigpool: Use nested-BH locking for sigpool_scratch Sebastian Andrzej Siewior
2024-05-03 18:25 ` [PATCH net-next 06/15] net/ipv4: Use nested-BH locking for ipv4_tcp_sk Sebastian Andrzej Siewior
2024-05-03 18:25 ` [PATCH net-next 07/15] netfilter: br_netfilter: Use nested-BH locking for brnf_frag_data_storage Sebastian Andrzej Siewior
2024-05-03 18:25 ` [PATCH net-next 08/15] net: softnet_data: Make xmit.recursion per task Sebastian Andrzej Siewior
2024-05-03 18:25 ` [PATCH net-next 09/15] dev: Remove PREEMPT_RT ifdefs from backlog_lock.*() Sebastian Andrzej Siewior
2024-05-03 18:25 ` [PATCH net-next 10/15] dev: Use nested-BH locking for softnet_data.process_queue Sebastian Andrzej Siewior
2024-05-03 18:25 ` [PATCH net-next 11/15] lwt: Don't disable migration prio invoking BPF Sebastian Andrzej Siewior
2024-05-03 18:25 ` [PATCH net-next 12/15] seg6: Use nested-BH locking for seg6_bpf_srh_states Sebastian Andrzej Siewior
2024-05-03 18:25 ` [PATCH net-next 13/15] net: Use nested-BH locking for bpf_scratchpad Sebastian Andrzej Siewior
2024-05-03 18:25 ` [PATCH net-next 14/15] net: Reference bpf_redirect_info via task_struct on PREEMPT_RT Sebastian Andrzej Siewior
2024-05-06 19:41 ` Toke Høiland-Jørgensen
2024-05-06 23:09 ` Alexei Starovoitov
2024-05-07 12:36 ` Sebastian Andrzej Siewior
2024-05-07 13:27 ` Jesper Dangaard Brouer
2024-05-10 16:21 ` [PATCH net-next 14/15 v2] " Sebastian Andrzej Siewior
2024-05-10 16:22 ` Sebastian Andrzej Siewior [this message]
2024-05-14 5:07 ` Jesper Dangaard Brouer
2024-05-14 5:43 ` Sebastian Andrzej Siewior
2024-05-14 12:20 ` Jesper Dangaard Brouer
2024-05-17 16:15 ` Sebastian Andrzej Siewior
2024-05-22 7:09 ` Jesper Dangaard Brouer
2024-05-14 11:54 ` Toke Høiland-Jørgensen
2024-05-15 13:43 ` Sebastian Andrzej Siewior
2024-05-21 1:52 ` Alexei Starovoitov
2024-05-07 10:57 ` [PATCH net-next 14/15] " Sebastian Andrzej Siewior
2024-05-07 13:50 ` Toke Høiland-Jørgensen
2024-05-03 18:25 ` [PATCH net-next 15/15] net: Move per-CPU flush-lists to bpf_net_context " Sebastian Andrzej Siewior
2024-05-06 8:43 ` [PATCH v2 net-next 00/15] locking: Introduce nested-BH locking Paolo Abeni
2024-05-06 9:38 ` Sebastian Andrzej Siewior
2024-05-06 14:12 ` Paolo Abeni
2024-05-06 14:43 ` Sebastian Andrzej Siewior
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240510162214.zNWRKgFU@linutronix.de \
--to=bigeasy@linutronix.de \
--cc=alexei.starovoitov@gmail.com \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=boqun.feng@gmail.com \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=eddyz87@gmail.com \
--cc=edumazet@google.com \
--cc=frederic@kernel.org \
--cc=haoluo@google.com \
--cc=hawk@kernel.org \
--cc=john.fastabend@gmail.com \
--cc=jolsa@kernel.org \
--cc=kpsingh@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=longman@redhat.com \
--cc=martin.lau@linux.dev \
--cc=mingo@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=peterz@infradead.org \
--cc=sdf@google.com \
--cc=song@kernel.org \
--cc=tglx@linutronix.de \
--cc=toke@redhat.com \
--cc=will@kernel.org \
--cc=yonghong.song@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).