From: Linus Walleij <linus.walleij@linaro.org>
To: Hans Ulli Kroll <ulli.kroll@googlemail.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>,
Paolo Abeni <pabeni@redhat.com>, Andrew Lunn <andrew@lunn.ch>
Cc: netdev@vger.kernel.org, Linus Walleij <linus.walleij@linaro.org>
Subject: [PATCH net-next v2 0/5] net: ethernet: cortina: TSO and pause param
Date: Sat, 11 May 2024 00:08:38 +0200 [thread overview]
Message-ID: <20240511-gemini-ethernet-fix-tso-v2-0-2ed841574624@linaro.org> (raw)
This restores the TSO support as we put it on the back
burner a while back. This version has been thoroughly
tested with iperf3 to make sure it really works.
Also included is a patch that implements setting the
RX or TX pause parameters.
To: Hans Ulli Kroll <ulli.kroll@googlemail.com>
To: David S. Miller <davem@davemloft.net>
To: Eric Dumazet <edumazet@google.com>
To: Jakub Kicinski <kuba@kernel.org>
To: Paolo Abeni <pabeni@redhat.com>
To: Andrew Lunn <andrew@lunn.ch>
Cc: netdev@vger.kernel.org
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
Changes in v2:
- Fix up the issue in the previous version where I packed the
TSO segments into too small packets: the TSO hardware
expects the "MTU" to be set to the length of the resulting
ethernet frame for each segment.
- Add a patch to make use of the TSO also when we do not have
any explicit segmenting, which is what the vendor driver
was always doing. This works fine with even frames with custom
DSA tags.
- Add a new patch to rename the gmac_adjust_link callback to
a recognized name.
- Add a new patch to make the driver use the autonegitiated
RX and TX pause settings from phylib.
- Rewrite the set_pauseparam() patch to use the existing
gmac_set_flow_control() function.
- Add a call to phy_set_asym_pause() in the set_pauseparam
callback, so the phylib is informed of the new TX/RX setting.
- Link to v1: https://lore.kernel.org/r/20240509-gemini-ethernet-fix-tso-v1-0-10cd07b54d1c@linaro.org
---
Linus Walleij (5):
net: ethernet: cortina: Restore TSO support
net: ethernet: cortina: Use TSO also on common TCP
net: ethernet: cortina: Rename adjust link callback
net: ethernet: cortina: Use negotiated TX/RX pause
net: ethernet: cortina: Implement .set_pauseparam()
drivers/net/ethernet/cortina/gemini.c | 88 +++++++++++++++++++++++++----------
1 file changed, 63 insertions(+), 25 deletions(-)
---
base-commit: 8eed0f55df3577f279dfa680f3c7f600072abc45
change-id: 20240506-gemini-ethernet-fix-tso-ebc71477c2fb
Best regards,
--
Linus Walleij <linus.walleij@linaro.org>
next reply other threads:[~2024-05-10 22:08 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-10 22:08 Linus Walleij [this message]
2024-05-10 22:08 ` [PATCH net-next v2 1/5] net: ethernet: cortina: Restore TSO support Linus Walleij
2024-05-10 22:08 ` [PATCH net-next v2 2/5] net: ethernet: cortina: Use TSO also on common TCP Linus Walleij
2024-05-10 22:08 ` [PATCH net-next v2 3/5] net: ethernet: cortina: Rename adjust link callback Linus Walleij
2024-05-11 16:21 ` Andrew Lunn
2024-05-10 22:08 ` [PATCH net-next v2 4/5] net: ethernet: cortina: Use negotiated TX/RX pause Linus Walleij
2024-05-11 16:33 ` Andrew Lunn
2024-05-10 22:08 ` [PATCH net-next v2 5/5] net: ethernet: cortina: Implement .set_pauseparam() Linus Walleij
2024-05-11 0:11 ` Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240511-gemini-ethernet-fix-tso-v2-0-2ed841574624@linaro.org \
--to=linus.walleij@linaro.org \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=ulli.kroll@googlemail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).