From: Simon Horman <horms@kernel.org>
To: Anil Samal <anil.samal@intel.com>
Cc: intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org,
leszek.pepiak@intel.com, przemyslaw.kitszel@intel.com,
lukasz.czapnik@intel.com,
Anthony L Nguyen <anthony.l.nguyen@intel.com>,
Jesse Brandeburg <jesse.brandeburg@intel.com>
Subject: Re: [PATCH iwl-next v2 2/3] ice: Implement driver functionality to dump fec statistics
Date: Sat, 11 May 2024 17:57:01 +0100 [thread overview]
Message-ID: <20240511165701.GP2347895@kernel.org> (raw)
In-Reply-To: <20240510065243.906877-3-anil.samal@intel.com>
[ Fixed CC list by dropping '--cc=' from start of addresses. ]
On Thu, May 09, 2024 at 11:50:41PM -0700, Anil Samal wrote:
> To debug link issues in the field, it is paramount to
> dump fec corrected/uncorrected block counts from firmware.
> Firmware requires PCS quad number and PCS port number to
> read FEC statistics. Current driver implementation does
> not maintain above physical properties of a port.
>
> Add new driver API to derive physical properties of an input port.
> These properties include PCS quad number, PCS port number, serdes
> lane count, primary serdes lane number.
>
> Extend ethtool option '--show-fec' to support fec statistics.
> The IEEE standard mandates two sets of counters:
> - 30.5.1.1.17 aFECCorrectedBlocks
> - 30.5.1.1.18 aFECUncorrectableBlocks
>
> Standard defines above statistics per lane but current
> implementation supports total FEC statistics per port
> i.e. sum of all lane per port. Find sample output below
>
> # ethtool -I --show-fec ens21f0np0
> FEC parameters for ens21f0np0:
> Supported/Configured FEC encodings: Auto RS BaseR
> Active FEC encoding: RS
> Statistics:
> corrected_blocks: 0
> uncorrectable_blocks: 0
>
> Reviewed-by: Anthony L Nguyen <anthony.l.nguyen@intel.com>
> Reviewed-by: Jesse Brandeburg <jesse.brandeburg@intel.com>
> Signed-off-by: Anil Samal <anil.samal@intel.com>
Reviewed-by: Simon Horman <horms@kernel.org>
next prev parent reply other threads:[~2024-05-11 16:57 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-10 6:50 [PATCH iwl-next v2 0/3] ice:Support to dump PHY config, FEC Anil Samal
2024-05-10 6:50 ` [PATCH iwl-next v2 1/3] ice: Extend Sideband Queue command to support dynamic flag Anil Samal
2024-05-11 16:57 ` Simon Horman
2024-05-24 0:43 ` Jacob Keller
2024-05-10 6:50 ` [PATCH iwl-next v2 2/3] ice: Implement driver functionality to dump fec statistics Anil Samal
2024-05-11 16:57 ` Simon Horman [this message]
2024-05-10 6:50 ` [PATCH iwl-next v2 3/3] ice: Implement driver functionality to dump serdes equalizer values Anil Samal
2024-05-11 16:56 ` Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240511165701.GP2347895@kernel.org \
--to=horms@kernel.org \
--cc=anil.samal@intel.com \
--cc=anthony.l.nguyen@intel.com \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=jesse.brandeburg@intel.com \
--cc=leszek.pepiak@intel.com \
--cc=lukasz.czapnik@intel.com \
--cc=netdev@vger.kernel.org \
--cc=przemyslaw.kitszel@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).